Crash changing Brush size in Grease Pencil #79107

New Issue

Antonio Vazquez · 2020-07-20T10:38:14+02:00

Antonio Vazquez commented

2020-07-20 10:38:14 +02:00

Last source coded compiled at 20/07/2020 10:35

To reproduce:

Open 2D Template.
Draw a line.
Enter in Sculpt mode.
Press F and change radius.
Crash.

The crash callback is:

GPU_texture_free(GPUTexture * tex) Line 1991	C
radial_control_cancel(bContext * C, wmOperator * op) Line 2804	C
radial_control_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 3026	C
wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2018	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2806	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2854	C
wm_event_do_handlers(bContext * C) Line 3283	C

The error is in line 1991 in function GPU_texture_freebecause textis NULL

Last source coded compiled at 20/07/2020 10:35 To reproduce: 1) Open 2D Template. 2) Draw a line. 3) Enter in Sculpt mode. 4) Press `F` and change radius. 5) Crash. The crash callback is: ``` GPU_texture_free(GPUTexture * tex) Line 1991 C radial_control_cancel(bContext * C, wmOperator * op) Line 2804 C radial_control_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 3026 C wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2018 C wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2806 C wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2854 C wm_event_do_handlers(bContext * C) Line 3283 C ``` The error is in line `1991` in function `GPU_texture_free`because `text`is `NULL`

Antonio Vazquez commented

2020-07-20 10:38:14 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2020-07-20 10:39:31 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Antonio Vazquez commented

2020-07-20 10:39:31 +02:00

Added subscribers: @fclem, @Jeroen-Bakker

Antonio Vazquez commented

2020-07-20 10:39:31 +02:00

I could add a check to avoid the free if the texture is NULL, but I prefer @fclem or @Jeroen-Bakker do the fix because they now better than me that area of the code.

Antonio Vazquez commented

2020-07-20 11:25:34 +02:00

Proposed fix:

index f0cd1add48b..d1f65b6271b 100644
    - a/source/blender/windowmanager/intern/wm_operators.c
+++ b/source/blender/windowmanager/intern/wm_operators.c
@@ -2799,7 +2799,9 @@ static void radial_control_cancel(bContext *C, wmOperator *op)
    * new value is displayed in sliders/numfields */

WM_event_add_notifier(C, NC_WINDOW, NULL);

 
- GPU_texture_free(rc->texture);
+  if (rc->texture != NULL) {
+    GPU_texture_free(rc->texture);
+  }

MEM_freeN(rc);

Proposed fix: ```diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c index f0cd1add48b..d1f65b6271b 100644 - a/source/blender/windowmanager/intern/wm_operators.c +++ b/source/blender/windowmanager/intern/wm_operators.c @@ -2799,7 +2799,9 @@ static void radial_control_cancel(bContext *C, wmOperator *op) * new value is displayed in sliders/numfields */ ``` WM_event_add_notifier(C, NC_WINDOW, NULL); ``` - GPU_texture_free(rc->texture); + if (rc->texture != NULL) { + GPU_texture_free(rc->texture); + } ``` MEM_freeN(rc); ``` } ```

Antonio Vazquez commented

2020-07-20 11:34:36 +02:00

Added subscriber: @filedescriptor

blender-admin commented

2020-07-20 15:22:45 +02:00

This issue was referenced by 9016a29f19

This issue was referenced by 9016a29f194194085acfd937f31b80be0f1b0c8e

Antonio Vazquez commented

2020-07-20 15:23:38 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2020-07-20 15:23:38 +02:00

Antonio Vazquez self-assigned this 2020-07-20 15:23:38 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash changing Brush size in Grease Pencil #79107