GPencil: Modifiers don't work after separate strokes and use hide in outliner [issue with multiuser gpencil objects and modifiers] #79273

Open
opened 2020-07-26 05:00:27 +02:00 by Mafer M · 9 comments

System Information
Operating system: Ubuntu 20.04
Graphics card: Mesa Intel® HD Graphics 620 (KBL GT2

Blender Version
Broken: (2.83.3)

Short description of error

The mirroring of a grease pencil object briefly stops being visible after performing a stroke separation.

Exact steps for others to reproduce the error

  1. Boot up Blender's default 2D animation workspace
  2. Draw a stroke on the GP object "Stroke"
  3. Add a mirror modifier to the object.
  4. Draw another stroke
  5. Change to edit mode and select the new stroke
  6. separate said stroke with P, creating "Stroke.001"
  7. Still on edit mode, click on the 'eye' icon on the outliner to make "Stroke" invisible
  8. Click on the eye icon again, the mirroring will have stopped being visible.
  9. Clicking twice on the "Display modifier on viewport" button in the modifier tab fixes the issue.

Status
The "wrong usercount when separating" is fixed, see 4251a87bf6, however the underlying issues with multiuser gpencil and modifiers still remains.
To reproduce:

  • add a gpencil stroke
  • {key Alt + D} duplicate linked
  • add a Thickness modifier.
  • Hide/Unhide the object in outliner.
**System Information** Operating system: Ubuntu 20.04 Graphics card: Mesa Intel® HD Graphics 620 (KBL GT2 **Blender Version** Broken: (2.83.3) **Short description of error** The mirroring of a grease pencil object briefly stops being visible after performing a stroke separation. **Exact steps for others to reproduce the error** 1. Boot up Blender's default 2D animation workspace 2. Draw a stroke on the GP object "Stroke" 3. Add a mirror modifier to the object. 3. Draw another stroke 4. Change to edit mode and select the new stroke 5. separate said stroke with P, creating "Stroke.001" 6. Still on edit mode, click on the 'eye' icon on the outliner to make "Stroke" invisible 7. Click on the eye icon again, the mirroring will have stopped being visible. 8. Clicking twice on the "Display modifier on viewport" button in the modifier tab fixes the issue. **Status** The "wrong usercount when separating" is fixed, see 4251a87bf6, however the underlying issues with multiuser gpencil and modifiers still remains. To reproduce: - add a gpencil stroke - {key Alt + D} duplicate linked - add a Thickness modifier. - Hide/Unhide the object in outliner.
Author

Added subscriber: @MaferM

Added subscriber: @MaferM
Antonio Vazquez changed title from Mirror modifier not visible in GPencil object after separating a stroke from it to GPencil: Modifiers don't work after separate strokes and use hide in outliner 2020-07-26 16:11:36 +02:00

Added subscribers: @lichtwerk, @antoniov

Added subscribers: @lichtwerk, @antoniov

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

I can confirm, but not only for mirror. Any modifier is not evaluated when hide the object from outliner... saving the file fix all problems.

@lichtwerk I have tested and it's a tag missing, but not sure which one. The function is gpencil_stroke_separate_exec. In theory the original and destination datablock are tagged, but I have tested and the function BKE_gpencil_modifiers_calcis not called for this object when hide/unhide in outliner. Could take a look and try to find the missing tag? I'm looking and all looks right.

To Test:

  1. Open 2D template and Draw 2 strokes.
  2. In edit mode use Pto separate one stroke.
  3. In the original GP object add a Thickness modifier.
  4. Hide/Unhide the object in outliner.
I can confirm, but not only for mirror. Any modifier is not evaluated when hide the object from outliner... saving the file fix all problems. @lichtwerk I have tested and it's a tag missing, but not sure which one. The function is `gpencil_stroke_separate_exec`. In theory the original and destination datablock are tagged, but I have tested and the function `BKE_gpencil_modifiers_calc`is not called for this object when hide/unhide in outliner. Could take a look and try to find the missing tag? I'm looking and all looks right. To Test: 1) Open 2D template and Draw 2 strokes. 2) In edit mode use `P`to separate one stroke. 3) In the original GP object add a Thickness modifier. 4) Hide/Unhide the object in outliner.
Author

Thank you very much for the quick response and your hard work!

Thank you very much for the quick response and your hard work!
Philipp Oeser self-assigned this 2020-07-29 10:23:49 +02:00

This issue was referenced by ee43580623

This issue was referenced by ee4358062355ac6a4232f32100c62a49bcb1be27

This issue was referenced by 4251a87bf6

This issue was referenced by 4251a87bf60eece32ae9ff7a7c481f029a1d2d84
Philipp Oeser removed their assignment 2020-07-30 13:17:52 +02:00
Member

I've fixed the wrong usercount on separating [which exposes another issue with gpencil modifiers] in 4251a87bf6 now.
So the underlying issue is still there, but the usecase described here now works.

@antoniov: should we keep this report (altering its description) for the "multiuser-modifier-issue"? Or close and handle that separately?

I've fixed the wrong usercount on separating [which exposes another issue with gpencil modifiers] in 4251a87bf6 now. So the underlying issue is still there, but the usecase described here now works. @antoniov: should we keep this report (altering its description) for the "multiuser-modifier-issue"? Or close and handle that separately?
Philipp Oeser changed title from GPencil: Modifiers don't work after separate strokes and use hide in outliner to GPencil: Modifiers don't work after separate strokes and use hide in outliner [issue with multiuser gpencil objects and modifiers] 2020-07-30 13:22:53 +02:00

@lichtwerk I cannot reproduce the bug now. can you? If you cannot reproduce it, we can close the report.

@lichtwerk I cannot reproduce the bug now. can you? If you cannot reproduce it, we can close the report.
Philipp Oeser removed the
Interest
Grease Pencil
label 2023-02-09 15:19:46 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#79273
No description provided.