Motion Tracking: marker does not remember 'enabled' state #79453

New Issue

Brian E · 2020-08-02T01:27:21+02:00

Brian E commented

2020-08-02 01:27:21 +02:00

System Information
Operating system: Linux-5.7.10-201.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-08-03 12:21, hash: 92f6f6d30e
Worked: 63ee3db96107^
Caused by 63ee3db961

Steps to reproduce

Open blender, new VFX layout
Load moviclip
Add track marker (ctrl+ left mouse button)
Go to another frame
Click 'Enabled' check on track marker to disable it
(Go to yet another frame)
(Click 'Enabled' check on track marker to enable it again)

State is not remembered [these are no real FCurve keyframes, but tracking dopesheet also does not add 'diamonds' -- but prior to 63ee3db961 tracking would remember this]. Instead marker is disabled for all time line.
I've reset system to defaults (File->Defaults->Load Factory settings).

Thanks.

**System Information** Operating system: Linux-5.7.10-201.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-08-03 12:21, hash: `92f6f6d30e` Worked: 63ee3db96107^ Caused by 63ee3db961 **Steps to reproduce** - Open blender, new VFX layout - Load moviclip - Add track marker (ctrl+ left mouse button) - Go to another frame - Click 'Enabled' check on track marker to disable it - (Go to yet another frame) - (Click 'Enabled' check on track marker to enable it again) State is not remembered [these are no real FCurve keyframes, but tracking dopesheet also does not add 'diamonds' -- but prior to 63ee3db961 tracking would remember this]. Instead marker is disabled for all time line. I've reset system to defaults (File->Defaults->Load Factory settings). Thanks.

Brian E commented

2020-08-02 01:27:21 +02:00

Added subscriber: @baeng72

Bent Hillerkus commented

2020-08-02 22:56:22 +02:00

Added subscriber: @bent

Philipp Oeser commented

2020-08-03 11:34:56 +02:00

Added subscribers: @Sergey, @lichtwerk

Philipp Oeser commented

2020-08-03 11:34:56 +02:00

Markers enabled state is not part of autokeying.

Autokeying in general is only for Objects, Bones and Masks (see its tooltip).

In fact, I think there is not really a way to insert/remove keyframes for enabled by hand even (you cannot keyframe that property in the UI)?
It is exposed to RNA though as

clip.tracking.tracks['MyTrack'].markers[0].mute

but the UI is not displaying this directly (UI is using internal template_marker instead)

But even doing it from python, something like

clip.tracking.tracks['MyTrack'].markers[0].keyframe_insert("mute")

will fail because MovieTrackingMarker doesnt have a proper RNA_def_struct_path_func.

So this really is not bug, just asking @Sergey here to check if implementing something like rna_trackingMarker_path would make sense [if that would work properly, we could at least use .keyframe_insert("mute") from python properly]

Markers `enabled` state is not part of autokeying. Autokeying in general is only for Objects, Bones and Masks (see its tooltip). In fact, I think there is not really a way to insert/remove keyframes for enabled by hand even (you cannot keyframe that property in the UI)? It is exposed to RNA though as ``` clip.tracking.tracks['MyTrack'].markers[0].mute ``` but the UI is not displaying this directly (UI is using internal `template_marker` instead) But even doing it from python, something like ``` clip.tracking.tracks['MyTrack'].markers[0].keyframe_insert("mute") ``` will fail because `MovieTrackingMarker` doesnt have a proper `RNA_def_struct_path_func`. So this really is not bug, just asking @Sergey here to check if implementing something like `rna_trackingMarker_path` would make sense [if that would work properly, we could at least use `.keyframe_insert("mute")` from python properly]

Sergey Sharybin commented

2020-08-03 11:46:41 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Sergey Sharybin closed this issue

2020-08-03 11:46:41 +02:00

Sergey Sharybin self-assigned this 2020-08-03 11:46:41 +02:00

Sergey Sharybin commented

2020-08-03 11:46:41 +02:00

Marker defines position starting at the frame the marker is added at, ending at the frame where another marker is inserted, You are adding a single marker, so the fact that it affects the entire timeline is expected.
This property can not be covered with keyframe-based animation, because it controls something which is already very similar to the animation system itself. It is also not enough to implement the path function for RNA as the solver is not using F-Curve based animation for anything other than weight.

Generally, you shouldn't be using animation system to define what happens with the tracking data, but use tracker and some manual input to control what;s going on.

Thanks for the report, but it is not a bug.

Marker defines position starting at the frame the marker is added at, ending at the frame where another marker is inserted, You are adding a single marker, so the fact that it affects the entire timeline is expected. This property can not be covered with keyframe-based animation, because it controls something which is already very similar to the animation system itself. It is also not enough to implement the `path` function for RNA as the solver is not using F-Curve based animation for anything other than weight. Generally, you shouldn't be using animation system to define what happens with the tracking data, but use tracker and some manual input to control what;s going on. Thanks for the report, but it is not a bug.

Philipp Oeser commented

2020-08-03 11:54:54 +02:00

@Sergey: thx pointing that out

Brian E commented

2020-08-03 14:18:58 +02:00

Sigh, thanks for 'burying the lede'.

Did you even load some greenscreen footage into the VFX editor, add a few tracks, enable/disable them at various points and the scrub through the footage from start to finish to see if they 'remember' when they where enabled/disabled?
It works in previous versions, for example, 2.79, 2.80, 2.82, 2.82a. But not in 2.83.3
I'm fucking sorry I mentioned autokeying, I saw it in a tutorial for setting up a keying screen once, so do it automatically when setting up tracking markers.
This is fucking pathetic.
You have seen 'keyframe' and ignored the bug.

Sigh, thanks for 'burying the lede'. Did you even load some greenscreen footage into the VFX editor, add a few tracks, enable/disable them at various points and the scrub through the footage from start to finish to see if they 'remember' when they where enabled/disabled? It works in previous versions, for example, 2.79, 2.80, 2.82, 2.82a. But not in 2.83.3 I'm fucking sorry I mentioned autokeying, I saw it in a tutorial for setting up a keying screen once, so do it automatically when setting up tracking markers. This is fucking pathetic. You have seen 'keyframe' and ignored the bug.

Philipp Oeser commented

2020-08-03 14:49:50 +02:00

Changed status from 'Archived' to: 'Confirmed'

Philipp Oeser reopened this issue

2020-08-03 14:49:50 +02:00

Philipp Oeser commented

2020-08-03 14:49:50 +02:00

This is fucking pathetic.

Please tone down, we are handling lots of reports and if the report is not straight to the point (or is about autokeying -- when in reality it is about something else), then it can happen that things go missing...
But I do see the issue now, will check on this...

> This is fucking pathetic. Please tone down, we are handling *lots* of reports and if the report is not straight to the point (or is about autokeying -- when in reality it is about something else), then it can happen that things go missing... But I do see the issue now, will check on this...

Sergey Sharybin commented

2020-08-03 15:03:24 +02:00

Added subscriber: @JacquesLucke

Sergey Sharybin commented

2020-08-03 15:03:24 +02:00

After looking deeper into the issue, there is indeed a regression caused by 63ee3db961.

However, the feature you are describing has nothing to do with auto-keyframe. You don't need to have it enabled, is totally ignored for such kind of edits.

@JacquesLucke , will you have time to re-iterate over the initial bugfix?

P.S. This is why it is very important to follow bug report guidelines and fill in all requested information in the template.

After looking deeper into the issue, there is indeed a regression caused by 63ee3db961. However, the feature you are describing has nothing to do with auto-keyframe. You don't need to have it enabled, is totally ignored for such kind of edits. @JacquesLucke , will you have time to re-iterate over the initial bugfix? P.S. This is why it is very important to follow bug report guidelines and fill in all requested information in the template.

Philipp Oeser changed title from ~~Blender 2.83.3 doesn't auto keyframe tracks~~ to Motion Tracking: marker does not remember 'enabled' state

2020-08-03 15:05:56 +02:00

Sergey Sharybin was unassigned by Philipp Oeser

2020-08-03 15:05:56 +02:00

Philipp Oeser self-assigned this 2020-08-03 15:12:41 +02:00

Philipp Oeser commented

2020-08-03 15:12:41 +02:00

@JacquesLucke : I think I got it

blender-admin commented

2020-08-03 15:57:07 +02:00

This issue was referenced by f921ae4665

This issue was referenced by f921ae46658348121c3408b01171e0e21667438c

Philipp Oeser commented

2020-08-04 12:58:50 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2020-08-04 12:58:50 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Motion Tracking: marker does not remember 'enabled' state #79453