Sequencer window not updating whilst playing animation #79619

New Issue

ChristopherAnderssarian · 2020-08-07T13:02:48+02:00

2020-08-07 13:02:48 +02:00

System Information
Operating system: Windows 7
GPU: Radeon Vega 64
GPU Software Version: 20.4.2 (2020.0515.1537.28108)
CPU: Intel Core i7-5960X

Blender Version(s)
(listed are versions tested)

Working: 2.79 (sub 00), branch: master, commit date: 2018-03-22 14:10, hash: f4dc9f9d68b, type: Release, build date: 2018-03-22, 09:59 AM
Working: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: f6cb5f54494e, type: Release, build date: 2019-07-29, 09:44 AM
Working: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: 26bd5ebd42e3, type: Release, build date: 2019-11-20, 16:33:00
Working: 2.82 (sub 07), branch: master, commit date: 2020-02-12 16:20, hash: 77d23b0bd76f, type: Release, build date: 2020-02-13, 01:56:46
Working: 2.83.3 LTS, branch: master, commit date: 2020-07-22 06:01, hash: 353e5bd7493e, type: Release, build date: 2020-07-22, 04:04:56
Broken: blender-2.90.0-4f59e4bddcb0-windows64 (BF Build Bot)
Broken: blender-2.91.0-21fec9513969-windows64 (BF Build Bot)

Short description of error

The Sequencer window doesn't update when playing animation.

Exact steps for others to reproduce the error

Open and play

Sequencer_not_updating.blend

**System Information** Operating system: Windows 7 GPU: Radeon Vega 64 GPU Software Version: 20.4.2 (2020.0515.1537.28108) CPU: Intel Core i7-5960X **Blender Version(s)** *(listed are versions tested)* Working: `2.79 (sub 00), branch: master, commit date: 2018-03-22 14:10, hash: f4dc9f9d68b, type: Release, build date: 2018-03-22, 09:59 AM` Working: `2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash: f6cb5f54494e, type: Release, build date: 2019-07-29, 09:44 AM` Working: `2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: 26bd5ebd42e3, type: Release, build date: 2019-11-20, 16:33:00` Working: `2.82 (sub 07), branch: master, commit date: 2020-02-12 16:20, hash: 77d23b0bd76f, type: Release, build date: 2020-02-13, 01:56:46` Working: `2.83.3 LTS, branch: master, commit date: 2020-07-22 06:01, hash: 353e5bd7493e, type: Release, build date: 2020-07-22, 04:04:56` Broken: ` blender-2.90.0-4f59e4bddcb0-windows64` (BF Build Bot) Broken: ` blender-2.91.0-21fec9513969-windows64` (BF Build Bot) **Short description of error** The Sequencer window doesn't update when playing animation. ![Untitled.png](https://archive.blender.org/developer/F8755419/Untitled.png) **Exact steps for others to reproduce the error** Open and play [Sequencer_not_updating.blend](https://archive.blender.org/developer/F8755415/Sequencer_not_updating.blend)

ChristopherAnderssarian commented

2020-08-07 13:02:48 +02:00

Added subscriber: @ChristopherAnderssarian

Philipp Oeser commented

2020-08-07 13:15:55 +02:00

Added subscribers: @iss, @Jeroen-Bakker, @lichtwerk

Philipp Oeser commented

2020-08-07 13:15:55 +02:00

Cannot reproduce here

System Information
Operating system: Linux-5.7.10-201.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100
version: 2.91.0 Alpha, branch: master, commit date: 2020-08-07 09:39, hash: 4ba9d7d71e

might be a GPU thingie?

CC @Jeroen-Bakker : do you have access to a Radeon Vega 64?
CC @iss

Cannot reproduce here **System Information** Operating system: Linux-5.7.10-201.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100 version: 2.91.0 Alpha, branch: master, commit date: 2020-08-07 09:39, hash: `4ba9d7d71e` might be a GPU thingie? CC @Jeroen-Bakker : do you have access to a Radeon Vega 64? CC @iss

Richard Antalik commented

2020-08-07 13:17:07 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2020-08-07 13:17:07 +02:00

I assume this would be broken by cc3e808ab4

I assume this would be broken by cc3e808ab4

Philipp Oeser commented

2020-08-07 13:28:19 +02:00

Just out of curiosity: what exactly is not updating (seems I still cannot reproduce)?

The playhead, the preview window not updating the colors? Timeline header not updating the current frame?

Just out of curiosity: what exactly is not updating (seems I still cannot reproduce)? - The playhead, the preview window not updating the colors? Timeline header not updating the current frame?

Richard Antalik commented

2020-08-07 13:30:49 +02:00

In #79619#992614, @lichtwerk wrote:
Just out of curiosity: what exactly is not updating (seems I still cannot reproduce)?

The playhead, the preview window not updating the colors? Timeline header not updating the current frame?

It is backdrop in timeline. It should show ssame thing as preview, but under strips.
Also cache "indicator" is not updated.

> In #79619#992614, @lichtwerk wrote: > Just out of curiosity: what exactly is not updating (seems I still cannot reproduce)? > - The playhead, the preview window not updating the colors? Timeline header not updating the current frame? It is backdrop in timeline. It should show ssame thing as preview, but under strips. Also cache "indicator" is not updated.

ChristopherAnderssarian commented

2020-08-07 13:32:14 +02:00

@lichtwerk Nothing (Cache display, Colour Strips changing, Backdrop, etc..) updates apart from the play head.

Philipp Oeser commented

2020-08-07 14:12:30 +02:00

Ahh... get it, sorry for the noise, have it too...

Caused by bbb2e0614f though

Ahh... get it, sorry for the noise, have it too... Caused by bbb2e0614f though

Richard Antalik commented

2020-08-07 14:23:02 +02:00

We could draw cache as overlay, not sure about backdrop.

I don't think that content of timeline should be dynamic during playback. only reason why for example animated color strip do change color is that I don't have animation cache that would allow me to draw gradient.

There may be some scenarios of using tools during playback though but that is future.

We could draw cache as overlay, not sure about backdrop. I don't think that content of timeline should be dynamic during playback. only reason why for example animated color strip do change color is that I don't have animation cache that would allow me to draw gradient. There may be some scenarios of using tools during playback though but that is future.

Philipp Oeser commented

2020-08-07 14:39:52 +02:00

I'd say both backdrop is mandatory.

Just dropping the quick-and-dirty fix [which is just disabling the non-redraw optimization for the sequencer], (maybe just for 2.90 release)
P1575: T79619_snippet



diff --git a/source/blender/editors/screen/screen_ops.c b/source/blender/editors/screen/screen_ops.c
index f4d36a15d30..b002b23a7f3 100644
--- a/source/blender/editors/screen/screen_ops.c
+++ b/source/blender/editors/screen/screen_ops.c
@@ -4414,7 +4414,7 @@ static void screen_animation_region_tag_redraw(ScrArea *area,
    * We do need to redraw when this area is in full screen as no other areas
    * will be tagged for redrawing. */
   if ((region->regiontype == RGN_TYPE_WINDOW) &&
-      (ELEM(area->spacetype, SPACE_GRAPH, SPACE_NLA, SPACE_ACTION, SPACE_SEQ)) && !area->full) {
+      (ELEM(area->spacetype, SPACE_GRAPH, SPACE_NLA, SPACE_ACTION)) && !area->full) {
     return;
   }
   ED_region_tag_redraw(region);

I'd say both backdrop is mandatory. Just dropping the quick-and-dirty fix [which is just disabling the non-redraw optimization for the sequencer], (maybe just for 2.90 release) [P1575: T79619_snippet](https://archive.blender.org/developer/P1575.txt) ``` diff --git a/source/blender/editors/screen/screen_ops.c b/source/blender/editors/screen/screen_ops.c index f4d36a15d30..b002b23a7f3 100644 --- a/source/blender/editors/screen/screen_ops.c +++ b/source/blender/editors/screen/screen_ops.c @@ -4414,7 +4414,7 @@ static void screen_animation_region_tag_redraw(ScrArea *area, * We do need to redraw when this area is in full screen as no other areas * will be tagged for redrawing. */ if ((region->regiontype == RGN_TYPE_WINDOW) && - (ELEM(area->spacetype, SPACE_GRAPH, SPACE_NLA, SPACE_ACTION, SPACE_SEQ)) && !area->full) { + (ELEM(area->spacetype, SPACE_GRAPH, SPACE_NLA, SPACE_ACTION)) && !area->full) { return; } ED_region_tag_redraw(region); ```

Jeroen Bakker commented

2020-08-09 08:27:26 +02:00

Not sure how important the cache display is. It was also discussed during the patch. If this is really important we should make the cache drawing more performant and then move it to the overlaydrawing.

For the drop we can go one level deeper and check if it is enabled. It is most of the time not the way users work with the sequencer. It should be a small adjustment to the quick fix above.

In stead of searching we could also add a flag in sequencer runtime. And check this flag if it should be supported. I’m fine to apply the quick fix for now and do the optimizations in 2.91

Not sure how important the cache display is. It was also discussed during the patch. If this is really important we should make the cache drawing more performant and then move it to the overlaydrawing. For the drop we can go one level deeper and check if it is enabled. It is most of the time not the way users work with the sequencer. It should be a small adjustment to the quick fix above. In stead of searching we could also add a flag in sequencer runtime. And check this flag if it should be supported. I’m fine to apply the quick fix for now and do the optimizations in 2.91

ChristopherAnderssarian commented

2020-08-09 12:24:18 +02:00

In #79619#993281, @Jeroen-Bakker wrote:
Not sure how important the cache display is.

I mean, it can mislead users into thinking that the cache is not working correctly but the once they realise it's just the drawing of it, they interact with the timeline just to get up-to-date information and that feels wrong to me...

> In #79619#993281, @Jeroen-Bakker wrote: > Not sure how important the cache display is. I mean, it can mislead users into thinking that the cache is not working correctly but the once they realise it's just the drawing of it, they interact with the timeline just to get up-to-date information and that feels wrong to me...

blender-admin commented

2020-08-10 09:28:18 +02:00

This issue was referenced by f15d33d585

This issue was referenced by f15d33d585d0c98f29aff3dee1e77c79e84c24c0

Jeroen Bakker commented

2020-08-10 09:30:20 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-08-10 09:30:20 +02:00

Jeroen Bakker self-assigned this 2020-08-10 09:30:20 +02:00

Thomas Dinges added this to the 2.90 milestone 2023-02-08 16:25:41 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Sequencer window not updating whilst playing animation #79619