Page MenuHome
Create Task
Maniphest T79692

Full copy of scene makes Blender freeze if there is content directly in the master collection
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version: 2.90.0 Beta, branch: master, commit date: 2020-08-09 12:07, hash: rB00162e6b7b0f
Worked: 2,83,4
Caused by rBeee35ebdfbed: Make `BKE_scene_copy` fully handle all duplicate modes, deep copy included.
rBb05fa123d741: Make `BKE_collection_duplicate able to handle master collections. might also be relevant here

Seems like blender hangs in BKE_id_new_name_validate / check_for_dupid

Exact steps for others to reproduce the error
Move default cube to Scene collection
Try to make full copy of scene.
It happens with custom settings and factory settings too.

Revisions and Commits

rB Blender
rBd2c150772a43 Fix T79692: Full copy of scene makes Blender freeze if there is content…

Related Objects

Event Timeline

Vyacheslav (hitrpr) created this task.Aug 10 2020, 6:02 PM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Aug 11 2020, 9:50 AM
Philipp Oeser (lichtwerk) triaged this task as High priority.
Philipp Oeser (lichtwerk) added a project: Pipeline, Assets & I/O.
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Can confirm, checking...

Philipp Oeser (lichtwerk) added a comment.Aug 11 2020, 10:17 AM

Caused by rBeee35ebdfbed: Make `BKE_scene_copy` fully handle all duplicate modes, deep copy included., seems like it hangs in BKE_id_new_name_validate / check_for_dupid
rBb05fa123d741: Make `BKE_collection_duplicate able to handle master collections. might also be relevant here

Philipp Oeser (lichtwerk) renamed this task from Full copy of scene makes Blender to hang to Full copy of scene makes Blender freeze if there is content directly in the master collection.Aug 11 2020, 10:19 AM
Philipp Oeser (lichtwerk) updated the task description. (Show Details)
Philipp Oeser (lichtwerk) added a subscriber: Bastien Montagne (mont29).

@Bastien Montagne (mont29): Guess this should be solved for 2.90 still?

Philipp Oeser (lichtwerk) added a comment.Aug 11 2020, 10:44 AM

Not quite sure how this should work, looking at code here

/* We never duplicate master collections here, but we can still deep-copy their objects and collections. */
collection_new = collection_old;

and then later, we are adding new objects to the new collection [which is the same as the old for a master collection], while looping over it at the same time.

Why are master collections not duplicated? Arent these per scene @Bastien Montagne (mont29)?
Sounds weird to have the same collection trying to have both old and new objects in it?

Bastien Montagne (mont29) claimed this task.Aug 11 2020, 6:33 PM
Bastien Montagne (mont29) moved this task from Backlog to Blender 2.90 on the Pipeline, Assets & I/O board.
Bastien Montagne (mont29) edited projects, added BF Blender (2.90); removed BF Blender.
Bastien Montagne (mont29) closed this task as Resolved by committing rBd2c150772a43: Fix T79692: Full copy of scene makes Blender freeze if there is content….Aug 11 2020, 6:48 PM
Bastien Montagne (mont29) added a commit: rBd2c150772a43: Fix T79692: Full copy of scene makes Blender freeze if there is content….
Vyacheslav (hitrpr) awarded a token.Aug 12 2020, 11:48 PM