NLM denoiser doesn't like negative light values #79696

New Issue

Niklas Katzer · 2020-08-11T00:44:38+02:00

Niklas Katzer commented

2020-08-11 00:44:38 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1060 3GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.48

Blender Version
Broken: 2.90.0 Beta, branch: master, commit date: 2020-08-09 12:07, hash: 00162e6b7b
Worked: none to my knowledge

Short description of error
was setting up a scene with a character only getting light from one side and the other side is in shadow. put a negative light source on the shadow side and the NLM denoising went crazy (puts really weird artifacts all over the area where the fully-black part starts. looks like this for me: )
have tested and can confirm the error is due to the negative light source.
Both other Denoising methods do not produce this error, only NLM

Exact steps for others to reproduce the error
Added the file that is causing the issue for me. I removed as much geometry as I could, didn't make a new scene that's as simple as possible since the scene provided is rather simple already and because I know for a fact that this one has the error 100% of the time (for me at least)
NLM denoising with negative light error.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1060 3GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.48 **Blender Version** Broken: 2.90.0 Beta, branch: master, commit date: 2020-08-09 12:07, hash: `00162e6b7b` Worked: none to my knowledge **Short description of error** was setting up a scene with a character only getting light from one side and the other side is in shadow. put a negative light source on the shadow side and the NLM denoising went crazy (puts really weird artifacts all over the area where the fully-black part starts. looks like this for me: ![NLM denoising error.png](https://archive.blender.org/developer/F8767502/NLM_denoising_error.png)) have tested and can confirm the error is due to the negative light source. Both other Denoising methods do not produce this error, only NLM **Exact steps for others to reproduce the error** Added the file that is causing the issue for me. I removed as much geometry as I could, didn't make a new scene that's as simple as possible since the scene provided is rather simple already and because I know for a fact that this one has the error 100% of the time (for me at least) [NLM denoising with negative light error.blend](https://archive.blender.org/developer/F8767437/NLM_denoising_with_negative_light_error.blend)

Niklas Katzer commented

2020-08-11 00:44:38 +02:00

Added subscriber: @Shadowreaper