Changing extrapolation in graph editor modifies the tangents. #79804

Closed
opened 2020-08-15 14:57:37 +02:00 by Robert Rioux · 9 comments

System Information
Operating system: Darwin-16.7.0-x86_64-i386-64bit 64 Bits
Graphics card: NVIDIA GeForce GTX 980 OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.18.5 378.05.05.25f19

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-08 15:55, hash: 9f7d84b656
Worked: (newest version of Blender that worked as expected)

Short description of error
Changing extrapolation in graph editor modifies the tangents.

Exact steps for others to reproduce the error
See attached image.Screen Shot 2020-08-15 at 8.48.21 AM.png

**System Information** Operating system: Darwin-16.7.0-x86_64-i386-64bit 64 Bits Graphics card: NVIDIA GeForce GTX 980 OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.18.5 378.05.05.25f19 **Blender Version** Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-08 15:55, hash: `9f7d84b656` Worked: (newest version of Blender that worked as expected) **Short description of error** Changing extrapolation in graph editor modifies the tangents. **Exact steps for others to reproduce the error** See attached image.![Screen Shot 2020-08-15 at 8.48.21 AM.png](https://archive.blender.org/developer/F8783512/Screen_Shot_2020-08-15_at_8.48.21_AM.png)
Author

Added subscriber: @Funnybob

Added subscriber: @Funnybob

Added subscriber: @iss

Added subscriber: @iss

Changed status from 'Needs Triage' to: 'Archived'

Changed status from 'Needs Triage' to: 'Archived'
Richard Antalik self-assigned this 2020-08-19 02:22:26 +02:00

This is working as designed, see https://docs.blender.org/manual/en/dev/editors/graph_editor/fcurves/introduction.html#extrapolation-mode

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors.

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests
For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

This is working as designed, see https://docs.blender.org/manual/en/dev/editors/graph_editor/fcurves/introduction.html#extrapolation-mode Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors. For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug
Author

Hi,

No offense but when a tool doesn’t do what it’s supposed to do, that’s a bug. Here, it’s supposed to extrapolate the curves. That means keeping the tangents the way the are and extend them to infinity. This is not what’s going on. It screws up the animation curves and gives you a totally wrong result. Again, the tangents should not be modified at all when calling the function. The documentation is wrong as the example doesn't show what happens in the case I showed in my example. I gave you a picture to show you that it's broken. I would ask you to please reconsider.

Cheers,

Robert

Hi, No offense but when a tool doesn’t do what it’s supposed to do, that’s a bug. Here, it’s supposed to extrapolate the curves. That means keeping the tangents the way the are and extend them to infinity. This is not what’s going on. It screws up the animation curves and gives you a totally wrong result. Again, the tangents should not be modified at all when calling the function. The documentation is wrong as the example doesn't show what happens in the case I showed in my example. I gave you a picture to show you that it's broken. I would ask you to please reconsider. Cheers, Robert

In #79804#998448, @Funnybob wrote:
Hi,

No offense but when a tool doesn’t do what it’s supposed to do, that’s a bug. Here, it’s supposed to extrapolate the curves. That means keeping the tangents the way the are and extend them to infinity. This is not what’s going on. It screws up the animation curves and gives you a totally wrong result. Again, the tangents should not be modified at all when calling the function. The documentation is wrong as the example doesn't show what happens in the case I showed in my example. I gave you a picture to show you that it's broken. I would ask you to please reconsider.

Cheers,

Robert

I understand your point, and I can agree that it would be nice if you can apply interpolation on only "one side" of curve. But this is not how this feature was intended to work. Your request is not bad, but it doesn't belong to this tracker. Please use following link to request such feature https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

> In #79804#998448, @Funnybob wrote: > Hi, > > No offense but when a tool doesn’t do what it’s supposed to do, that’s a bug. Here, it’s supposed to extrapolate the curves. That means keeping the tangents the way the are and extend them to infinity. This is not what’s going on. It screws up the animation curves and gives you a totally wrong result. Again, the tangents should not be modified at all when calling the function. The documentation is wrong as the example doesn't show what happens in the case I showed in my example. I gave you a picture to show you that it's broken. I would ask you to please reconsider. > > Cheers, > > Robert I understand your point, and I can agree that it would be nice if you can apply interpolation on only "one side" of curve. But this is not how this feature was intended to work. Your request is not bad, but it doesn't belong to this tracker. Please use following link to request such feature https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests
Author

You told me to read the documentation. This is what it says:

Curves ends are straight lines (linear),as defined by the slope of their first and last keyframes.

And that's exactly my point. In the example I gave you on the attached picture, the first tangent is horizontal. So when you extrapolate, the tangent SHOULD stay horizontal but the function breaks the original animation by changing the slope between the first and last keyframes. Only the parts before and after the first keyframe should be modified. It works for the second keyframe but not for the first one. Please get a second opinion on this.

As for being able to apply it only on one side, yes, that would be great, actually a must for an animator. In Maya, it's called infinity before and infinity after.

You told me to read the documentation. This is what it says: Curves ends are straight lines (linear),**as defined by the slope of their first and last keyframes**. And that's exactly my point. In the example I gave you on the attached picture, **the first tangent is horizontal.** So when you extrapolate, the tangent **SHOULD stay horizontal** but the function **breaks the original animation by changing the slope *between* the first and last keyframes**. Only the parts before and after the first keyframe should be modified. It works for the second keyframe but not for the first one. Please get a second opinion on this. As for being able to apply it only on one side, yes, that would be great, actually a must for an animator. In Maya, it's called infinity before and infinity after.

I have looked in the code to see how this works - Blender considers handles to be automatically updated when changing extrapolation, unless you touch them (change type, angle or even scale by 1, so no change really). After handle is changed manually it won't be updated automatically.

So this is obviously by design and it is quite baked in. I wasn't really able to override this behavior in a way that would be acceptable. Otherwise I would post patch so we can consider change.

I have looked in the code to see how this works - Blender considers handles to be automatically updated when changing extrapolation, unless you touch them (change type, angle or even scale by 1, so no change really). After handle is changed manually it won't be updated automatically. So this is obviously by design and it is quite baked in. I wasn't really able to override this behavior in a way that would be acceptable. Otherwise I would post patch so we can consider change.
Author

Yeah, I see what you mean. So if you make keyframes but don't modify the handles at least once, the function doesn't work properly but if you do make a change, then it's ok. Well, now I have a workaround. Thanks Richard for taking the time to figure it out. Your help is appreciated. Cheer.

Yeah, I see what you mean. So if you make keyframes but don't modify the handles at least once, the function doesn't work properly but if you do make a change, then it's ok. Well, now I have a workaround. Thanks Richard for taking the time to figure it out. Your help is appreciated. Cheer.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#79804
No description provided.