Page MenuHome

Crash when joining objects
Closed, ResolvedPublic

Description

System Information
Operating system: Linux-5.4.0-42-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-08-21 07:19, hash: rB41d31e100d9d
Worked: 2.91.0 Alpha, branch: master, commit date: 2020-08-20 06:10, hash: efa7aaa97f5c

Short description of error
When you join objects with Ctrl + J, Blender will crash.

Revisions and Commits

Event Timeline

Sybren A. Stüvel (sybren) changed the task status from Needs Triage to Confirmed.Aug 21 2020, 5:45 PM

This is caused by rBb077de086e14291fe5f7cdf6d3564a8f1cfb9cb3. Other join operators (like joining armatures) crash in a similar way.

This patch resolves the crash in the reported case (joining meshes), but I don't know if it's the proper solution. I'll leave that choice to @Julian Eisel (Severin)

diff --git a/source/blender/editors/mesh/meshtools.c b/source/blender/editors/mesh/meshtools.c
index 5278da67777..89287f6cf3a 100644
--- a/source/blender/editors/mesh/meshtools.c
+++ b/source/blender/editors/mesh/meshtools.c
@@ -740,6 +740,7 @@ int ED_mesh_join_objects_exec(bContext *C, wmOperator *op)
   DEG_id_tag_update(&ob->id, ID_RECALC_TRANSFORM | ID_RECALC_GEOMETRY);
 
   DEG_id_tag_update(&scene->id, ID_RECALC_SELECT);
+  WM_event_add_notifier(C, NC_SCENE | ND_LAYER, scene);
   WM_event_add_notifier(C, NC_SCENE | ND_OB_ACTIVE, scene);
 
   return OPERATOR_FINISHED;