File browser system folders doesn't change with interface language. #80679

New Issue

Richard Antalik · 2020-09-11T05:07:36+02:00

Richard Antalik commented

2020-09-11 05:07:36 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Radeon RX550/550 Series ATI Technologies Inc. 4.5.14736 Core Profile Context 20.8.3 27.20.12027.1001

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-10 21:55, hash: 66078594d1
Worked: (newest version of Blender that worked as expected)

Short description of error
File browser system folders doesn't change with interface language

Exact steps for others to reproduce the error
Be sure to remember visually where language menu is :)

In preferences change language to Simplified Chinese (I haven't tried others)
Close Blender (with autosave preferences)
Open Blender
In preferences change language to English

Open file browser (save file)

System folders are in chinese until next Blender restart.
If system folder is in Recent folders, it has chinese name forever.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: Radeon RX550/550 Series ATI Technologies Inc. 4.5.14736 Core Profile Context 20.8.3 27.20.12027.1001 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-10 21:55, hash: `66078594d1` Worked: (newest version of Blender that worked as expected) **Short description of error** File browser system folders doesn't change with interface language **Exact steps for others to reproduce the error** Be sure to remember visually where language menu is :) - In preferences change language to Simplified Chinese (I haven't tried others) - Close Blender (with autosave preferences) - Open Blender - In preferences change language to English # Open file browser (save file) System folders are in chinese until next Blender restart. If system folder is in Recent folders, it has chinese name forever.

Richard Antalik commented

2020-09-11 05:07:36 +02:00

Added subscriber: @iss

Richard Antalik commented

2020-09-15 14:25:17 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2020-09-15 14:25:17 +02:00

I guess I will confirm this for myself

Harley Acheson commented

2020-10-21 23:00:45 +02:00

Added subscriber: @Harley

Harley Acheson commented

2020-10-21 23:00:45 +02:00

I'm not sure if I am following the instructions correctly, but...

I start Blender in English. I select File/Open and I see a display like this:

I go straight into Preferences (without restarting Blender) and change my language to Chinese. I then select File / Open and see this:

This seems right. And I get the same result if I close and restart the program at any point. Am I missing a step or not understanding the complaint?

I'm not sure if I am following the instructions correctly, but... I start Blender in English. I select File/Open and I see a display like this: ![SystemEnglish.png](https://archive.blender.org/developer/F9029332/SystemEnglish.png) I go straight into Preferences (without restarting Blender) and change my language to Chinese. I then select File / Open and see this: ![SystemChinese.png](https://archive.blender.org/developer/F9029335/SystemChinese.png) This seems right. And I get the same result if I close and restart the program at any point. Am I missing a step or not understanding the complaint?

Harley Acheson commented

2020-10-21 23:36:29 +02:00

Okay, I have seen it screw up, but in fairly narrow circumstance...

Working: Within a single blender session, so not restarting at any time, I can switch between English and Chinese and back again any number of times, and each time will see the correct System List.

Working: I am in Chinese and then change language to English, THEN file/open I will see the System list correctly. Then close blender and restart and I still see the correct System List names

Working: I am in English and then change language to Chinese, but then immediately close blender. When I open it again the System List is properly in Chinese.

Broken: I am in Chinese and then change language to English, but then immediately close blender. When I open it again the System List is Chinese until I restart.

Okay, I have seen it screw up, but in fairly narrow circumstance... Working: Within a single blender session, so not restarting at any time, I can switch between English and Chinese and back again any number of times, and each time will see the correct System List. Working: I am in Chinese and then change language to English, THEN file/open I will see the System list correctly. Then close blender and restart and I still see the correct System List names Working: I am in English and then change language to Chinese, but then immediately close blender. When I open it again the System List is properly in Chinese. **Broken**: I am in Chinese and then change language to English, but then immediately close blender. When I open it again the System List is Chinese until I restart.

Harley Acheson commented

2020-10-22 02:27:21 +02:00

And while debugging I have been unable to see the issue - it works correctly every time.

And while **debugging** I have been unable to see the issue - it works correctly every time.

Richard Antalik commented

2020-10-22 14:40:06 +02:00

I checked this in debug build, and I was able to reproduce.

Ray molenkamp commented

2020-10-22 15:51:08 +02:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2020-10-22 15:51:08 +02:00

You should not be calling IFACE_("Pictures") in fsmenu_read_system this will cause the msgid to be translated, and when you switch languages it will use the translated text as msgid, come up empty and stick with the previous translation.

      fsmenu_add_windows_folder(fsmenu,
                                FS_CATEGORY_SYSTEM_BOOKMARKS,
                                &FOLDERID_Pictures,
                                "Pictures",
                                ICON_FILE_IMAGE,
                                FS_INSERT_LAST);

makes it work for me.

You should not be calling `IFACE_("Pictures")` in `fsmenu_read_system` this will cause the msgid to be translated, and when you switch languages it will use the translated text as msgid, come up empty and stick with the previous translation. ``` fsmenu_add_windows_folder(fsmenu, FS_CATEGORY_SYSTEM_BOOKMARKS, &FOLDERID_Pictures, "Pictures", ICON_FILE_IMAGE, FS_INSERT_LAST); ``` makes it work for me.

Harley Acheson self-assigned this 2020-10-22 17:54:20 +02:00

Harley Acheson commented

2020-10-22 17:54:20 +02:00

I can fix it. @LazyDodo figured it out. My own mistake with that area.

blender-admin commented

2020-10-24 04:07:14 +02:00

This issue was referenced by f32ab724eb

This issue was referenced by f32ab724eb091d125aef2c8c9bc1394bd1ef05d5

Hans Goudey commented

2020-11-05 22:27:19 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2020-11-05 22:27:19 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

File browser system folders doesn't change with interface language. #80679

Open file browser (save file)