Crash after "Reassigning Inputs" to newly created Effect Clip #80717

New Issue

Thomas Mann · 2020-09-12T01:06:07+02:00

Thomas Mann commented

2020-09-12 01:06:07 +02:00

System Information
Operating system: Win10
Graphics card: GTX2060

Blender Version
Broken: 2.90, 0330d1af29, master, 2020-08-31

Short description of error
Crash after creating color strip in Sequence editor and pressing R

Exact steps for others to reproduce the error

Start Blender
Open Video Sequencer
Add -> Color
Effect Strip -> Reassign Inputs

Crash

This is probably a double of https://developer.blender.org/T8263

**System Information** Operating system: Win10 Graphics card: GTX2060 **Blender Version** Broken: 2.90, 0330d1af29c0, master, 2020-08-31 **Short description of error** Crash after creating color strip in Sequence editor and pressing R **Exact steps for others to reproduce the error** 1. Start Blender 2. Open Video Sequencer 3. Add -> Color 4. Effect Strip -> Reassign Inputs - > Crash This is probably a double of https://developer.blender.org/T8263

Thomas Mann commented

2020-09-12 01:06:07 +02:00

Added subscriber: @pixtur

Robert Guetzkow commented

2020-09-12 01:45:23 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-09-12 01:45:23 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-09-12 01:45:23 +02:00

The issues is in sequencer_reassign_inputs_exec, error_msg is NULL when the following if-case is true:

  if (!seq_effect_find_selected(
          scene, last_seq, last_seq->type, &seq1, &seq2, &seq3, &error_msg) ||
      BKE_sequence_effect_get_num_inputs(last_seq->type) == 0) {
    BKE_report(op->reports, RPT_ERROR, error_msg);
    return OPERATOR_CANCELLED;
  }

Since BKE_report tries to determine the length of the message with strlen() this results in a crash.

BKE_report(ReportList * reports, ReportType type, const unsigned char * _message) Line 123	C
sequencer_reassign_inputs_exec(bContext * C, wmOperator * op) Line 2146	C
wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1313	C
wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2132	C
wm_handlers_do_keymap_with_keymap_handler(bContext * C, wmEvent * event, ListBase * handlers, wmEventHandler_Keymap * handler, wmKeyMap * keymap, const bool do_debug_handler) Line 2442	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2739	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2866	C
wm_event_do_handlers(bContext * C) Line 3364	C
WM_main(bContext * C) Line 485	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 531	C

The issues is in `sequencer_reassign_inputs_exec`, `error_msg` is `NULL` when the following if-case is true: ``` if (!seq_effect_find_selected( scene, last_seq, last_seq->type, &seq1, &seq2, &seq3, &error_msg) || BKE_sequence_effect_get_num_inputs(last_seq->type) == 0) { BKE_report(op->reports, RPT_ERROR, error_msg); return OPERATOR_CANCELLED; } ``` Since `BKE_report` tries to determine the length of the message with `strlen()` this results in a crash. ``` BKE_report(ReportList * reports, ReportType type, const unsigned char * _message) Line 123 C sequencer_reassign_inputs_exec(bContext * C, wmOperator * op) Line 2146 C wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1313 C wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2132 C wm_handlers_do_keymap_with_keymap_handler(bContext * C, wmEvent * event, ListBase * handlers, wmEventHandler_Keymap * handler, wmKeyMap * keymap, const bool do_debug_handler) Line 2442 C wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2739 C wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2866 C wm_event_do_handlers(bContext * C) Line 3364 C WM_main(bContext * C) Line 485 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 531 C ```

Robert Guetzkow commented

2020-09-12 13:21:48 +02:00

The solution is to only run BKE_report if the passed pointer to the error message isn't NULL. Either don't call BKE_report if error_msg is NULL or assign a descriptive message to it before calling BKE_report.

The solution is to only run `BKE_report` if the passed pointer to the error message isn't `NULL`. Either don't call `BKE_report` if `error_msg` is `NULL` or assign a descriptive message to it before calling `BKE_report`.

Sergey Sharybin commented

2020-10-28 12:36:02 +01:00

Added subscribers: @iss, @Sergey

Sergey Sharybin commented

2020-10-28 12:36:02 +01:00

@iss, i remember seeing patches from you which seemed to be related to this issue. Are they committed? Is it a separate issue from what you was fixing in patches?

Robert Guetzkow commented

2020-10-28 13:26:23 +01:00

The solution depends on what particular error message we want for the neglected case of !seq_effect_find_selected(scene, last_seq, last_seq->type, &seq1, &seq2, &seq3, &error_msg) being true.

The solution depends on what particular error message we want for the neglected case of `!seq_effect_find_selected(scene, last_seq, last_seq->type, &seq1, &seq2, &seq3, &error_msg)` being true.

Richard Antalik commented

2020-10-28 13:40:04 +01:00

In #80717#1043522, @Sergey wrote:
@iss, i remember seeing patches from you which seemed to be related to this issue. Are they committed? Is it a separate issue from what you was fixing in patches?

They are comitted, this looks like separate issue. I am checking this

> In #80717#1043522, @Sergey wrote: > @iss, i remember seeing patches from you which seemed to be related to this issue. Are they committed? Is it a separate issue from what you was fixing in patches? They are comitted, this looks like separate issue. I am checking this

Richard Antalik commented

2020-10-28 13:47:03 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2020-10-28 13:47:03 +01:00

Richard Antalik self-assigned this 2020-10-28 13:47:03 +01:00

Richard Antalik commented

2020-10-28 13:47:03 +01:00

Looks like I fixed this "accidentally"

Cant reproduce in 2.90 but not in 2.91/2.92, so closing.

Fixed by 2c14a950a7

Looks like I fixed this "accidentally" Cant reproduce in 2.90 but not in 2.91/2.92, so closing. Fixed by 2c14a950a7

Robert Guetzkow commented

2020-10-28 15:02:32 +01:00

@iss My bad, it is sort of fixed. Might still be a good idea to at least assign an empty string or generic error message to the error_msg. If the conditions for the error reporting change, the string is still uninitialized.

@iss My bad, it is sort of fixed. Might still be a good idea to at least assign an empty string or generic error message to the `error_msg`. If the conditions for the error reporting change, the string is still uninitialized.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash after "Reassigning Inputs" to newly created Effect Clip #80717