Page MenuHome

Deps: potrace 1.16
Closed, ResolvedPublic

Description

potrace was taken on as an additional library (D8662 / T79877) the svn libs and install_deps will need to be updated for all platforms

Event Timeline

Ray molenkamp (LazyDodo) changed the task status from Needs Triage to Confirmed.Tue, Sep 15, 9:21 PM
Ray molenkamp (LazyDodo) created this task.

@Sebastián Barschkis (sebbas), there is no code yet to find the potrace library in platform_apple.cmake, probably can just be straight copied from platform_unix.cmake.

Ah ok, will add. But just to clarify: platform_unix.cmake is not covering macOS then (?)

I assumed that since we have flags like UNIX AND NOT APPLE that macOS would be "included" under "unix" too.

The platform files on the blender side are included like this

if(UNIX AND NOT APPLE)
  include(platform_unix)
elseif(WIN32)
  include(platform_win32)
elseif(APPLE)
  include(platform_apple)
endif()

so they are exclusive to the platform, for mac the unix one is not used, and hence there are no APPLE checks in platform_unix.cmake

Things are different on the deps_builder side (ie buid_files/build_environment) where we go out of our way to make all platforms share as much as possible and only when a certain platform needs an exception you can find platform specific checks scattered where they are most needed.

Brecht Van Lommel (brecht) claimed this task.

I believe this is all done now.