Weight Proximity modifier: crash going to editmode on a target in certain situations #80996

New Issue

Borek Bures · 2020-09-20T16:48:35+02:00

Borek Bures commented

2020-09-20 16:48:35 +02:00

System Information
Operating system: Win7
Graphics card:

Blender Version
Broken: 2.90.0+
Worked: 2.83.6
Caused by deaff945d0

Short description of error
When you create specific setup with two objects and with two modifiers and switch to Edit mode or UV edit mode, Blender crashes.

Exact steps for others to reproduce the error

create target object
create object2 with modifiers Vertex Weight Proximity and Data Transfer
create Vertex group for object2 and assign all vertices
Set modifier Vertex Weight Proximity: set existed Vertex Group, set Target Object, set Proximity Mode - Geometry, set Geometry Face
Set Data Transfer: set Source - target object, use Face Corner Data, switch to UVs
Select target object and switch to Edit mode or UV edit mode - Blender crash

Blender may also crash when Custom Normals or Vertex Colors are used in Data Transfer modifier, but I cannot replicate it successfully.

Modifiers_Crash.blend

**System Information** Operating system: Win7 Graphics card: **Blender Version** Broken: 2.90.0+ Worked: 2.83.6 Caused by deaff945d0 **Short description of error** When you create specific setup with two objects and with two modifiers and switch to Edit mode or UV edit mode, Blender crashes. **Exact steps for others to reproduce the error** 1. create target object 2. create object2 with modifiers Vertex Weight Proximity and Data Transfer 3. create Vertex group for object2 and assign all vertices 4. Set modifier Vertex Weight Proximity: set existed Vertex Group, set Target Object, set Proximity Mode - Geometry, set Geometry Face 5. Set Data Transfer: set Source - target object, use Face Corner Data, switch to UVs 6. Select target object and switch to Edit mode or UV edit mode - Blender crash Blender may also crash when Custom Normals or Vertex Colors are used in Data Transfer modifier, but I cannot replicate it successfully. [Modifiers_Crash.blend](https://archive.blender.org/developer/F8903334/Modifiers_Crash.blend)

Borek Bures commented

2020-09-20 16:48:35 +02:00

Added subscriber: @BorekBures

Philipp Oeser commented

2020-09-21 16:19:01 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-09-21 16:19:01 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser self-assigned this 2020-09-21 16:19:01 +02:00

Philipp Oeser commented

2020-09-21 16:19:01 +02:00

Can confirm, will check.

blender-admin commented

2020-09-21 17:48:57 +02:00

This issue was referenced by d037ac315b

This issue was referenced by d037ac315b4dba2278a77d2db7b3b98861b3d093

Martijn Versteegh commented

2020-09-21 18:05:14 +02:00

Added subscriber: @Baardaap

Philipp Oeser was unassigned by Martijn Versteegh

2020-09-21 18:05:14 +02:00

Campbell Barton was assigned by Martijn Versteegh

2020-09-21 18:05:14 +02:00

Martijn Versteegh commented

2020-09-21 18:05:14 +02:00

I bisected it to git commit deaff945d0

feel free to assign to someone else if Campbell Baron is the wrong person. Sine Campbell Barton committed that patch I though it good idea to ping him.

Is that the proper way to do it over here?

I bisected it to git commit deaff945d0b965d1e588cdecd084080b07db2e1f feel free to assign to someone else if Campbell Baron is the wrong person. Sine Campbell Barton committed that patch I though it good idea to ping him. Is that the proper way to do it over here?

Campbell Barton was unassigned by Philipp Oeser

2020-09-21 18:16:18 +02:00

Philipp Oeser commented

2020-09-21 18:16:18 +02:00

Added subscriber: @ideasman42

Philipp Oeser commented

2020-09-21 18:16:18 +02:00

Since Campbell Barton committed that patch I though it good idea to ping him.

Usually, tasks are left unassigned to developers (unless someone claims explicitly from the corresponding module team).
I sometimes claim tasks as well to indicate that I'll do further investigations/fixing (and then also do the bisect mostly or do a fix if I find one as seen in as seen in D8973).

So generally speaking: if this is claimed already, it doesnt make to much sense to reassign to someone else or do further investigations on it [in this case, we both did the bisect etc.]
(but thx for the effort anyways!)

My fix is a bit of a stab in the dark, so will leave for the Module team again to pick up... (meaning: unassigning @ideasman42 again)

> Since Campbell Barton committed that patch I though it good idea to ping him. Usually, tasks are left unassigned to developers (unless someone claims explicitly from the corresponding module team). I sometimes claim tasks as well to indicate that I'll do further investigations/fixing (and then also do the bisect mostly or do a fix if I find one as seen in as seen in [D8973](https://archive.blender.org/developer/D8973)). So generally speaking: if this is claimed already, it doesnt make to much sense to reassign to someone else or do further investigations on it [in this case, we both did the bisect etc.] (but thx for the effort anyways!) My fix is a bit of a stab in the dark, so will leave for the Module team again to pick up... (meaning: unassigning @ideasman42 again)

Philipp Oeser changed title from ~~Crash when switching to edit mode or UV edit mode of the modifiers target object~~ to Weight Proximity modifier: crash going to editmode on a target in certain situations

2020-09-21 18:17:38 +02:00

Martijn Versteegh commented

2020-09-22 09:37:30 +02:00

[in this case, we both did the bisect etc.]

I understand that is rather inefficient. As mentioned on devtalk I took on his bisection mainly as an exercise to get to know the codebase/buildsystem better, and I was (extremely) unsure if anything would come off it, hence I didn't claim anything. When I started my work it wasn't clamied yet, btw, otherwise I would have picked another crash.

That I actually succeeded in bisecting it was more of a happy collateral :-). Sorry for letting you do the work as well. I maybe should have claimed it and 'unclaimed' afterwards? I'll quit blabbing here and open up a topic over on devtalk to get educated about the proper etiquette over here...

> [in this case, we both did the bisect etc.] I understand that is rather inefficient. As mentioned on devtalk I took on his bisection mainly as an exercise to get to know the codebase/buildsystem better, and I was (extremely) unsure if anything would come off it, hence I didn't claim anything. When I started my work it wasn't clamied yet, btw, otherwise I would have picked another crash. That I actually succeeded in bisecting it was more of a happy collateral :-). Sorry for letting you do the work as well. I maybe should have claimed it and 'unclaimed' afterwards? I'll quit blabbing here and open up a topic over on devtalk to get educated about the proper etiquette over here...

Philipp Oeser commented

2020-09-22 09:49:29 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2020-09-22 09:49:29 +02:00

Philipp Oeser self-assigned this 2020-09-22 09:49:29 +02:00

Philipp Oeser commented

2020-09-22 10:04:00 +02:00

In #80996#1020769, @Baardaap wrote:

[in this case, we both did the bisect etc.]

I understand that is rather inefficient. As mentioned on devtalk I took on his bisection mainly as an exercise to get to know the codebase/buildsystem better, and I was (extremely) unsure if anything would come off it, hence I didn't claim anything. When I started my work it wasn't clamied yet, btw, otherwise I would have picked another crash.

That I actually succeeded in bisecting it was more of a happy collateral :-). Sorry for letting you do the work as well. I maybe should have claimed it and 'unclaimed' afterwards? I'll quit blabbing here and open up a topic over on devtalk to get educated about the proper etiquette over here...

I dont think we have a clear guideline on this.
I would assume it is enough leaving a comment for doing the bisect right away.
Then, if one is doing more investigations aiming at the fix, leave another comment for this as well?
Of course, claiming is also OK if chances are high that you can find a fix.
Just make sure to leave in a clean state ("will investigate" --> cannot find a fix --> leave comment with findings so far but staing "fix cannot be found", or: claim --> investigate --> cannot find a fix --> unassign again).

This has happened to me as well btw., it can easily happen to get sidetracked or something more urgent comes up, then forget to update the task with where you are regarding bisect / investigations...

> In #80996#1020769, @Baardaap wrote: >> [in this case, we both did the bisect etc.] > > I understand that is rather inefficient. As mentioned on devtalk I took on his bisection mainly as an exercise to get to know the codebase/buildsystem better, and I was (extremely) unsure if anything would come off it, hence I didn't claim anything. When I started my work it wasn't clamied yet, btw, otherwise I would have picked another crash. > > That I actually succeeded in bisecting it was more of a happy collateral :-). Sorry for letting you do the work as well. I maybe should have claimed it and 'unclaimed' afterwards? I'll quit blabbing here and open up a topic over on devtalk to get educated about the proper etiquette over here... I dont think we have a clear guideline on this. I would assume it is enough leaving a comment for doing the bisect right away. Then, if one is doing more investigations aiming at the fix, leave another comment for this as well? Of course, claiming is also OK if chances are high that you can find a fix. Just make sure to leave in a clean state ("will investigate" --> cannot find a fix --> leave comment with findings so far but staing "fix cannot be found", or: claim --> investigate --> cannot find a fix --> unassign again). This has happened to me as well btw., it can easily happen to get sidetracked or something more urgent comes up, then forget to update the task with where you are regarding bisect / investigations...

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Weight Proximity modifier: crash going to editmode on a target in certain situations #80996