Page MenuHome
Create Task
Maniphest T81002

Images drawn with the Python gpu module no longer draw on top in the Image Editor
Confirmed, NormalPublic
Actions

Description

System Information
Operating system: Linux-5.4.43-x86_64-Intel-R-_Core-TM-_i7-7500U_CPU_@_2.70GHz-with-slackware-14.2 64 Bits
Graphics card: Mesa Intel(R) HD Graphics 620 (KBL GT2) Intel 4.6 (Core Profile) Mesa 20.1.0

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, hash: rBf470a02afaea, commit date: 2020-09-20 05:59
Worked: version: 2.91.0 Alpha, branch: master, hash: rB66078594d130

Short description of error
When drawing images with the python gpu module, they will no longer draw on top of the region's contents or of other python rendering.
This problem happens in the Image Editor, but not the Sequence Editor.

Before:
(2 square images and a circle are drawn with Python, 'POST_PIXEL' in the Image Editor, which shows a rectangular image)

After:
(the circle, drawn first, shows on top. The Image Editor's image also shows on top)

Exact steps for others to reproduce the error
See the attached .blend file.

python_gl_draw_image.blend771 KBDownload

Revisions and Commits

rB Blender
rB32d4a67017ec Revert "Fix T81002: Images drawn with the Python gpu module no longer draw on…
rB085329f114be Fix T81002: Images drawn with the Python gpu module no longer draw on top in…

Related Objects

Event Timeline

Inês Almeida (brita_) created this task.Sep 20 2020, 7:16 PM
Inês Almeida (brita_) updated the task description. (Show Details)Sep 20 2020, 7:21 PM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).Sep 21 2020, 8:12 AM

Could this be related to the depth tricks that the image editor currently uses? https://wiki.blender.org/wiki/Source/EEVEE_%26_Viewport/Draw_Engines/Image_Engine#Depth_Buffer
What happens when you draw with DEPTH_ALWAYS on? Or with write depth.

Currently when drawing via python it draws directly to the overlay buffer. https://wiki.blender.org/wiki/Source/EEVEE_%26_Viewport/GPU_Module/GPUViewport when transferring to display it might not have the correct data inside the buffers.

I will check later today with renderdoc to see what is happening and what needs to be corrected/documented.
Thanks!

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Sep 21 2020, 3:36 PM
Philipp Oeser (lichtwerk) added a project: EEVEE & Viewport.
Jeroen Bakker (jbakker) added a comment.Sep 22 2020, 11:17 AM

The circle is rendered with gl_depth 0, write depth is on and depth function is less equal.
The textures are rendered with gl_depth 1, write depth is on and depth function is less equal.
The image of the image editor is drawn using gl_depth of 0.75 as part of the new draw pipeline.

Looking at https://developer.blender.org/diffusion/B/browse/master/source/blender/gpu/shaders/gpu_shader_2D_image_vert.glsl the gl_depth is set to 1 for images so they always render in the background.
This was introduced by https://developer.blender.org/rB648924333234a1fd0fee91851bb7ad8bc8639f3a what seems to be out dated as we have done several overhauls in this area. (workbench refactor, overlay engine refactor, color management pipeline).

Jeroen Bakker (jbakker) closed this task as Resolved by committing rB085329f114be: Fix T81002: Images drawn with the Python gpu module no longer draw on top in….Sep 22 2020, 11:21 AM
Jeroen Bakker (jbakker) claimed this task.
Jeroen Bakker (jbakker) added a commit: rB085329f114be: Fix T81002: Images drawn with the Python gpu module no longer draw on top in….
Jeroen Bakker (jbakker) reopened this task as Confirmed.Sep 29 2020, 9:53 AM

Reopening as this fix will be reverted. T81212: Some Viewport Overlay is gone if you move the view in Cycles render view

Jeroen Bakker (jbakker) closed this task as Resolved by committing rB32d4a67017ec: Revert "Fix T81002: Images drawn with the Python gpu module no longer draw on….Sep 29 2020, 9:54 AM
Jeroen Bakker (jbakker) added a commit: rB32d4a67017ec: Revert "Fix T81002: Images drawn with the Python gpu module no longer draw on….
Jeroen Bakker (jbakker) reopened this task as Confirmed.Sep 29 2020, 9:55 AM
Jeroen Bakker (jbakker) mentioned this in T81212: Some Viewport Overlay is gone if you move the view in Cycles render view.
Jeroen Bakker (jbakker) removed Jeroen Bakker (jbakker) as the assignee of this task.Oct 20 2020, 1:55 PM
Pablo (PT) added a subscriber: Pablo (PT).Dec 7 2020, 6:22 AM
Pablo (PT) added a comment.Dec 8 2020, 5:33 AM

A heads up, drawing images in POST_VIEW doesn't work at all in the 2.92 Image Editor, could this be related? I've tried various z positons without success in this case though it works fine in 2.91.