Graph Editor Expand/Collapse Channels collapsing issue #81135

New Issue

Philipp Oeser · 2020-09-24T15:42:36+02:00

Philipp Oeser commented

2020-09-24 15:42:36 +02:00

System Information
Operating system: Linux-5.8.4-200.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.66

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-24 12:05, hash: 7ba30d35d1
Worked: never

Short description of error
Once Collapse/Expand Channels operator has been used with the All option turned OFF, then the All is turned ON again for Collapse, a following Expand Channels operation will not work anymore

Exact steps for others to reproduce the error
#80753.blend

Open above .blend
Collapse Channels, in the Redo Last Operation panel turn OFF All
Expand Channels, in the Redo Last Operation panel turn OFF All
Collapse Channels again, in the Redo Last Operation panel turn ON All again
Expand Channels will not expand to selected channel anymore
T80753_bug.webm

**System Information** Operating system: Linux-5.8.4-200.fc32.x86_64-x86_64-with-fedora-32-Thirty_Two 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.66 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-24 12:05, hash: `7ba30d35d1` Worked: never **Short description of error** Once Collapse/Expand Channels operator has been used with the All option turned OFF, then the All is turned ON again for Collapse, a following Expand Channels operation will not work anymore **Exact steps for others to reproduce the error** [#80753.blend](https://archive.blender.org/developer/F8878187/T80753.blend) - Open above .blend - `Collapse Channels`, in the `Redo Last Operation` panel turn OFF `All` - `Expand Channels`, in the `Redo Last Operation` panel turn OFF `All` - `Collapse Channels` again, in the `Redo Last Operation` panel turn ON `All` again - `Expand Channels` will not expand to selected channel anymore [T80753_bug.webm](https://archive.blender.org/developer/F8878231/T80753_bug.webm)

Philipp Oeser commented

2020-09-24 15:42:36 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-09-24 15:43:09 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Nisim Joseph commented

2020-09-24 16:38:27 +02:00

Added subscriber: @Nisim

Sybren A. Stüvel commented

2020-09-25 16:55:20 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-09-25 16:55:20 +02:00

I did some digging, and it turns out that expand/collapse, visible/invisible, active/inactive, those are all handled in pretty much the same way. When collapsing with "All" disabled, Blender interprets it as "selected elements only", where "elements" are the rows of the dope sheet/graph editor. The problem here is that the row for the object itself is selected whenever the object is selected, and thus the entire object row collapses.

Similarly, when expanding Blender only expands those channels with "data visible", which means "nothing" when everything has been collapsed.

Fixing this will likely require writing specialised code to handle proper collapsing and expanding, instead of trying to reuse the generic code.

I did some digging, and it turns out that expand/collapse, visible/invisible, active/inactive, those are all handled in pretty much the same way. When collapsing with "All" disabled, Blender interprets it as "selected elements only", where "elements" are the rows of the dope sheet/graph editor. The problem here is that the row for the object itself is selected whenever the object is selected, and thus the entire object row collapses. Similarly, when expanding Blender only expands those channels with "data visible", which means "nothing" when everything has been collapsed. Fixing this will likely require writing specialised code to handle proper collapsing and expanding, instead of trying to reuse the generic code.

Sergio Rojas commented

2021-06-10 23:51:51 +02:00

Added subscriber: @sergiorojas

Sergio Rojas commented

2021-06-10 23:51:51 +02:00

This comment was removed by @sergiorojas

*This comment was removed by @sergiorojas*

Sergio Rojas commented

2021-06-11 00:23:55 +02:00

I would like to work on this

Sybren A. Stüvel commented

2021-06-14 12:05:40 +02:00

Excellent! Just claim the task ("Add Action..." box above the comment textarea) and get cracking :)

Sergio Rojas commented

2021-06-16 19:16:41 +02:00

I claim the task

Luciano Muñoz Sessarego commented

2021-06-16 19:19:54 +02:00

Added subscriber: @LucianoMunoz

Luciano Muñoz Sessarego commented

2021-06-16 19:19:54 +02:00

yes! thanks @sergiorojas !

Sergio Rojas was assigned by Sybren A. Stüvel

2021-06-18 15:19:09 +02:00

Sybren A. Stüvel commented

2021-06-18 15:19:09 +02:00

@sergiorojas I'll assign the task to you. Next time you want to claim a task, feel free to use this option and the system will assign it to you automatically:

(it's a bit hidden, I know)

@sergiorojas I'll assign the task to you. Next time you want to claim a task, feel free to use this option and the system will assign it to you automatically: ![image.png](https://archive.blender.org/developer/F10180080/image.png) (it's a bit hidden, I know)

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Graph Editor Expand/Collapse Channels collapsing issue #81135