Texture Painting with Paint mask enabled, (de)selecting faces causes a mess with texture slots. #81167

New Issue

Vlado Tasner · 2020-09-25T15:48:28+02:00

Vlado Tasner commented

2020-09-25 15:48:28 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.48

Blender Version
Broken: version: 2.90.1, branch: master, commit date: 2020-09-23 06:43, hash: 3e85bb34d0
Worked: 2.83.6
Apparently caused by 9582797d4b

Short description of error
Texture Painting with Paint mask enabled, using right click select, I went to deselect one face (shift Rclick), and the whole object "switched" to just one texture (the one assigned to first material).

Exact steps for others to reproduce the error
#81167.blend

Open File (should be in Texture Paint mode, Paint Mask selection is on)
Select a different face
all geometry part should switch to blue appaerance

steps from scratch:

Have an object, let's say there are 3 cubes (same mesh, 1 object)
Create 3 materials, Mat1 Mat2 Mat3, assign each material to their cubes
Create 3 textures, Tex1 Tex2 Tex3. In material editor drag those textures to their respective materials (so you can see the texture in texture painting mode)
Switch to Texture Painting
Enable Paint mask
Pain something on first cube. Only Tex1 should be affected
Press Shift Right Click (using RClick select) to deselect one face, doesn't matter which cube
Notice how Tex1 is showed on every cube
8a) I cannot paint on any other cube except the one where Tex1 is actually supposed to be
Tab into edit mode, Tab out, it's okay now.

I searched to find similar bug posted, didn't find any, I'm sorry if this is a duplicate or if it's known issue (glanced through those).

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.48 **Blender Version** Broken: version: 2.90.1, branch: master, commit date: 2020-09-23 06:43, hash: `3e85bb34d0` Worked: 2.83.6 Apparently caused by 9582797d4b **Short description of error** Texture Painting with Paint mask enabled, using right click select, I went to deselect one face (shift Rclick), and the whole object "switched" to just one texture (the one assigned to first material). **Exact steps for others to reproduce the error** [#81167.blend](https://archive.blender.org/developer/F8931752/T81167.blend) - Open File (should be in Texture Paint mode, Paint Mask selection is on) - Select a different face - all geometry part should switch to blue appaerance steps from scratch: 1) Have an object, let's say there are 3 cubes (same mesh, 1 object) 2) Create 3 materials, Mat1 Mat2 Mat3, assign each material to their cubes 3) Create 3 textures, Tex1 Tex2 Tex3. In material editor drag those textures to their respective materials (so you can see the texture in texture painting mode) 4) Switch to Texture Painting 5) Enable Paint mask 6) Pain something on first cube. Only Tex1 should be affected 7) Press Shift Right Click (using RClick select) to deselect one face, doesn't matter which cube 8) Notice how Tex1 is showed on every cube 8a) I cannot paint on any other cube except the one where Tex1 is actually supposed to be 9) Tab into edit mode, Tab out, it's okay now. I searched to find similar bug posted, didn't find any, I'm sorry if this is a duplicate or if it's known issue (glanced through those).

Vlado Tasner commented

2020-09-25 15:48:28 +02:00

Added subscriber: @Wicked100

Philipp Oeser commented

2020-09-28 14:31:07 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-09-28 14:31:08 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-09-28 14:31:08 +02:00

Can confirm, wil check on this.

Philipp Oeser commented

2020-09-28 15:07:33 +02:00

Added subscriber: @fclem

Philipp Oeser commented

2020-09-28 15:07:33 +02:00

Apparently caused by 8084b7e6e2

CC @fclem

Apparently caused by 8084b7e6e2 CC @fclem

Jeroen Bakker commented

2020-10-06 15:20:47 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2020-10-06 15:20:47 +02:00

I came to a different bisect: 9582797d4b Also checked that the commit before this one still worked.

I came to a different bisect: 9582797d4b Also checked that the commit before this one still worked.

Jeroen Bakker self-assigned this 2020-10-06 16:35:45 +02:00

Jeroen Bakker commented

2020-10-07 14:20:59 +02:00

Cause is that the per material index buffers (cache->surface_per_mat ibuf) is reset and contain all the indexes. They aren't rebuild to contain the indexes per material anymore.
Researching if this has to do with DRW_ibo_request(cache->surface_per_mat- [x], &mbufcache->ibo.tris); in draw_cache_impl_mesh.c.

Issue can be fixed by invalidating the whole draw cache when changing masks, but that makes the existing optimization obsolete. I am looking into reusing the index buffers similar we do for custom data masks changes.

Cause is that the per material index buffers (`cache->surface_per_mat` ibuf) is reset and contain all the indexes. They aren't rebuild to contain the indexes per material anymore. Researching if this has to do with `DRW_ibo_request(cache->surface_per_mat- [x], &mbufcache->ibo.tris);` in `draw_cache_impl_mesh.c`. Issue can be fixed by invalidating the whole draw cache when changing masks, but that makes the existing optimization obsolete. I am looking into reusing the index buffers similar we do for custom data masks changes.

blender-admin commented

2020-10-19 08:08:49 +02:00

This issue was referenced by 1ceb91d1b3

This issue was referenced by 1ceb91d1b3947fda67a70a2eff785a964e625ca2

Jeroen Bakker commented

2020-10-19 08:14:59 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-10-19 08:14:59 +02:00

Thomas Dinges added this to the 2.91 milestone 2023-02-08 16:20:22 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Texture Painting with Paint mask enabled, (de)selecting faces causes a mess with texture slots. #81167