Modifier menu and text switch places #81227

New Issue

Zachary · 2020-09-27T12:56:34+02:00

Zachary commented

2020-09-27 12:56:34 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 950M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.38

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-26 20:04, hash: 8c81b3fb8b

Short description of error
Moving modifiers makes the properties text and modifier menu switch places.

Exact steps for others to reproduce the error
1: Add multiple modifiers
2: Drag to move modifiers

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 950M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.38 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-09-26 20:04, hash: `8c81b3fb8b` **Short description of error** Moving modifiers makes the properties text and modifier menu switch places. ![text_switch.jpg](https://archive.blender.org/developer/F8928135/text_switch.jpg) **Exact steps for others to reproduce the error** 1: Add multiple modifiers 2: Drag to move modifiers

Zachary commented

2020-09-27 12:56:34 +02:00

Added subscriber: @AFWS

blender-admin commented

2020-09-27 12:56:34 +02:00

#81401 was marked as duplicate of this issue

Aaron Carlisle commented

2020-09-27 13:51:48 +02:00

Closed as duplicate of #81161

Aaron Carlisle closed this issue

2020-09-27 13:51:48 +02:00

Aaron Carlisle commented

2020-09-27 13:52:31 +02:00

Added subscriber: @Blendify

Aaron Carlisle commented

2020-09-27 13:52:31 +02:00

This should be fixed, please try an updated daily build.

Zachary commented

2020-09-27 14:02:04 +02:00

In #81227#1024290, @Blendify wrote:
This should be fixed, please try an updated daily build.

Seems to be the same or at least related ,but did you look at the date and hash? I just did a make update and build the latest 2 hours ago. If that fixed worked, it shouldn't be doing this still.

> In #81227#1024290, @Blendify wrote: > This should be fixed, please try an updated daily build. Seems to be the same or at least related ,but did you look at the date and hash? I just did a `make update` and build the latest 2 hours ago. If that fixed worked, it shouldn't be doing this still.

Aaron Carlisle commented

2020-09-27 14:25:00 +02:00

Changed status from 'Duplicate' to: 'Needs Developer To Reproduce'

Aaron Carlisle reopened this issue

2020-09-27 14:25:00 +02:00

Hans Goudey was assigned by Aaron Carlisle

2020-09-27 14:25:00 +02:00

Hans Goudey commented

2020-09-27 17:24:44 +02:00

Based on the description this is not a duplicate of the other report, it would be a different problem.

However, I can't reproduce this. Does it happen if you load the default settings and startup file? (File->Defaults->Load Factory Settings)

Based on the description this is not a duplicate of the other report, it would be a different problem. However, I can't reproduce this. Does it happen if you load the default settings and startup file? (File->Defaults->Load Factory Settings)

Zachary commented

2020-09-27 18:46:21 +02:00

In #81227#1024356, @HooglyBoogly wrote:
Based on the description this is not a duplicate of the other report, it would be a different problem.

However, I can't reproduce this. Does it happen if you load the default settings and startup file? (File->Defaults->Load Factory Settings)

It could be the same problem. Does it if you move any panels and not just modifiers. Yeah, I tried Load Factory Settings and it made no difference. Even does it if I open the startup.blend from here C:\blender-git\blender\release\datafiles\startup.blend

2020-09-27 11-34-40.mp4

> In #81227#1024356, @HooglyBoogly wrote: > Based on the description this is not a duplicate of the other report, it would be a different problem. > > However, I can't reproduce this. Does it happen if you load the default settings and startup file? (File->Defaults->Load Factory Settings) It could be the same problem. Does it if you move any panels and not just modifiers. Yeah, I tried Load Factory Settings and it made no difference. Even does it if I open the startup.blend from here `C:\blender-git\blender\release\datafiles\startup.blend` [2020-09-27 11-34-40.mp4](https://archive.blender.org/developer/F8928897/2020-09-27_11-34-40.mp4)

Richard Antalik commented

2020-10-01 20:46:23 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Hans Goudey commented

2020-10-01 21:23:13 +02:00

Added subscriber: @iss

Hans Goudey commented

2020-10-01 21:23:13 +02:00

@iss I guess you were able to reproduce this? I wonder if it's a windows thing.

Hans Goudey commented

2020-10-02 23:22:20 +02:00

Added subscribers: @aicedor, @HooglyBoogly

Robert Guetzkow commented

2020-10-02 23:29:29 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-10-02 23:50:14 +02:00

@HooglyBoogly I can reproduce this behavior as well.

Hans Goudey commented

2020-10-02 23:54:38 +02:00

What OS?

Robert Guetzkow commented

2020-10-02 23:59:31 +02:00

Windows as well.

Hans Goudey commented

2020-10-03 00:58:16 +02:00

In that case I'd guess that this comes down to platform differences in the implementation of qsort. When headerless panels are compared to normal panels they are placed above, but it's sort of arbitrary what happens when two headerless panels are compared. I'm guessing I'll have to tag one of them as "first," although I wonder how it worked in 2.79... Requires a bit more testing. But I have no windows dev setup to reproduce this.

In that case I'd guess that this comes down to platform differences in the implementation of `qsort`. When headerless panels are compared to normal panels they are placed above, but it's sort of arbitrary what happens when two headerless panels are compared. I'm guessing I'll have to tag one of them as "first," although I wonder how it worked in 2.79... Requires a bit more testing. But I have no windows dev setup to reproduce this.

Robert Guetzkow commented

2020-10-03 01:15:06 +02:00

@HooglyBoogly That would be a possible explanation of the issue, qsort is not a stable sorting algorithm. From a quick glance at the code this probably means a change to find_highest_panel or compare_panel?

@HooglyBoogly That would be a possible explanation of the issue, qsort is not a stable sorting algorithm. From a quick glance at the code this probably means a change to `find_highest_panel` or `compare_panel`?

Hans Goudey commented

2020-10-03 01:39:02 +02:00

@rjg Yes, probably just switching to a stable sorting algorithm would work. But maybe it's better to fix it more elegantly.

find_highest_panel is needed to properly sort panels based on where you drag them.

There's a variety of small changes to the logic of find_highest_panel I would try here. For example, this disables sorting by offset unless one panel in the comparison is being dragged:

diff --git a/source/blender/editors/interface/interface_panel.c b/source/blender/editors/interface/interface_panel.c
index ec4e2c03e85..25094b52372 100644
--- a/source/blender/editors/interface/interface_panel.c
+++ b/source/blender/editors/interface/interface_panel.c
@@ -1703,11 +1703,13 @@ static int find_highest_panel(const void *a, const void *b)
     return 1;
   }
 
-  if (panel_a->ofsy + panel_a->sizey < panel_b->ofsy + panel_b->sizey) {
-    return 1;
-  }
-  if (panel_a->ofsy + panel_a->sizey > panel_b->ofsy + panel_b->sizey) {
-    return -1;
+  if (panel_a->flag & PNL_SELECT || panel_b->flag & PNL_SELECT) {
+    if (panel_a->ofsy + panel_a->sizey < panel_b->ofsy + panel_b->sizey) {
+      return 1;
+    }
+    if (panel_a->ofsy + panel_a->sizey > panel_b->ofsy + panel_b->sizey) {
+      return -1;
+    }
   }
   if (panel_a->sortorder > panel_b->sortorder) {
     return 1;

@rjg Yes, probably just switching to a stable sorting algorithm would work. But maybe it's better to fix it more elegantly. `find_highest_panel` is needed to properly sort panels based on where you drag them. There's a variety of small changes to the logic of `find_highest_panel` I would try here. For example, this disables sorting by offset unless one panel in the comparison is being dragged: ``` diff --git a/source/blender/editors/interface/interface_panel.c b/source/blender/editors/interface/interface_panel.c index ec4e2c03e85..25094b52372 100644 --- a/source/blender/editors/interface/interface_panel.c +++ b/source/blender/editors/interface/interface_panel.c @@ -1703,11 +1703,13 @@ static int find_highest_panel(const void *a, const void *b) return 1; } - if (panel_a->ofsy + panel_a->sizey < panel_b->ofsy + panel_b->sizey) { - return 1; - } - if (panel_a->ofsy + panel_a->sizey > panel_b->ofsy + panel_b->sizey) { - return -1; + if (panel_a->flag & PNL_SELECT || panel_b->flag & PNL_SELECT) { + if (panel_a->ofsy + panel_a->sizey < panel_b->ofsy + panel_b->sizey) { + return 1; + } + if (panel_a->ofsy + panel_a->sizey > panel_b->ofsy + panel_b->sizey) { + return -1; + } } if (panel_a->sortorder > panel_b->sortorder) { return 1; ```

Robert Guetzkow commented

2020-10-03 10:25:37 +02:00

@HooglyBoogly That change doesn't solve the issue for me. If I have some time later on I'll take another look and see if I can find a solution.