Shift+click works incorrectly after deleting all brushes #81636

New Issue

Ovionis · 2020-10-11T21:50:43+02:00

Ovionis commented

2020-10-11 21:50:43 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 770/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 452.06

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-10 16:05, hash: 1b04eb6c44

Short description of error
When you use Shift+Click/Draw in sculpt mode, to use the smooth brush, it does not work if you don't have a brush preset stored for the smooth brush.

Exact steps for others to reproduce the error
Delete all the brushes from your file.
Select a brush besides the smooth brush (to generate a default brush)
Hold Shift and start sculpting.

You will see the active brush working first but without a cursor. When you release the mouse, the brush's radius will be reset to 1 px.
If you use Scene as the Radius Unit instead of View, the brush's size won't change but smooth still won't work.

If you click the Smooth Brush, then another brush, it will start working because it generated a brush in the file.

2020-10-11 14-30-37.mp4

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 770/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 452.06 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-10 16:05, hash: `1b04eb6c44` **Short description of error** When you use Shift+Click/Draw in sculpt mode, to use the smooth brush, it does not work if you don't have a brush preset stored for the smooth brush. **Exact steps for others to reproduce the error** Delete all the brushes from your file. Select a brush besides the smooth brush *(to generate a default brush)* Hold Shift and start sculpting. You will see the active brush working first but without a cursor. When you release the mouse, the brush's radius will be reset to 1 px. If you use Scene as the Radius Unit instead of View, the brush's size won't change but smooth still won't work. If you click the Smooth Brush, then another brush, it will start working because it generated a brush in the file. [2020-10-11 14-30-37.mp4](https://archive.blender.org/developer/F8980367/2020-10-11_14-30-37.mp4)

Ovionis commented

2020-10-11 21:50:43 +02:00

Added subscriber: @Phigon

Richard Antalik changed title from ~~[Sculpt] null Smooth Brush defaults to 1px / 0~~ to Shift+click works incorrectly after deleting all brushes

2020-10-14 20:11:31 +02:00

Richard Antalik commented

2020-10-14 20:11:31 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Ovionis commented

2021-01-02 23:52:45 +01:00

I found a use for having multiple brushes.
I then found that this happens "not" when you don't have any smooth brush presets but when there is no brush named "Smooth".

I was trying to have "alternative" smooth brushes, and since re-pressing the smooth brush hotkey (Shift+S) would cycle through the smooths, I figure it would use whichever brush I had selected last.
When that didn't work, I found it was switching to the brush by name, and that

i can only use one smooth brush or have to continuously switch their names to toggle between them
It doesn't actually have to be a smooth brush.

2 behaves as a different bug, where the active brush gets stuck as the not-smooth brush,

however it "could" be redone as a custom option, to allow user-defined quick-strokes (like a mask brush hotkey, or carve-hotkey)

I found a use for having multiple brushes. I then found that this happens "not" when you don't have any smooth brush presets but when there is no brush named "Smooth". I was trying to have "alternative" smooth brushes, and since re-pressing the smooth brush hotkey (Shift+S) would cycle through the smooths, I figure it would use whichever brush I had selected last. When that didn't work, I found it was switching to the brush by name, and that - i can only use one smooth brush or have to continuously switch their names to toggle between them - It doesn't actually have to be a smooth brush. # 2 behaves as a different bug, where the active brush gets stuck as the not-smooth brush, however it "could" be redone as a custom option, to allow user-defined quick-strokes (like a mask brush hotkey, or carve-hotkey)

Pablo Dobarro commented

2021-01-22 01:27:35 +01:00

Added subscriber: @PabloDobarro

Pablo Dobarro commented

2021-01-22 01:27:35 +01:00

Changed status from 'Confirmed' to: 'Archived'

Pablo Dobarro closed this issue

2021-01-22 01:27:35 +01:00

Pablo Dobarro commented

2021-01-22 01:27:35 +01:00

I consider this a TODO related to the brush management project. What the current code does (which is very bad) is searching for a brush datablock called "Smooth" (this is hardcoded), store the name of the previous brush datablock and swap the current brush datablock in the stroke cache. When the stroke ends, it does the opposite process. Ideally, you should be able to use any brush preset as a temporary smooth brush and set this manually from the UI.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Shift+click works incorrectly after deleting all brushes #81636

2 behaves as a different bug, where the active brush gets stuck as the not-smooth brush,