heap use after free at clicking on splash screen's open button #81817
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#81817
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
macOS 10.14
Intel HD 6000
Broken:
bb872b25f2
Steps to redo:
Asan report:
Added subscriber: @ankitm
use after free at clicking on splash screen's open buttonto heap use after free at clicking on splash screen's open buttonAdded subscriber: @HooglyBoogly
Changed status from 'Needs Triage' to: 'Confirmed'
Not sure if this sort of thing is triaged as a bug? But I can reproduce this. Master from July 15th also had the same problem, so I wouldn't guess that this is a recently introduced issue.
Added subscriber: @rjg
This comment was removed by @rjg
Added subscriber: @JulianEisel
Why would this be a thread-race? I don't see a related part here that is multi-threaded. To me this seems like a regular use-after-free that should be easy to fix.
@JulianEisel Seems like I need some glasses. I misread the ASAN report and was under the impression that the first and second trace were from different threads, which is obviously not true. Please disregard my previous comment.
This comment was removed by @rjg
Not sure if this is a 2.91 regression, but let's treat it as one until we know better.
Added subscriber: @dfelinto
@HooglyBoogly what is your OS? can you reproduce it in 2.90 release?
I'm using Fedora 32, kernel 5.8. Although I doubt this bug depends on the OS. And yes, I can reproduce this on
blender-v2.90-release
.Added subscriber: @JacquesLucke
How about just doing this:
UI_popup_block_close(C, win, arg_block);
if (!(label && label[0])) {
UI_but_func_set(but, wm_block_close, block, NULL);
wm_block_splash_add_label(
block, BKE_blender_version_string(), splash_width, splash_height - 13.0 * U.dpi_fac);
I don't really know what
UI_block_func_set
is, but in my basic test it does not seem necessary.For context, the
wm_block_splash_refreshmenu
function was added in486796ce31
.I checked this and it seems fine. I can't see errors without this explicit refreshing, back then popup refreshing wasn't as "sophisticated" as it is today.
To a degree this is just hiding the issue but I think that's okay still. A proper fix should be easy but could also backfire.
This issue was referenced by
64aa6c68d5
Changed status from 'Confirmed' to: 'Resolved'