Page MenuHome
Create Task
Maniphest T81984

Crash in sculpt undo with mask extract after dyntopo toggle
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Ubuntu 18.04
Graphics card: Nvidia 960

Blender Version
Broken: 2.83.8 LTS

Short description of error
Extract mask crashes blender during undo after toggling dyntopo

Exact steps for others to reproduce the error

  • open attached blend file
  • turn dyntopo on, then off
  • press F3 and search for "mask extract"
  • press "ok" on mask extract options
  • press ctrl-z to undo

File:

MaskExtractCrash.blend1 MBDownload

Crash log:

Thursday_22-October-2020_17.45_02.crash.txt1 KBDownload

Revisions and Commits

rB Blender
rB81462f86bc5f Fix T81984: Crash in sculpt undo with mask extract after dyntopo toggle

Related Objects

Event Timeline

Dan McGrath (dmcgrath) created this task.Oct 23 2020, 12:14 AM
Joseph Eagar (joeedh) assigned this task to Pablo Dobarro (pablodp606).Oct 23 2020, 2:57 AM
Joseph Eagar (joeedh) edited subscribers, added: Joseph Eagar (joeedh); removed: Dan McGrath (dmcgrath).

Adding OPTYPE_UNDO to ot->flag in MESH_OT_paint_mask_extract in editmesh_mask_extract.c seems to fix this bug. Should all the operators in that file have that flag set?

Joseph Eagar (joeedh) added a comment.Oct 23 2020, 2:57 AM

Okay, why does it say I removed a subscriber. Let's try that again.

Joseph Eagar (joeedh) added a subscriber: Dan McGrath (dmcgrath).Oct 23 2020, 2:57 AM
Philipp Oeser (lichtwerk) edited projects, added BF Blender, Sculpt, Paint & Texture; removed Add-ons (Community).Oct 23 2020, 9:25 AM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Oct 23 2020, 9:27 AM
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Oct 23 2020, 9:40 AM

@Joseph Eagar (joeedh) : sounds right to flag OPTYPE_UNDO
It is similar in python, see T77557: Python Operators that add/remove ID data without an undo step crash Blender

This is related to new UNDO btw. it does not crash with Preferences > Experimental > Undo Legacy

Philipp Oeser (lichtwerk) added a subscriber: Bastien Montagne (mont29).Oct 23 2020, 2:00 PM

CC @Bastien Montagne (mont29)

Bastien Montagne (mont29) closed this task as Resolved by committing rB81462f86bc5f: Fix T81984: Crash in sculpt undo with mask extract after dyntopo toggle.Oct 26 2020, 9:17 AM
Bastien Montagne (mont29) added a commit: rB81462f86bc5f: Fix T81984: Crash in sculpt undo with mask extract after dyntopo toggle.