New boolean causes 2.78 demo file to fail to load #82019
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#82019
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: AMD FirePro W2100 ATI Technologies Inc. 4.5.13493 Core Profile Context FireGL 22.19.693.256
Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-22 21:22, hash:
baa24f1c91
Worked: version: 2.90.1, branch: master, commit date: 2020-09-23 06:43, hash:
3e85bb34d0
Short description of error
I brought this up before and I thought it was fixed before the new boolean was checked in, but it looks like the blenderman.blend demo file is broken again?
I want to say that older files were supposed to be versioned to keep the boolean modifiers in Fast mode, not Exact, but the stack trace in the crash file seems to indicate otherwise.
With 2.90:
<10 seconds to open with reasonable memory usage
With 2.91:
After ~500 seconds of loading, it will crash with some form of memory error (32gb machine here)
Exact steps for others to reproduce the error
Blenderman.crash.txt
Added subscriber: @deadpin
Added subscriber: @HooglyBoogly
Changed status from 'Needs Triage' to: 'Confirmed'
I can reproduce this. On a debug build with ASAN I get a report that makes me question whether this is actually cause by boolean like you say:
Either way though, this results in a crash when trying to open a file, and it's a recent regression so this should have high a priority. From the log it looks like it may be related to grease pencil, I'm not sure though.
Added subscriber: @antoniov
I can reproduce with the last compilation, but my log is totally different in windows and it's not grease pencil related:
Added subscriber: @JacquesLucke
Also checked and the file has a grease pencil object, but without Layers, Frames or Strokes, so it's almost impossible to be the cause of the crash. Anyway, IIRC
greasepencil_blend_read_data()
was something changed by @JacquesLucke few weeks ago in the read/write refactor.@antoniov I'm confused. Why are the palettes linked in
BKE_gpencil_blend_read_data
instead ofgreasepencil_blend_read_lib
? I have no experience with palettes, but it looks like they are ID datablocks and the colors list should only be linked inpalette_blend_read_data
(which it is).Without ASAN, I get the same error as @antoniov. So this is probably something for @howardt to look into.
After loading the file, it takes a while until the assert is hit for me.
Added subscriber: @howardt
@JacquesLucke The palette were linked in old versions to the GPD datablock, but this was deprecated in 2.77 (IIRC)... anyway, this file is not using any Palette, so I don't think is the reason. Also, the palettes were only used for very few times, so I don't think we are going to have a lot of old files using Palettes because at that time GPencil was not very much used.
The problem is that my versioning code was looking for the non-presence of a 'solver' field in the boolean modifier as indication that the file was old. But a long time ago there used to be a solver field, that we removed. So if I just skip that check, the file loads OK. I'll submit a change for this right away. It is so simple a fix that I don't think it needs a review.
This issue was referenced by
ca83649b7d
This issue was referenced by
d65e5e8bc5
Changed status from 'Confirmed' to: 'Resolved'