Page MenuHome
Create Task
Maniphest T82351

Tile stealing glitches with adaptive sampling
Confirmed, HighPublicBUG
Actions

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.09

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-02 14:36, hash: rB7872bcafa0ff
Caused by rB517ff40b124b: Cycles: Implement tile stealing to improve CPU+GPU rendering performance

Short description of error
Adaptive sampling introduces random errors on the stolen tiles

Exact steps for others to reproduce the error

Open the following file

StealThis.blend115 KBDownload

Enable GPU+CPU mode in the preferences

Hit F12
If it's not very visible the first time, try again

Revisions and Commits

rB Blender
AcceptedD9445 Fix T82351: Tile stealing glitches with adaptive sampling

Related Objects

Event Timeline

Daniel Salazar (zanqdo) renamed this task from Tile stealing doesn't play nice with adaptive sampling to Tile stealing glitches with adaptive sampling.Tue, Nov 3, 6:39 AM
Daniel Salazar (zanqdo) created this task.
Daniel Salazar (zanqdo) added a project: Cycles.
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Tue, Nov 3, 9:37 AM
Philipp Oeser (lichtwerk) triaged this task as High priority.
Philipp Oeser (lichtwerk) added a project: Render & Cycles.
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".
Philipp Oeser (lichtwerk) added subscribers: Lukas Stockner (lukasstockner97), Philipp Oeser (lichtwerk).

@Lukas Stockner (lukasstockner97): mind checking?

Philipp Oeser (lichtwerk) updated the task description. (Show Details)Tue, Nov 3, 9:38 AM
Lukas Stockner (lukasstockner97) claimed this task.Tue, Nov 3, 2:07 PM
Juan Gea (juang3d) added a subscriber: Juan Gea (juang3d).EditedTue, Nov 3, 2:38 PM

Adaptive sampling never worked completely fine with CPU + GPU, Stefan can give the explanation better than me
It’s a matter of when the CPU and the GPU computation can be stopped

Philipp Oeser (lichtwerk) added a revision: D9445: Fix T82351: Tile stealing glitches with adaptive sampling.Wed, Nov 4, 10:36 AM
Philipp Oeser (lichtwerk) mentioned this in T82394: Tile Stealing + AS + Transparent BG produces alpha artifacts.
Philipp Oeser (lichtwerk) merged a task: T82394: Tile Stealing + AS + Transparent BG produces alpha artifacts.
Philipp Oeser (lichtwerk) added a subscriber: J-P Busse (Corefrecs).
Adam Burke (burkules) awarded a token.Wed, Nov 4, 10:29 PM
Adam Burke (burkules) added a subscriber: Adam Burke (burkules).
Roger B (rboxman) mentioned this in T82474: Blender 2.92 Alpha – Hybrid Rendering using Adaptive Sampling will cause broken CPU tiles when GPU is finished .Sat, Nov 7, 2:42 AM
Alaska (Alaska) merged a task: T82474: Blender 2.92 Alpha – Hybrid Rendering using Adaptive Sampling will cause broken CPU tiles when GPU is finished .Sat, Nov 7, 3:51 AM
Alaska (Alaska) added subscribers: Michael Klein (Renderbricks), Alaska (Alaska), Roger B (rboxman).
Robert Guetzkow (rjg) merged a task: T82497: Cycles - the new tile stealing has problems in conjunction with adaptive sampling.Sat, Nov 7, 11:37 PM
Robert Guetzkow (rjg) added subscribers: Axel Bechstein (Unreleased75), Oleg Vdovenko (olhapi).
slwk1d (Slowwkidd) mentioned this in T82498: Strange rendering results.Sun, Nov 8, 12:17 AM
Daniel Salazar (zanqdo) merged a task: T82498: Strange rendering results.Sun, Nov 8, 7:10 AM
Daniel Salazar (zanqdo) added subscribers: slwk1d (Slowwkidd), champions (schampions).
Jorge García-Brazales (strangerman) awarded a token.Tue, Nov 10, 7:01 PM
Jorge García-Brazales (strangerman) added a subscriber: Jorge García-Brazales (strangerman).
Alaska (Alaska) merged a task: T82632: CUDA+CPU in cycles with Adaptative Sampling causes wrong tiles..Thu, Nov 12, 1:11 AM
Alaska (Alaska) added a subscriber: Leiser Fernández Gallo (leiserfg).
Evan Wilson (EAW) merged a task: T82717: CUDA Devices GPU+CPU and Adaptive Sampling enabled leads to visual differences in tiles.Sat, Nov 14, 10:54 AM
Evan Wilson (EAW) added a subscriber: Elmar (the_avg_guy).
Robert Guetzkow (rjg) merged a task: T82717: CUDA Devices GPU+CPU and Adaptive Sampling enabled leads to visual differences in tiles.Sat, Nov 14, 10:55 AM
Dalai Felinto (dfelinto) edited projects, added BF Blender (2.92); removed BF Blender.Wed, Nov 18, 12:46 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

Tagging as 2.92 so it doesn't get on the way of the 2.91 release coordination.

Fran Marz (franMarz) awarded a token.Wed, Nov 18, 1:15 PM
Daniel Salazar (zanqdo) added a comment.Wed, Nov 18, 6:39 PM

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

Michael Klein (Renderbricks) added a comment.EditedWed, Nov 18, 7:12 PM
In T82351#1057234, @Daniel Salazar (zanqdo) wrote:

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

Daniel Salazar (zanqdo) added a comment.Wed, Nov 18, 7:19 PM
In T82351#1057255, @Michael Klein (Renderbricks) wrote:
In T82351#1057234, @Daniel Salazar (zanqdo) wrote:

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

No more options needed. Just a temporary check that disables something that is BROKEN. Until it gets fixed.

Steffen Dünner (SteffenD) added a subscriber: Steffen Dünner (SteffenD).Wed, Nov 18, 7:22 PM

I applied Lukas' patch and it works perfectly. It just needs to get reviewed and accepted.

Michael Klein (Renderbricks) added a comment.EditedWed, Nov 18, 7:27 PM
In T82351#1057257, @Daniel Salazar (zanqdo) wrote:
In T82351#1057255, @Michael Klein (Renderbricks) wrote:
In T82351#1057234, @Daniel Salazar (zanqdo) wrote:

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

No more options needed. Just a temporary check that disables something that is BROKEN. Until it gets fixed.

From a production pov it should be an option to decide to render on a farm with or without CPU. I would recommend to add a feature in the Render Setting and not Preferences only to disable the hybrid mode. Because setting to GPU will take the Preferences settings only locally. And this is not really useful eg. when you do distributed rendering on machines with GPU turned on but some use CPU and some not.

Summary: A button below the CPU/GPU menu will override the local System settings and set it to GPU only. Turned off will enable the local System settings as usual.

Robert Guetzkow (rjg) added a subscriber: Robert Guetzkow (rjg).EditedWed, Nov 18, 7:48 PM

@Michael Klein (Renderbricks) Please don't post feature requests on the bug tracker. Besides, you can already configure this via Python and/or the render farm should provide a proper setup with their preferences.

Michael Klein (Renderbricks) added a comment.EditedWed, Nov 18, 7:50 PM
In T82351#1057284, @Robert Guetzkow (rjg) wrote:

@Michael Klein (Renderbricks) Please don't post feature requests on the bug tracker. Besides, you can already configure this via Python.

Understood! I just responded to Daniel. Where can I post a feature request being reviewed by the dev team?

Robert Guetzkow (rjg) added a comment.Wed, Nov 18, 7:53 PM

This page lists where you can leave feedback or make feature proposals.

Daniel Salazar (zanqdo) added a comment.Wed, Nov 18, 7:53 PM
In T82351#1057276, @Michael Klein (Renderbricks) wrote:
In T82351#1057257, @Daniel Salazar (zanqdo) wrote:
In T82351#1057255, @Michael Klein (Renderbricks) wrote:
In T82351#1057234, @Daniel Salazar (zanqdo) wrote:

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

No more options needed. Just a temporary check that disables something that is BROKEN. Until it gets fixed.

From a production pov it should be an option to decide to render on a farm with or without CPU. I would recommend to add a feature in the Render Setting and not Preferences only to disable the hybrid mode. Because setting to GPU will take the Preferences settings only locally. And this is not really useful eg. when you do distributed rendering on machines with GPU turned on but some use CPU and some not.

Summary: A button below the CPU/GPU menu will override the local System settings and set it to GPU only. Turned off will enable the local System settings as usual.

This is wrong. The renderfarm itself should configure the rendering units based on each virtual machine´s capabilities. This does not belong to the blend file since the same blend file could end up being rendered in different hardware.

Michael Klein (Renderbricks) added a comment.Wed, Nov 18, 8:09 PM
In T82351#1057293, @Daniel Salazar (zanqdo) wrote:
In T82351#1057276, @Michael Klein (Renderbricks) wrote:
In T82351#1057257, @Daniel Salazar (zanqdo) wrote:
In T82351#1057255, @Michael Klein (Renderbricks) wrote:
In T82351#1057234, @Daniel Salazar (zanqdo) wrote:

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

No more options needed. Just a temporary check that disables something that is BROKEN. Until it gets fixed.

From a production pov it should be an option to decide to render on a farm with or without CPU. I would recommend to add a feature in the Render Setting and not Preferences only to disable the hybrid mode. Because setting to GPU will take the Preferences settings only locally. And this is not really useful eg. when you do distributed rendering on machines with GPU turned on but some use CPU and some not.

Summary: A button below the CPU/GPU menu will override the local System settings and set it to GPU only. Turned off will enable the local System settings as usual.

This is wrong. The renderfarm itself should configure the rendering units based on each virtual machine´s capabilities. This does not belong to the blend file since the same blend file could end up being rendered in different hardware.

I see. Yes, makes sense. My bad. Thanks for the time.

Michael Hermann (245) added a subscriber: Michael Hermann (245).Wed, Nov 25, 12:51 AM
Robert Guetzkow (rjg) mentioned this in T83149: Cycles: Adaptive Sampling + OptiX Denoise causes tile-sized artefacts.Sat, Nov 28, 3:06 PM
Robert Guetzkow (rjg) merged a task: T83149: Cycles: Adaptive Sampling + OptiX Denoise causes tile-sized artefacts.Sat, Nov 28, 3:43 PM
Robert Guetzkow (rjg) added a subscriber: Chris Clyne (lateasusual).