Page MenuHome

Tile stealing glitches with adaptive sampling
Confirmed, HighPublicBUG

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.09

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-02 14:36, hash: rB7872bcafa0ff
Caused by rB517ff40b124b: Cycles: Implement tile stealing to improve CPU+GPU rendering performance

Short description of error
Adaptive sampling introduces random errors on the stolen tiles

Exact steps for others to reproduce the error

Open the following file


Enable GPU+CPU mode in the preferences

Hit F12
If it's not very visible the first time, try again

Event Timeline

Daniel Salazar (zanqdo) renamed this task from Tile stealing doesn't play nice with adaptive sampling to Tile stealing glitches with adaptive sampling.Tue, Nov 3, 6:39 AM
Daniel Salazar (zanqdo) created this task.
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Tue, Nov 3, 9:37 AM
Philipp Oeser (lichtwerk) triaged this task as High priority.
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".

Adaptive sampling never worked completely fine with CPU + GPU, Stefan can give the explanation better than me
It’s a matter of when the CPU and the GPU computation can be stopped

Tagging as 2.92 so it doesn't get on the way of the 2.91 release coordination.

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

No more options needed. Just a temporary check that disables something that is BROKEN. Until it gets fixed.

I applied Lukas' patch and it works perfectly. It just needs to get reviewed and accepted.

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

No more options needed. Just a temporary check that disables something that is BROKEN. Until it gets fixed.

From a production pov it should be an option to decide to render on a farm with or without CPU. I would recommend to add a feature in the Render Setting and not Preferences only to disable the hybrid mode. Because setting to GPU will take the Preferences settings only locally. And this is not really useful eg. when you do distributed rendering on machines with GPU turned on but some use CPU and some not.

Summary: A button below the CPU/GPU menu will override the local System settings and set it to GPU only. Turned off will enable the local System settings as usual.

@Michael Klein (Renderbricks) Please don't post feature requests on the bug tracker. Besides, you can already configure this via Python and/or the render farm should provide a proper setup with their preferences.

@Michael Klein (Renderbricks) Please don't post feature requests on the bug tracker. Besides, you can already configure this via Python.

Understood! I just responded to Daniel. Where can I post a feature request being reviewed by the dev team?

This page lists where you can leave feedback or make feature proposals.

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

No more options needed. Just a temporary check that disables something that is BROKEN. Until it gets fixed.

From a production pov it should be an option to decide to render on a farm with or without CPU. I would recommend to add a feature in the Render Setting and not Preferences only to disable the hybrid mode. Because setting to GPU will take the Preferences settings only locally. And this is not really useful eg. when you do distributed rendering on machines with GPU turned on but some use CPU and some not.

Summary: A button below the CPU/GPU menu will override the local System settings and set it to GPU only. Turned off will enable the local System settings as usual.

This is wrong. The renderfarm itself should configure the rendering units based on each virtual machine´s capabilities. This does not belong to the blend file since the same blend file could end up being rendered in different hardware.

@Dalai Felinto (dfelinto) Seeing the amount of reports this has generated, maybe we should disable the feature automatically in case of collision. For example, if hybrid is enabled, disable adaptive for now.

This might be a useful option because when rendering on a farm with Afanasy (in our case) we have to load Blender and disable the CPU to save the settings. It would anyway a good idea to add a simple button in the Render Settings to disable/enable CPU for hybrid rendering saved in the scene.

No more options needed. Just a temporary check that disables something that is BROKEN. Until it gets fixed.

From a production pov it should be an option to decide to render on a farm with or without CPU. I would recommend to add a feature in the Render Setting and not Preferences only to disable the hybrid mode. Because setting to GPU will take the Preferences settings only locally. And this is not really useful eg. when you do distributed rendering on machines with GPU turned on but some use CPU and some not.

Summary: A button below the CPU/GPU menu will override the local System settings and set it to GPU only. Turned off will enable the local System settings as usual.

This is wrong. The renderfarm itself should configure the rendering units based on each virtual machine´s capabilities. This does not belong to the blend file since the same blend file could end up being rendered in different hardware.

I see. Yes, makes sense. My bad. Thanks for the time.