Library Overrides: Shader drivers stop working after save and reload #82404

New Issue

Demeter Dzadik · 2020-11-04T15:22:55+01:00

Demeter Dzadik commented

2020-11-04 15:22:55 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-02 08:33, hash: d49c71e96e

Short description of error
Shader drivers seem to stop working after a file with a library override is saved and reloaded. This can be fixed by running Resync Library Override Hierarchy on the collection every time the file is opened.

Exact steps for others to reproduce the error

File: effect_plane_override_bug.blend
Link the CH-plane collection to a fresh file and Make Library Override.
Enter Material Preview in the 3D viewport.
On the armature's only bone, find the "transparency" custom property and change it. It works.
Save your file and reload it. The transparency custom property no longer works.
Resync the collection and it works again.

CC @mont29

TEMPORARY WORKAROUND:

For now it is possible to work around this by relaying the information through an intermediate custom property on the material:

Add a custom property to the material datablock and move the currently existing driver to it.
Use a driver that copies the value of the newly added material custom property into the node tree.

For some more details and an example file see comments below.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-02 08:33, hash: `d49c71e96e` **Short description of error** Shader drivers seem to stop working after a file with a library override is saved and reloaded. This can be fixed by running Resync Library Override Hierarchy on the collection every time the file is opened. **Exact steps for others to reproduce the error** - File: [effect_plane_override_bug.blend](https://archive.blender.org/developer/F9195742/effect_plane_override_bug.blend) - Link the CH-plane collection to a fresh file and Make Library Override. - Enter Material Preview in the 3D viewport. - On the armature's only bone, find the "transparency" custom property and change it. It works. - Save your file and reload it. The transparency custom property no longer works. - Resync the collection and it works again. CC @mont29 **TEMPORARY WORKAROUND:** For now it is possible to work around this by relaying the information through an intermediate custom property on the material: * Add a custom property to the *material* datablock and move the currently existing driver to it. * Use a driver that copies the value of the newly added material custom property into the node tree. For some more details and an example file see comments below.

Demeter Dzadik commented

2020-11-04 15:22:55 +01:00

Added subscribers: @mont29, @Mets

blender-admin commented

2020-11-04 15:22:55 +01:00

#87387 was marked as duplicate of this issue

blender-admin commented

2020-11-04 15:22:55 +01:00

#88265 was marked as duplicate of this issue

blender-admin commented

2020-11-04 15:22:55 +01:00

#85761 was marked as duplicate of this issue

Bastien Montagne commented

2020-11-04 16:27:03 +01:00

This is expected currently, as node trees are not overridable yet.

Germano Cavalcante commented

2020-11-05 13:09:42 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Maciej Morgaś commented

2020-12-27 21:13:58 +01:00

Added subscriber: @MaciejMorgas

Alexander Gavrilov commented

2021-01-17 20:31:55 +01:00

Added subscriber: @angavrilov

Alexander Gavrilov commented

2021-01-17 20:31:55 +01:00

For now it is possible to work around this by relaying the information through a custom property on the material:

Add a custom property to the material and move the currently existing driver to it.
Use a driver that reads the material's custom property from the node tree.

This works because overrides on datablock custom properties are supported, and references from a datablock to itself are effectively always implicitly and automatically overridden due to the way things work internally, even if actual overrides aren't implemented for that property (this is why the intermediate property must be on the material itself).

Note: If you open the shader editor on the overridden material it would seem like the values don't update, but the actual dependency graph is correct and Eevee & Cycles react to the value changes.

For now it is possible to work around this by relaying the information through a custom property on the material: * Add a custom property to the material and move the currently existing driver to it. * Use a driver that reads the material's custom property from the node tree. This works because overrides on datablock custom properties are supported, and references from a datablock to itself are effectively always implicitly and automatically overridden due to the way things work internally, even if actual overrides aren't implemented for that property (this is why the intermediate property must be on the material itself). Note: If you open the shader editor on the overridden material it would seem like the values don't update, but the actual dependency graph is correct and Eevee & Cycles react to the value changes.

Demeter Dzadik commented

2021-02-18 11:12:51 +01:00

Added subscriber: @adrien.gomez

Hadrien Brissaud commented

2021-04-07 20:05:21 +02:00

Added subscriber: @hadrien

Hadrien Brissaud commented

2021-04-07 20:05:21 +02:00

I thought I had a bug, so I checked this task and if I understand correctly overrides in material node trees is still incomplete, am I correct ? It works in some files, and not in others (same character though, which is unexpected). Should I report it ? (I am using 2.92)

Bastien Montagne commented

2021-04-07 20:28:48 +02:00

NodeTrees are definitely not supported currently by overrides, and are indeed a known TODO, no bug here.

Daniel Salazar commented

2021-04-12 23:43:02 +02:00

Added subscriber: @zanqdo

Alexander Gavrilov commented

2021-05-03 13:43:50 +02:00

This is a pair of test files (created in 2.92) that demonstrate the workaround. Opening matoverride1-user.blend should display a green cube if everything works; yellow means it's broken.

matoverride1.zip

It seems the workaround was broken recently in 2.93 and master, so I added a temporary fix for that. It would have to be reverted once this is supported properly.

Some tips noticed while making this simplified test file:

Enabling Library Overridable on the intermediate custom property is not required.
The material should be linked to Object rather than Data.

This is a pair of test files (created in 2.92) that demonstrate the workaround. Opening matoverride1-user.blend should display a green cube if everything works; yellow means it's broken. [matoverride1.zip](https://archive.blender.org/developer/F10051222/matoverride1.zip) It seems the workaround was broken recently in 2.93 and master, so I added a temporary fix for that. It would have to be reverted once this is supported properly. Some tips noticed while making this simplified test file: * Enabling Library Overridable on the intermediate custom property is not required. * The material should be linked to Object rather than Data.

Richard Antalik commented

2021-05-14 17:15:46 +02:00

Added subscribers: @LapisSea, @iss, @foxydysphoria

Adrien Gomez commented

2021-05-19 11:53:41 +02:00

@angavrilov It seems it still is broken in 2.93 beta wether the material is linked to object or data

Philipp Oeser commented

2021-08-16 12:12:12 +02:00

Added subscribers: @jitone1, @lichtwerk

johan tri handoyo commented

2021-08-26 09:10:37 +02:00

Added subscriber: @JohanTriHandoyo

Arthur Blaquart commented

2021-11-23 17:09:02 +01:00

Added subscriber: @Human_Robot

Arthur Blaquart commented

2021-11-23 17:09:02 +01:00

So to be clear there is currently no workaround to make linked material overrides work in 2.93?

Daniel Salazar commented

2021-11-23 20:58:08 +01:00

In #82404#1258810, @Human_Robot wrote:
So to be clear there is currently no workaround to make linked material overrides work in 2.93?

Make it link to OBJ and make the material local. Put all the fancy stuff inside a group node.

> In #82404#1258810, @Human_Robot wrote: > So to be clear there is currently no workaround to make linked material overrides work in 2.93? Make it link to OBJ and make the material local. Put all the fancy stuff inside a group node.

Arthur Blaquart commented

2021-11-23 21:13:20 +01:00

In #82404#1258894, @zanqdo wrote:

In #82404#1258810, @Human_Robot wrote:
So to be clear there is currently no workaround to make linked material overrides work in 2.93?

Make it link to OBJ and make the material local. Put all the fancy stuff inside a group node.

It's not very practical for my case unfortunately as it's for assets that will be ultimately exported to gltf (and the exporter doesn't export group nodes). I could workaround it with scripting but haven't come up with an efficient way to achieve that just yet. I think working linked material overrides would be extremely useful for both even for small scale projects.

> In #82404#1258894, @zanqdo wrote: >> In #82404#1258810, @Human_Robot wrote: >> So to be clear there is currently no workaround to make linked material overrides work in 2.93? > > Make it link to OBJ and make the material local. Put all the fancy stuff inside a group node. It's not very practical for my case unfortunately as it's for assets that will be ultimately exported to gltf (and the exporter doesn't export group nodes). I could workaround it with scripting but haven't come up with an efficient way to achieve that just yet. I think working linked material overrides would be extremely useful for both even for small scale projects.

Daniel Salazar commented

2021-11-23 21:15:59 +01:00

Yeah it's really a pain. LOs have a long way to go still.

Rombout Versluijs commented

2022-01-19 04:15:46 +01:00

Added subscriber: @RomboutVersluijs

Rombout Versluijs commented

2022-01-19 04:15:46 +01:00

@angavrilov That test is also a bit weird. When i open it in bl.293 and start moving the empty color change works. As soon as i select the cube and then the empty again it stops working.

I noticed it used 2 drivers, 1 custom prop on material named proxy to drive the other. I moved the driver directly to the location of the empty.

However i noticed the driver kept shower part of that proxy when i open driver editor window. When i use edit driver, the small popup does not show proxy.

Something else i noticed is that the driver jumps back to Scripted Expression and doesnt hold its Average Value with is set in the lib.blend file

It also returns an error on opening the file. But as long as the empty is selected it still works. After that i noticed the driver is reset to scripted value and it wont hold anything else, it will keep reverting to scripted value.

WARN (bke.anim_sys): C:\b\buildbot-worker-windows\windows_291\blender.git\source\blender\blenkernel\intern\anim_sys.c:2926 BKE_animsys_eval_driver: invalid driver - (null)[0]```


EDIT2
The only way i can keep it work is using "is library overridable" check in that custom prop. I dont see such an option for drivers though when added in a different manner
{F12810989}

EDIT3
Though that "is library overridable" does work. On reopening the file, i do need to use resync ovreride each and everytime i open the user.blend file

{F12811004}

@angavrilov That test is also a bit weird. When i open it in bl.293 and start moving the empty color change works. As soon as i select the cube and then the empty again it stops working. I noticed it used 2 drivers, 1 custom prop on material named proxy to drive the other. I moved the driver directly to the location of the empty. However i noticed the driver kept shower part of that proxy when i open driver editor window. When i use edit driver, the small popup does not show proxy. ![moved driver directly to location.png](https://archive.blender.org/developer/F12810972/moved_driver_directly_to_location.png) Something else i noticed is that the driver jumps back to Scripted Expression and doesnt hold its Average Value with is set in the lib.blend file It also returns an error on opening the file. But as long as the empty is selected it still works. After that i noticed the driver is reset to scripted value and it wont hold anything else, it will keep reverting to scripted value. ``` WARN (bke.anim_sys): C:\b\buildbot-worker-windows\windows_291\blender.git\source\blender\blenkernel\intern\anim_sys.c:2926 BKE_animsys_eval_driver: invalid driver - (null)[0]``` EDIT2 The only way i can keep it work is using "is library overridable" check in that custom prop. I dont see such an option for drivers though when added in a different manner {F12810989} EDIT3 Though that "is library overridable" does work. On reopening the file, i do need to use resync ovreride each and everytime i open the user.blend file {F12811004}

Alexander Gavrilov commented

2022-01-29 12:47:45 +01:00

Well, just commenting that I checked and drivers in materials now seem to work without any workarounds in 3.1 master. I didn't check node groups, those may well still be broken.