Moving collections between scenes crashes Blender #82439

New Issue

kursad k · 2020-11-05T19:04:15+01:00

kursad k commented

2020-11-05 19:04:15 +01:00

System Information
Operating system: Windows 10 x64
Graphics card: Gtx2070

Blender Version
Broken: blender-2.91.0-29780b8101eb-windows64
Behavior changed in 89491d67d9

Short description of error
Moving collections between internal scenes hard crashes Blender.

Exact steps for others to reproduce the error
Open the attached scene and drag and drop the the Drag_Me_2_Scene.001 from Scene to Scene.001 or take a look at the attached image

collection_drag_05112020_1200_11.blend

**System Information** Operating system: Windows 10 x64 Graphics card: Gtx2070 **Blender Version** Broken: blender-2.91.0-29780b8101eb-windows64 Behavior changed in 89491d67d9 **Short description of error** Moving collections between internal scenes hard crashes Blender. **Exact steps for others to reproduce the error** Open the attached scene and drag and drop the the `Drag_Me_2_Scene.001` from Scene to Scene.001 or take a look at the attached image ![nxplayer.bin_vohdHzIRRc.jpg](https://archive.blender.org/developer/F9211148/nxplayer.bin_vohdHzIRRc.jpg) [collection_drag_05112020_1200_11.blend](https://archive.blender.org/developer/F9211153/collection_drag_05112020_1200_11.blend)

kursad k commented

2020-11-05 19:04:15 +01:00

Added subscriber: @kursadk

Robert Guetzkow commented

2020-11-05 22:21:20 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-11-05 22:21:20 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-11-05 22:21:20 +01:00

I can confirm this crash in current master and 2.91. layer_collection is NULL in layer_collection_flags_restore .

_BLI_assert_abort() Lines 51	C
layer_collection_flags_restore(ListBase * flags, const Collection * collection) Lines 1818	C
BKE_collection_move(Main * bmain, Collection * to_parent, Collection * from_parent, Collection * relative, bool relative_after, Collection * collection) Lines 1878	C
collection_drop_invoke(bContext * C, wmOperator * UNUSED_op, const wmEvent * event) Lines 1289	C
wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Lines 1288	C
wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const short context, const bool poll_only, wmEvent * event) Lines 1534	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Lines 2781	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Lines 2864	C
wm_event_do_handlers(bContext * C) Lines 3360	C
WM_main(bContext * C) Lines 481	C
main(int argc, const unsigned char * * UNUSED_argv_c) Lines 526	C

I can confirm this crash in current master and 2.91. `layer_collection` is `NULL` in `layer_collection_flags_restore` . ```lines _BLI_assert_abort() Lines 51 C layer_collection_flags_restore(ListBase * flags, const Collection * collection) Lines 1818 C BKE_collection_move(Main * bmain, Collection * to_parent, Collection * from_parent, Collection * relative, bool relative_after, Collection * collection) Lines 1878 C collection_drop_invoke(bContext * C, wmOperator * UNUSED_op, const wmEvent * event) Lines 1289 C wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Lines 1288 C wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const short context, const bool poll_only, wmEvent * event) Lines 1534 C wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Lines 2781 C wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Lines 2864 C wm_event_do_handlers(bContext * C) Lines 3360 C WM_main(bContext * C) Lines 481 C main(int argc, const unsigned char * * UNUSED_argv_c) Lines 526 C ```

Robert Guetzkow commented

2020-11-05 22:32:17 +01:00

This seems to work fine in Blender 2.83 in a cursory test.

Hans Goudey self-assigned this 2020-11-06 02:15:33 +01:00

Hans Goudey commented

2020-11-06 05:19:59 +01:00

After looking at the code here it seems that it's fundamentally broken in cases where multiple scenes are involved. It basically assumes that the collection is being moved to the same view layer it's already in, because it searches in the original view layer for the moved collection.

A simple solution would be to just remove the assert and skip the collection when no view layer is found, but I feel like there should be a proper way around this. One way to solve this would be to pass the "to view layer" which would then be searched for the new LayerCollection for the collection.

However, I don't think this would deal with the case where the same collection is in two scenes at the same time. It almost looks like we would need a separate list of LayerCollectionFlags for each scene, and that putting them all in the same list isn't correct.

After looking at the code here it seems that it's fundamentally broken in cases where multiple scenes are involved. It basically assumes that the collection is being moved to the same view layer it's already in, because it searches in the original view layer for the moved collection. A simple solution would be to just remove the assert and skip the collection when no view layer is found, but I feel like there should be a proper way around this. One way to solve this would be to pass the "to view layer" which would then be searched for the new `LayerCollection` for the collection. However, I don't think this would deal with the case where the same collection is in two scenes at the same time. It almost looks like we would need a separate list of `LayerCollectionFlag`s for each scene, and that putting them all in the same list isn't correct.

kursad k commented

2020-11-06 07:38:28 +01:00

As a side note linking via Ctrl dragging does not crash Blender.