Sample Texture Node for trees and flowers scattering #82584

New Issue

Dalai Felinto · 2020-11-10T14:56:25+01:00

Dalai Felinto commented

2020-11-10 14:56:25 +01:00

This node is for the trees and flowers scattering workflow.

{F9603276 size=full}

![image.png](https://archive.blender.org/developer/F9252767/image.png) This node is for the trees and flowers scattering workflow. --- {[F9603276](https://archive.blender.org/developer/F9603276/image.png) size=full}

Dalai Felinto commented

2020-11-10 14:56:25 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Dalai Felinto commented

2020-11-10 14:56:25 +01:00

Added subscriber: @dfelinto

Kenzie commented

2020-11-10 21:45:54 +01:00

Added subscriber: @KenzieMac130

Kenzie commented

2020-11-10 21:45:54 +01:00

It seems like this is just pretty close to a duplicate of the image texture node based on the mockup. Why can't there just be a set float or set vector attribute node that accepts blender's existing texture nodes as well as any surface varying math node setups?

Dalai Felinto commented

2020-11-11 09:57:35 +01:00

There is no image texture node at the moment. The design considered using an "image-base" pipeline, but for now it is focusing on an attribute pipeline. That means the texture doesn't exist on its own, but only in relation to a UV Map and the attribute the user intends to map it to.

Kenzie commented

2020-11-11 14:14:01 +01:00

In #82584#1052289, @dfelinto wrote:
There is no image texture node at the moment. The design considered using an "image-base" pipeline, but for now it is focusing on an attribute pipeline. That means the texture doesn't exist on its own, but only in relation to a UV Map and the attribute the user intends to map it to.

I'm trying to figure out the issue here... I might be not understanding. It seems like the system doesn't handle surface varying attributes at the geometry node level. So user defined math that runs some sort of calculation per vertex/face would need to be piped through a "texture" (which based ony understanding of the design is basically going to be reusing the goodies of the material graph).

So if I wanted to say make an attribute or mask of a surfaces pointiness multiplied by a dot product vector and a grunge texture map I would need to create a texture graph that does such a thing and feed it into this node correct?

Or is this going to be a transition node for while blender does not have the new texture node system to hook into the old one?

(Edit: I will try to contact people on blender chat. Just figured the task page was the best place to leave open questions about design.)

> In #82584#1052289, @dfelinto wrote: > There is no image texture node at the moment. The design considered using an "image-base" pipeline, but for now it is focusing on an attribute pipeline. That means the texture doesn't exist on its own, but only in relation to a UV Map and the attribute the user intends to map it to. I'm trying to figure out the issue here... I might be not understanding. It seems like the system doesn't handle surface varying attributes at the geometry node level. So user defined math that runs some sort of calculation per vertex/face would need to be piped through a "texture" (which based ony understanding of the design is basically going to be reusing the goodies of the material graph). So if I wanted to say make an attribute or mask of a surfaces pointiness multiplied by a dot product vector and a grunge texture map I would need to create a texture graph that does such a thing and feed it into this node correct? Or is this going to be a transition node for while blender does not have the new texture node system to hook into the old one? (Edit: I will try to contact people on blender chat. Just figured the task page was the best place to leave open questions about design.)

Dalai Felinto changed title from ~~Sample Texture Node~~ to Sample Texture Node for trees and flowers scattering

2020-11-13 15:19:10 +01:00

Jacques Lucke self-assigned this 2020-11-30 15:09:52 +01:00

Jacques Lucke removed their assignment 2020-12-01 14:52:29 +01:00

Jacques Lucke commented

2020-12-01 14:52:29 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke self-assigned this 2020-12-03 18:50:58 +01:00

Valera Barashkov commented

2020-12-15 16:38:01 +01:00

Added subscriber: @valera-8

Valera Barashkov commented

2020-12-15 16:38:01 +01:00

Would be really cool if we could tie this to the texture generated in the Material editor, can be done like so:

Shader Tree Name: "Some Material"
Unique Node Name: "Node Name"

It would use the coordinates in the material editor. Imagine previewing the texture live on the object and then right away using it to distribute objects or displace mesh, etc..

Would be really cool if we could tie this to the texture generated in the Material editor, can be done like so: - Shader Tree Name: "Some Material" - Unique Node Name: "Node Name" It would use the coordinates in the material editor. Imagine previewing the texture live on the object and then right away using it to distribute objects or displace mesh, etc..

Jacques Lucke commented

2020-12-18 13:58:17 +01:00

The WIP code for this is in temp-geometry-nodes-sample-texture. It can only sample textures based on the position currently. I'll not be able to finish uv support in this sprint. It also requires changes to the distribute node, because the uv maps (and possibly all other attributes as well) have to be added to the output points.

The WIP code for this is in `temp-geometry-nodes-sample-texture`. It can only sample textures based on the position currently. I'll not be able to finish uv support in this sprint. It also requires changes to the distribute node, because the uv maps (and possibly all other attributes as well) have to be added to the output points.

Victor-Louis De Gusseme commented

2021-01-03 01:46:39 +01:00

Added subscriber: @victorlouis

blender-admin commented

2021-01-21 16:47:03 +01:00

This issue was referenced by 425e706921

This issue was referenced by 425e706921a8f986921b8b9c429874fed98e9a10

Dalai Felinto commented

2021-01-28 23:30:29 +01:00

Added subscriber: @SimonThommes

Dalai Felinto commented

2021-01-28 23:30:29 +01:00

@JacquesLucke for the records, remember to add a screenshot of the final node here. It helps to speed up testing.

If I remember correctly this is fully working. But I will let @SimonThommes to have a final say on it.

By the way, feedback by Andy: To add "Generated" mapping, besides UV, for when objects don't have UV mapping.

@JacquesLucke for the records, remember to add a screenshot of the final node here. It helps to speed up testing. If I remember correctly this is fully working. But I will let @SimonThommes to have a final say on it. By the way, feedback by Andy: To add "Generated" mapping, besides UV, for when objects don't have UV mapping.

Dalai Felinto commented

2021-01-28 23:34:34 +01:00

Also, there is the pending issue of the texture panel. IIRC the design is to follow the "Displace Modifier" design. If this won't be part of this task could you please create a new task in the product backlog so we don't forget that?

Simon Thommes commented

2021-01-29 12:39:46 +01:00

@dfelinto @JacquesLucke Yes, this task is done, I would say. But we should create new tasks for:

adding the texture as a modifier texture when pressing New + having a button to jump to said texture in the properties panel like in a displacement modifier
supporting UV maps as attributes without a point distribute node (will prosumably not be done before we handle different domains (?))
supporting generated coordinates as an attribute

@dfelinto @JacquesLucke Yes, this task is done, I would say. But we should create new tasks for: - adding the texture as a modifier texture when pressing `New` + having a button to jump to said texture in the properties panel like in a displacement modifier - supporting UV maps as attributes without a point distribute node (will prosumably not be done before we handle different domains (?)) - supporting generated coordinates as an attribute

Ludvik Koutny commented

2021-01-29 12:45:13 +01:00

Added subscriber: @Rawalanche

Ludvik Koutny commented

2021-01-29 12:45:13 +01:00

What is the point of having such node when it can read only the old, Blender Internal style textures, and not Shader Editor texture node networks? This is the exact same issue as the one that severely limits the usefulness of the displace modifier. If your use case is truly scattering, as you say, then it makes really no sense for users to not have any ability to utilize the texture nodes.

My point is that the order seems to be all wrong. Ability to utilize node based texture networks in both Geometry Nodes and modifiers, such as Displacement Modifier would have much, much bigger impact on the overall capability of procedural modeling in Blender (think creating procedural rocks, cliffs, landscapes), than the geometry nodes with the support of old, gimped Blender Internal texture system will ever have.

What is the point of having such node when it can read only the old, Blender Internal style textures, and not Shader Editor texture node networks? This is the exact same issue as the one that severely limits the usefulness of the displace modifier. If your use case is truly scattering, as you say, then it makes really no sense for users to not have any ability to utilize the texture nodes. My point is that the order seems to be all wrong. Ability to utilize node based texture networks in both Geometry Nodes and modifiers, such as Displacement Modifier would have much, much bigger impact on the overall capability of procedural modeling in Blender (think creating procedural rocks, cliffs, landscapes), than the geometry nodes with the support of old, gimped Blender Internal texture system will ever have.

Jacques Lucke commented

2021-01-29 12:45:55 +01:00

@SimonThommes sounds good to me. I assume we could have a node that creates a new attribute that contains the generated coordinates? It's also possible to do this in the Sample Texture node of course. This question can also be answered in the new task.

Philipp Oeser commented

2021-01-29 12:51:05 +01:00

Added subscribers: @HooglyBoogly, @lichtwerk

Philipp Oeser commented

2021-01-29 12:51:05 +01:00

In #82584#1103373, @SimonThommes wrote:
@dfelinto @JacquesLucke Yes, this task is done, I would say. But we should create new tasks for:

adding the texture as a modifier texture when pressing New + having a button to jump to said texture in the properties panel like in a displacement modifier

Just noting that in D9813: Sculpt / Paint: show "Show Texture in texture tab" button @HooglyBoogly raised the point to have some utility function that will determine the "right" Properties Editor to display this in:

In D9813 #246700, @HooglyBoogly wrote:
I'm not sure this should just use the first property editor it finds. If is more than one open the choice feels random.

I realize this opens more questions, expanding the scope of this patch, but I think it's important, the area it changes can be the one on the opposite side of the screen when there are two open.

My suggestion is adding a BKE_screen_find_closest_area_xy function that could find the closest property editor. Maybe some others have issues with this sort of "smart" behavior, but it's better than nothing in my opinion.

I could have a look again and do it for this node as well?

> In #82584#1103373, @SimonThommes wrote: > @dfelinto @JacquesLucke Yes, this task is done, I would say. But we should create new tasks for: > - adding the texture as a modifier texture when pressing `New` + having a button to jump to said texture in the properties panel like in a displacement modifier Just noting that in [D9813: Sculpt / Paint: show "Show Texture in texture tab" button](https://archive.blender.org/developer/D9813) @HooglyBoogly raised the point to have some utility function that will determine the "right" Properties Editor to display this in: > In [D9813](https://archive.blender.org/developer/D9813)#246700, @HooglyBoogly wrote: > I'm not sure this should just use the first property editor it finds. If is more than one open the choice feels random. > > I realize this opens more questions, expanding the scope of this patch, but I think it's important, the area it changes can be the one on the opposite side of the screen when there are two open. > > My suggestion is adding a `BKE_screen_find_closest_area_xy` function that could find the closest property editor. Maybe some others have issues with this sort of "smart" behavior, but it's better than nothing in my opinion. I could have a look again and do it for this node as well?

Jacques Lucke commented

2021-02-01 12:43:01 +01:00

@lichtwerk If you want to look into that, please go ahead. I don't consider this to be part of this task anymore.

Jacques Lucke commented

2021-02-01 12:45:01 +01:00

@SimonThommes Can you create the tasks you mentioned?

Dalai Felinto commented

2021-02-01 14:16:02 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Dalai Felinto closed this issue

2021-02-01 14:16:02 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Sample Texture Node for trees and flowers scattering #82584