Cycles: Blender crash on switching between tabs #82607

New Issue

AiSatan · 2020-11-11T08:35:43+01:00

AiSatan commented

2020-11-11 08:35:43 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-10 22:11, hash: c4d8f6a4a8 & 2.91 Beta
Worked: 2.90.1

Short description of error
Blender crash on switching tabs, if you switch it on "load mesh/upload scene bhv"

Exact steps for others to reproduce the error

Load blend file, or just copy default cube multiple times
Switch to render view (it happends in both Cuda and optiX)
As soon as it's start render, go to second tab (I only test with UV tab)
If you change tab on "upload bhv or update meshes" it will crash.

heavier meshes you have - easier to reproduce

Example(2.92 first two, and 2.90.1 last one):

2.92vs2.90.1.mp4

Blend File:

test.blend

Logs:

blender_debug_output.txt

blender_system_info.txt

test.crash.txt

blender.exe         :0x00007FF69A8DC3A0  ccl::AttributeSet::find
blender.exe         :0x00007FF69A49D5F0  ccl::OptiXDevice::build_optix_bvh
blender.exe         :0x00007FF69D9CEAB0  ccl::BVHOptiX::copy_to_device
blender.exe         :0x00007FF69A8E4210  ccl::GeometryManager::device_update_bvh
blender.exe         :0x00007FF69A8DF230  ccl::GeometryManager::device_update
blender.exe         :0x00007FF69A8A2680  ccl::Scene::device_update
blender.exe         :0x00007FF69A8A43E0  ccl::Scene::update
blender.exe         :0x00007FF69A8BC600  ccl::Session::update_scene
blender.exe         :0x00007FF69A8BECB0  ccl::Session::run_gpu
blender.exe         :0x00007FF69A8BC850  ccl::Session::run
blender.exe         :0x00007FF69C9E5040  ccl::thread::run
blender.exe         :0x00007FF69A0D4FE0  std::thread::_Invoke<std::tuple<void * __ptr64 (__cdecl*)(void * __ptr64),ccl::thread * __ptr64>,0,
ucrtbase.dll        :0x00007FF99FB21430  configthreadlocale
KERNEL32.DLL        :0x00007FF9A0277020  BaseThreadInitThunk
ntdll.dll           :0x00007FF9A209CEA0  RtlUserThreadStart

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30 **Blender Version** Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-10 22:11, hash: `c4d8f6a4a8` & 2.91 Beta Worked: 2.90.1 **Short description of error** Blender crash on switching tabs, if you switch it on "load mesh/upload scene bhv" **Exact steps for others to reproduce the error** 1. Load blend file, or just copy default cube multiple times 2. Switch to render view (it happends in both Cuda and optiX) 3. As soon as it's start render, go to second tab (I only test with UV tab) 4. If you change tab on "upload bhv or update meshes" it will crash. heavier meshes you have - easier to reproduce Example(2.92 first two, and 2.90.1 last one): [2.92vs2.90.1.mp4](https://archive.blender.org/developer/F9258125/2.92vs2.90.1.mp4) Blend File: [test.blend](https://archive.blender.org/developer/F9258122/test.blend) Logs: [blender_debug_output.txt](https://archive.blender.org/developer/F9258113/blender_debug_output.txt) [blender_system_info.txt](https://archive.blender.org/developer/F9258114/blender_system_info.txt) [test.crash.txt](https://archive.blender.org/developer/F9258115/test.crash.txt) ```lines blender.exe :0x00007FF69A8DC3A0 ccl::AttributeSet::find blender.exe :0x00007FF69A49D5F0 ccl::OptiXDevice::build_optix_bvh blender.exe :0x00007FF69D9CEAB0 ccl::BVHOptiX::copy_to_device blender.exe :0x00007FF69A8E4210 ccl::GeometryManager::device_update_bvh blender.exe :0x00007FF69A8DF230 ccl::GeometryManager::device_update blender.exe :0x00007FF69A8A2680 ccl::Scene::device_update blender.exe :0x00007FF69A8A43E0 ccl::Scene::update blender.exe :0x00007FF69A8BC600 ccl::Session::update_scene blender.exe :0x00007FF69A8BECB0 ccl::Session::run_gpu blender.exe :0x00007FF69A8BC850 ccl::Session::run blender.exe :0x00007FF69C9E5040 ccl::thread::run blender.exe :0x00007FF69A0D4FE0 std::thread::_Invoke<std::tuple<void * __ptr64 (__cdecl*)(void * __ptr64),ccl::thread * __ptr64>,0, ucrtbase.dll :0x00007FF99FB21430 configthreadlocale KERNEL32.DLL :0x00007FF9A0277020 BaseThreadInitThunk ntdll.dll :0x00007FF9A209CEA0 RtlUserThreadStart ```

AiSatan commented

2020-11-11 08:35:43 +01:00

Added subscriber: @aisatan.ne

Robert Guetzkow commented

2020-11-11 09:48:44 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-11-11 09:59:02 +01:00

Added subscribers: @brecht, @rjg

Robert Guetzkow commented

2020-11-11 09:59:02 +01:00

CC @brecht

Dalai Felinto commented

2020-11-11 10:07:42 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2020-11-11 10:07:42 +01:00

@rjg there is no need to cc Brecht. A high priority that is tagged as Cycles will already show up in his "radar" (and the other Cycles members).
The exception is when there is bisect and the error is traced back to a commit from that developer. In this case you can go as far as assigning it to him/her if they are active + poke them on blender.chat.

@rjg there is no need to cc Brecht. A high priority that is tagged as Cycles will already show up in his "radar" (and the other Cycles members). The exception is when there is bisect and the error is traced back to a commit from that developer. In this case you can go as far as assigning it to him/her if they are active + poke them on blender.chat.

Robert Guetzkow commented

2020-11-11 11:13:03 +01:00

@dfelinto True, that was a bit pointless for this ticket.

Philipp Oeser commented

2020-11-11 15:58:57 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-11-11 15:58:57 +01:00

I cannot get it to reliably crash here

AiSatan commented

2020-11-11 16:13:25 +01:00

@lichtwerk you can try with this one, it's make "updating mesh" longer, so it's easy to crash if you change tab at this time.

test2.blend

@lichtwerk you can try with this one, it's make "updating mesh" longer, so it's easy to crash if you change tab at this time. [test2.blend](https://archive.blender.org/developer/F9260610/test2.blend)

blender-admin commented

2020-11-11 18:39:46 +01:00

This issue was referenced by d59fa12f2a

This issue was referenced by d59fa12f2ad5c57c68d63e476270fcd274b61062

Kévin Dietrich commented

2020-11-12 08:41:29 +01:00

Added subscriber: @kevindietrich

Kévin Dietrich commented

2020-11-12 08:41:30 +01:00

I haven't bisected this, but I think the culprit is 8c3d42bd0f. Basically it crashes because the Session is freed while data is still being processed. Previously it worked because the actual scene data was not freed in the id_map's destructors when calling delete sync;, so we would have to first cancel the render, and then free the session.

This little patch works, but isn't so clean IMO and is a bit redundant with the logic in the Session destructor:

diff --git a/intern/cycles/blender/blender_session.cpp b/intern/cycles/blender/blender_session.cpp
index 770f4ca51c9..d8579ae9ec8 100644
    - a/intern/cycles/blender/blender_session.cpp
+++ b/intern/cycles/blender/blender_session.cpp
@@ -260,6 +260,9 @@ void BlenderSession::reset_session(BL::BlendData &b_data, BL::Depsgraph &b_depsg
 

 void BlenderSession::free_session()
 {
+  session->progress.set_cancel("Exiting");
+  session->wait();
+

delete sync;
delete session;

I haven't bisected this, but I think the culprit is 8c3d42bd0f. Basically it crashes because the Session is freed while data is still being processed. Previously it worked because the actual scene data was not freed in the id_map's destructors when calling `delete sync;`, so we would have to first cancel the render, and then free the session. This little patch works, but isn't so clean IMO and is a bit redundant with the logic in the Session destructor: ```lang=diff diff --git a/intern/cycles/blender/blender_session.cpp b/intern/cycles/blender/blender_session.cpp index 770f4ca51c9..d8579ae9ec8 100644 - a/intern/cycles/blender/blender_session.cpp +++ b/intern/cycles/blender/blender_session.cpp @@ -260,6 +260,9 @@ void BlenderSession::reset_session(BL::BlendData &b_data, BL::Depsgraph &b_depsg void BlenderSession::free_session() { + session->progress.set_cancel("Exiting"); + session->wait(); + ``` delete sync; delete session; ``` } ```

Robert Guetzkow commented

2020-11-12 11:23:36 +01:00

@kevindietrich This does indeed seem to be the commit. After the commit I'm getting a crash, with one commit before it freezes indefinitely when clicking on the other tab (Blender still runs, but doesn't update the UI or react to clicks).

Brecht Van Lommel commented

2020-11-12 20:23:50 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue

2020-11-12 20:23:50 +01:00

Brecht Van Lommel self-assigned this 2020-11-12 20:23:50 +01:00

Brecht Van Lommel commented

2020-11-12 20:36:34 +01:00

I don't mind being CCed on high priority bugs. This close to the release I'll check the list every day, but it's helpful in general I think.

Brecht Van Lommel commented

2020-11-12 20:38:18 +01:00

@kevindietrich I didn't see you already found the cause, I was looking into this yesterday and committed the fix just now. My fix is basically what you proposed deduplication the code with the session destruction.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles: Blender crash on switching between tabs #82607