Assertion Failure: Moving Keyframe in Graph Editor beyond enum range #82669

New Issue

Christoph Lendenfeld · 2020-11-12T18:00:23+01:00

2020-11-12 18:00:23 +01:00

System Information
Operating system: Linux Mint Mate 19
Graphics card: Nvidia GTX 850M

Blender Version
Broken: master 2020-11-12 @ Merge branch 'blender-v2.91-release' only on debug builds 987732181f
Worked: Anything that is not a debug build will not show any problems

Short description of error
This issue is split off from #44219 (Pose Breakdowner bug in Gooseberry rigs)
Moving a keyframe of an enum in the graph editor allows it to go beyond the range of the enum. This causes an assert to fail

Exact steps for others to reproduce the error

Open the file
Move the keyframe up
Blender crashed as soon as you exceed the enum range
enum_property_crash.blend

**System Information** Operating system: Linux Mint Mate 19 Graphics card: Nvidia GTX 850M **Blender Version** Broken: master 2020-11-12 @ Merge branch 'blender-v2.91-release' only on debug builds 987732181f779ca792de933aa5f001168b1f6f26 Worked: Anything that is not a debug build will not show any problems **Short description of error** This issue is split off from #44219 (Pose Breakdowner bug in Gooseberry rigs) Moving a keyframe of an enum in the graph editor allows it to go beyond the range of the enum. This causes an assert to fail **Exact steps for others to reproduce the error** * Open the file * Move the keyframe up * Blender crashed as soon as you exceed the enum range [enum_property_crash.blend](https://archive.blender.org/developer/F9267184/enum_property_crash.blend)

Christoph Lendenfeld commented

2020-11-12 18:00:23 +01:00

Added subscriber: @ChrisLend

Christoph Lendenfeld commented

2020-11-12 18:06:27 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-11-13 09:43:56 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-11-13 09:43:56 +01:00

Are you sure this is a regression?

I am getting following assert in Debug builds:

BLI_assert failed: source/blender/blenlib/intern/math_rotation.c:1589, get_rotation_order_info(), at 'order >= 0 && order <= 6'

But no crash in Release builds

Are you sure this is a regression? I am getting following assert in Debug builds: ``` BLI_assert failed: source/blender/blenlib/intern/math_rotation.c:1589, get_rotation_order_info(), at 'order >= 0 && order <= 6' ``` But no crash in Release builds

Christoph Lendenfeld commented

2020-11-13 11:49:23 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Christoph Lendenfeld closed this issue

2020-11-13 11:49:23 +01:00

Christoph Lendenfeld self-assigned this 2020-11-13 11:49:23 +01:00

Christoph Lendenfeld commented

2020-11-13 11:49:23 +01:00

Sorry I missed that. I didn't know asserts would cause a crash in debug builds.
In that case I will close that issue then.
I think it makes no sense to keep it as a known issue if it never is a problem in final builds.

Sorry I missed that. I didn't know asserts would cause a crash in debug builds. In that case I will close that issue then. I think it makes no sense to keep it as a known issue if it never is a problem in final builds.

Philipp Oeser commented

2020-11-13 12:02:58 +01:00

Added subscriber: @dr.sybren

Philipp Oeser commented

2020-11-13 12:02:58 +01:00

Well it is always good to have an eye on asserts [after all, they tell you something is not working as expected]
In this case I am not so sure if it is worth chasing this more... Keyframing enums is special, not sure how we'd safeguard properly here.

Still, letting @dr.sybren know

P.S.: you can disable "crash" on asserts in Debug builds with this CMAKE option WITH_ASSERT_ABORT

Well it is always good to have an eye on asserts [after all, they tell you something is not working as expected] In this case I am not so sure if it is worth chasing this more... Keyframing enums is special, not sure how we'd safeguard properly here. Still, letting @dr.sybren know P.S.: you can disable "crash" on asserts in Debug builds with this CMAKE option `WITH_ASSERT_ABORT`

Sybren A. Stüvel commented

2020-11-16 10:53:18 +01:00

In #82669#1053887, @ChrisLend wrote:
Sorry I missed that. I didn't know asserts would cause a crash in debug builds.
In that case I will close that issue then.

The assertion failing shows that there is a problem, in that the data fed to a function doesn't adhere to the expected range, so the function will not do the right thing. We shouldn't be accepting a failing assert in the same way that we don't accept a failing unit test.

We could keep this report open as a Known Issue, or as a low-priority bug. Not sure how hard it would be to find a proper fix for this, though.

> In #82669#1053887, @ChrisLend wrote: > Sorry I missed that. I didn't know asserts would cause a crash in debug builds. > In that case I will close that issue then. The assertion failing shows that there is a problem, in that the data fed to a function doesn't adhere to the expected range, so the function will not do the right thing. We shouldn't be accepting a failing assert in the same way that we don't accept a failing unit test. We could keep this report open as a Known Issue, or as a low-priority bug. Not sure how hard it would be to find a proper fix for this, though.

Sybren A. Stüvel commented

2020-11-16 11:47:26 +01:00

Changed status from 'Resolved' to: 'Confirmed'

Sybren A. Stüvel reopened this issue

2020-11-16 11:47:26 +01:00

Christoph Lendenfeld changed title from ~~Crash: Moving Keyframe in Graph Editor beyond enum range~~ to Assertion Failure: Moving Keyframe in Graph Editor beyond enum range

2020-11-16 12:26:30 +01:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Assertion Failure: Moving Keyframe in Graph Editor beyond enum range #82669