Grease Pencil Fill Tool Breaks After Scroll-Wheel Zooming Window #82672

Open
opened 2020-11-12 21:15:46 +01:00 by Z · 11 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-11-02 13:28, hash: 42f6aada98
Also tested in 2.83.9 & 2.92 Alpha on Windows, and 2.91 Beta on Mac with same results.

Short description of error
If an 'unclosed' area made with grease pencil lines on its own layer overlaps and is 'closed' with grease pencil lines on a second layer, zooming the 2d workspace in and out will cause the fill tool to 'break' and fill the whole screen; even when the fill tool is set to: Advanced-Layers-Visible.

Exact steps for others to reproduce the error
Create closed shape on one layer. Create 'open' shape on second layer that overlaps and is closed by grease pencil lines from the first layer. Zoom in and out in workspace while using the fill tool in a separate 'fill' layer.
Please see attached .blend file and screen capture:

FillTest.blend

FillTest.mp4

I really hope this isn't just user error. Thank you for taking a look!

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30 **Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-11-02 13:28, hash: `42f6aada98` Also tested in 2.83.9 & 2.92 Alpha on Windows, and 2.91 Beta on Mac with same results. **Short description of error** If an 'unclosed' area made with grease pencil lines on its own layer overlaps and is 'closed' with grease pencil lines on a second layer, zooming the 2d workspace in and out will cause the fill tool to 'break' and fill the whole screen; even when the fill tool is set to: Advanced-Layers-Visible. **Exact steps for others to reproduce the error** Create closed shape on one layer. Create 'open' shape on second layer that overlaps and is closed by grease pencil lines from the first layer. Zoom in and out in workspace while using the fill tool in a separate 'fill' layer. Please see attached .blend file and screen capture: [FillTest.blend](https://archive.blender.org/developer/F9268260/FillTest.blend) [FillTest.mp4](https://archive.blender.org/developer/F9268249/FillTest.mp4) I really hope this isn't just user error. Thank you for taking a look!
Author

Added subscriber: @weedooweedoo

Added subscriber: @weedooweedoo

Added subscriber: @iss

Added subscriber: @iss

Changed status from 'Needs Triage' to: 'Archived'

Changed status from 'Needs Triage' to: 'Archived'
Richard Antalik self-assigned this 2020-11-13 05:37:52 +01:00

Thank you for report,
This is because strokes do have thickness, but they are constructed over 2D wires without thickness.
If you switch to edit mode, you can see that wires don't overlap. if you fix overlap manually, this won't happen.

Thank you for report, This is because strokes do have thickness, but they are constructed over 2D wires without thickness. If you switch to edit mode, you can see that wires don't overlap. if you fix overlap manually, this won't happen.

Changed status from 'Archived' to: 'Needs Triage'

Changed status from 'Archived' to: 'Needs Triage'

Added subscriber: @antoniov

Added subscriber: @antoniov

Checking this a bit further, thickness is accounted for, but gap must be less then 1/2 of thickness which is not in your example.
Perhaps this could be improved, but I am not sure if this would be considered a bug.

I will reopen and ask @antoniov for opinion.

Checking this a bit further, thickness is accounted for, but gap must be less then 1/2 of thickness which is not in your example. Perhaps this could be improved, but I am not sure if this would be considered a bug. I will reopen and ask @antoniov for opinion.
Author

Thank you for your response.

Is there a reason why the fill would work normally at certain 'zooms' but not at other closer zooms if it was just the gap size between strokes? If the wire gap is greater than 1/2 the stroke thickness wouldn't it always overfill?

Also how would strokes of different sizes affect this?

Thanks!

Thank you for your response. Is there a reason why the fill would work normally at certain 'zooms' but not at other closer zooms if it was just the gap size between strokes? If the wire gap is greater than 1/2 the stroke thickness wouldn't it always overfill? Also how would strokes of different sizes affect this? Thanks!

This is a limitation of the current method used to fill areas. Actually, a flood fill is done using pixel information, so this method is affected by the zoom level.We are working on a new method of filling using Booleans, but this is a complex topic and will need some time. With the new approach, the fill will not be affected by zoom level anymore.

This is a limitation of the current method used to fill areas. Actually, a flood fill is done using pixel information, so this method is affected by the zoom level.We are working on a new method of filling using Booleans, but this is a complex topic and will need some time. With the new approach, the fill will not be affected by zoom level anymore.

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author

Thank you for taking the time to answer this question, I really appreciate it. Looking forward to seeing where Grease Pencil goes in the future!

Thank you for taking the time to answer this question, I really appreciate it. Looking forward to seeing where Grease Pencil goes in the future!
Philipp Oeser removed the
Interest
Grease Pencil
label 2023-02-09 15:19:43 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#82672
No description provided.