Page MenuHome

Sockets Colors for int, boolean
Closed, ResolvedPublicDESIGN

Description

This is the first time we expose booleans, ints as sockets. We need to confirm if we really want a single color per type.

Event Timeline

We should also investigate using different socket shapes as well for the different data types.

Dalai Felinto (dfelinto) changed the task status from Needs Triage to Confirmed.Nov 30 2020, 3:29 PM

Testing this in the shader nodes, I find these changes as a whole worse than before. I approved changing the shader socket color to red, but it needs to fit together as a whole.

  • To me it looks too colorful, I think having bool/float/int/string as white/grey helps to keep things readable and not too distracting. Looking at a complex node graph now I find it hard to focus. I think especially geometry/object/shader sockets should stand out.
  • In shader nodes, the shader category and shader socket were both green by design. Now only the shader node is red, I'd prefer these to remain consistent and the header to also get the same color red. I would rather see the input/output categories change to green, they basically represent geometry in the shader nodes anyway.
  • I would like to see more coordination between the socket colors, they don't look compatible now. For example varying hue and keeping value/saturation the same is a way to do this. Which sockets colors are saturated and which are not seems arbitrary now.

Was color-blindness considered for these tweaks? Whenever we use colors to communicate meaning we should keep that in mind. There are various (online) tools available to simulate color-blindness.

I'm not really sure why the decision to change to red - the input and output nodes are already Red? The shader nodes are a specific type of node within shaders and (at least for NPR) entire shaders can be created without them at all.
My biggest concern is the yellow RGB socket and the now also yellow scalar socket.
Considering that RGB and XYZ vectors are converted to Scalar differently with RGB - Scalar being the non-intuitive transfer it seems especially risky putting those sockets so close in colour.
It is very common in a shader to use a MixRGB to affect coordinates so having someone connect a yellow to a slightly different yellow socket is going to break the whole shader.
They look close enough that a beginner could reasonably assume that they can be joined together.

Accessibility point of view: They look identical for anyone with Blue-Blind/Tritanopia.

Is there an intent to address the issues I raised for 2.92? If not I propose we revert this change for the most part, as to me this looks like a regression for shading nodes at least.

Is there an intent to address the issues I raised for 2.92? If not I propose we revert this change for the most part, as to me this looks like a regression for shading nodes at least.

Yes I'm preparing a patch to address some of these issues based on feedback.

I also changed the shader sockets and node headers back to green now in rB09fe0e8aa94c: Nodes: use green color again for shader sockets and shader category, since we're in bcon3 and this was still not in a good state in my opinion.

I also changed the shader sockets and node headers back to green now in rB09fe0e8aa94c: Nodes: use green color again for shader sockets and shader category, since we're in bcon3 and this was still not in a good state in my opinion.

Thanks! Hopefully we can revisit this topic more carefully for 3.0 if we get the new node design without the header background (which limits the color choices because of the node label).