Points instancing - crash. #82880

Closed
opened 2020-11-20 19:35:07 +01:00 by Sergey · 9 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.09

Blender Version
Broken: version: 2.92.0 Alpha, branch: geometry-nodes, commit date: 2020-11-20 11:06, hash: 2781e51cda

Short description of error
Probably it's too early to report but just in case I will.

{F9339301, size=full}

untitled1.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.09 **Blender Version** Broken: version: 2.92.0 Alpha, branch: geometry-nodes, commit date: 2020-11-20 11:06, hash: `2781e51cda` **Short description of error** Probably it's too early to report but just in case I will. {[F9339301](https://archive.blender.org/developer/F9339301/2020-11-20_22-30-24.png), size=full} [untitled1.blend](https://archive.blender.org/developer/F9339304/untitled1.blend)
Author

Added subscriber: @randum

Added subscriber: @randum
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

Thanks for the report. I can reproduce the crash with your file, but not if I reproduce the same set of node myself.

The problem seems to be with the recursive instancing, it keeps on creating sets of points. Interestingly it eats up all 32 GB of memory I have before hitting a stack overflow though.

Thanks for the report. I can reproduce the crash with your file, but not if I reproduce the same set of node myself. The problem seems to be with the recursive instancing, it keeps on creating sets of points. Interestingly it eats up all 32 GB of memory I have before hitting a stack overflow though.
Member

Aha, this is a trick file!
{F9342099 size=full}

The cube isn't actually a Mesh, it's the same object with more instancing on it. It's not actually an infinite loop, it's 40^8 (8 is the maximum instancing recursion) or about 6.5 billion instances that it's trying to make.

Something like this ought to solve the problem:

    if (object != ctx->object) {
      make_recursive_duplis(ctx, object, matrix, i);
    }

But the instances aren't actually showing up for me in this scene right now, not sure why. So I didn't properly test this yet.

Aha, this is a trick file! {[F9342099](https://archive.blender.org/developer/F9342099/image.png) size=full} The cube isn't actually a Mesh, it's the same object with more instancing on it. It's not actually an infinite loop, it's 40^8 (8 is the maximum instancing recursion) or about 6.5 billion instances that it's trying to make. Something like this ought to solve the problem: ``` if (object != ctx->object) { make_recursive_duplis(ctx, object, matrix, i); } ``` But the instances aren't actually showing up for me in this scene right now, not sure why. So I didn't properly test this yet.
Author

My operation system is closing all programs after several seconds of processing this tree.

My operation system is closing all programs after several seconds of processing this tree.
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Jacques Lucke self-assigned this 2020-12-08 17:42:16 +01:00
Member

I added a simple check for recursive instancing a couple of days ago. This bug seems to be solved by that. We still don't have a recursive check, that also works with multiple levels of instancing, but that can be added later.

I added a simple check for recursive instancing a couple of days ago. This bug seems to be solved by that. We still don't have a recursive check, that also works with multiple levels of instancing, but that can be added later.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#82880
No description provided.