Box/lasso select tools (in both 3D and 2D views) consume events they shouldn't be #82985

New Issue

Stanislav Blinov · 2020-11-25T02:04:38+01:00

Stanislav Blinov commented

2020-11-25 02:04:38 +01:00

Blender Version
Broken: since 2.80?

Short description of error

With the default keymap, the active box select and lasso tools consume mouse clicks if a non-modifier key is held.

Practical example: in mesh edit mode, if selection mode is switched with a hotkey (1, 2, 3) and mouse is immediately clicked, the click often doesn't go through since it is often the case that the hotkey is not yet released by the time mouse is clicked.

One can circumvent this by manually editing keymaps for 3D/2D view Box/Lasso tools and adding handlers for mouse Release events. However, that is a crutch. These tools should not be blocking clicks in the first place, nor require special setup from the user.

Exact steps for others to reproduce the error

Enter edit mode on the default cube and try to quickly switch between selection modes using the 1, 2, 3 hotkeys and click-selecting the relevant elements. If done quick enough, you will notice that clicks often don't register.

In keymap preferences, 3D View -> Mesh, 3D View Tool: Select Box, add a new entry for Left Mouse Release with operator view3d.select. After this the tool behaves as expected.

I think the keymap solution is impractical though: it would involve recreating all click-selection functionality in each of these tools, with modifiers like shift and ctrl, all around the Release event. A better event handling in the tools themselves is required.

**Blender Version** Broken: since 2.80? **Short description of error** With the default keymap, the active box select and lasso tools consume mouse clicks if a non-modifier key is held. Practical example: in mesh edit mode, if selection mode is switched with a hotkey (1, 2, 3) and mouse is immediately clicked, the click often doesn't go through since it is often the case that the hotkey is not yet released by the time mouse is clicked. One can circumvent this by manually editing keymaps for 3D/2D view Box/Lasso tools and adding handlers for mouse **Release** events. However, that is a crutch. These tools should not be blocking clicks in the first place, nor require special setup from the user. **Exact steps for others to reproduce the error** Enter edit mode on the default cube and try to quickly switch between selection modes using the 1, 2, 3 hotkeys and click-selecting the relevant elements. If done quick enough, you will notice that clicks often don't register. In keymap preferences, 3D View -> Mesh, 3D View Tool: Select Box, add a new entry for Left Mouse Release with operator view3d.select. After this the tool behaves as expected. I think the keymap solution is impractical though: it would involve recreating all click-selection functionality in each of these tools, with modifiers like shift and ctrl, all around the Release event. A better event handling in the tools themselves is required.

Stanislav Blinov commented

2020-11-25 02:04:38 +01:00

Added subscriber: @Stan_Pancakes

Robert Guetzkow commented

2020-11-25 11:26:17 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-11-25 11:26:17 +01:00

Changed status from 'Needs Triage' to: 'Archived'

Robert Guetzkow closed this issue

2020-11-25 11:26:17 +01:00

Robert Guetzkow commented

2020-11-25 11:26:17 +01:00

This is not a bug. Keeping another key pressed and clicking with the mouse is a different key binding and therefore not the same action. Selecting a e.g. a vertex require only the mouse button to be pressed. You can observe the same behavior when picking a key that is not used in any shortcut, keep it pressed and attempt to click with the mouse.

Stanislav Blinov commented

2020-11-25 11:34:28 +01:00

I understand why this happens, it's just that it's really disrupting in this particular case. You can't create e.g. a "1 + left mouse" binding either, so there doesn't even seem to be a way to overcome this (save for scripting a custom selection operator, yuck). Or can you?

Robert Guetzkow commented

2020-11-25 11:40:26 +01:00

You could add one, however you can't have multiple shortcuts activate at the same time. This falls pretty clearly into the improvement suggestion / feature request category. While this may be nice to have, it is unfortunately off-topic on the bug tracker.

Stanislav Blinov commented

2020-11-25 14:29:49 +01:00

Upon further investigation this appears to be tool-specific. If you have the box or lasso select as active tools (from the toolbar, though it also applies to modal ones), holding any key other than modifiers while clicking indeed consumes the click without action. But if you switch to Tweak tool, selection occurs on click even if you hold 1, 2, or any other (even unassigned) key.

Stanislav Blinov changed title from ~~Inconsistent UX when using hotkeys for mesh edit mode switching~~ to Box/lasso select tools (in both 3D and 2D views) consume events they shouldn't be

2020-11-25 15:10:55 +01:00

Stanislav Blinov commented

2020-11-25 15:12:31 +01:00

@rjg Please reassess.

Stanislav Blinov commented

2020-11-25 23:25:08 +01:00

Alright, after looking at the code I can understand the problem (and the scope of it) much better now. Ouch.
Additionally, the aforementioned solution via Release binding isn't practical at all as it creates more problems than it solves.

Alright, after looking at the code I can understand the problem (and the scope of it) much better now. Ouch. Additionally, the aforementioned solution via Release binding isn't practical at all as it creates more problems than it solves.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Box/lasso select tools (in both 3D and 2D views) consume events they shouldn't be #82985