Page MenuHome

The alternate rows in the Sequencer are green (macOS)
Closed, ResolvedPublic

Description

System Information
Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.10.18

Blender Version
Broken: version: 2.92.0 Alpha
After rBf7223d5f722a: UI: Allow theming the alternate row color in the sequencer

Short description of error
The alternate rows in the Sequencer are green.

Similar to T81827: MacOS lines that should be thick are green instead

Event Timeline

Yevgeny Makarov (jenkm) changed the task status from Needs Triage to Confirmed.Nov 27 2020, 9:45 AM
Yevgeny Makarov (jenkm) created this task.

Maybe it would help to blend the colors then set the alpha back to 1.0 again... But I have no way of testing it on macOS.

There are also glitches on Linux that I could reproduce with a Intel Haswell (T83318). At the time I wasn't sure if this was caused by Blender or the driver, but given that glitches also happen on macOS this seems to be a bug in Blender.

@Yevgeny Makarov (jenkm) thanks for the help triaging, but when something is marked as confirmed, it has to be fully triaged. In other words, the module responsible for it should be tagged, not assigning developers. See https://wiki.blender.org/wiki/Process/A_Bugs_Life

Otherwise it doesn't show up in the corresponding module workboard.

@Hans Goudey (HooglyBoogly) since this was introduced with your commit, mind checking it?

This for "UI" and "EEVEE & Viewport" projects, not "VFX & Video", "Video Sequencer".
It is related to the gpu shader.


@Erik Abrahamsson (erik85) - Maybe it would help to blend the colors then set the alpha back to 1.0 again.

Yes, the similar code for file browser used immUniformThemeColorBlend(), so something like the code below will work.
But you will need to adjust the other colors too.

if (i & 1) {
  immUniformThemeColorBlend(TH_BACK, TH_ROW_ALTERNATE, col_alternating[3]);
}
else {
  immUniformThemeColor(TH_BACK);
}

Also I would try using TH_GRID in the UI_view2d_constant_grid_draw(), this color doesn't seem to be used right now.

Okay, I think there's just a mistake in UI_GetThemeColorBlendShade4fv().

The offset (shading) should not be applied to alpha, similar to how it is in UI_GetThemeColorShade4fv.


There is no any background under these stripes, so we have a semi-transparent stripe and nothing under it to blend in with.