Inconsitency in channel pinning mechanic (animation/drivers) #83479

Open
opened 2020-12-06 18:45:23 +01:00 by Vas · 14 comments

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30

Blender Version
Broken: version: 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: 0f45cab862
Worked: (newest version of Blender that worked as expected)

Short description of error
Apparently pinning function is a bit broken, here's the issue:
Here's list of data blocks that don't trigger channel pinning icon:

  • Shape keys
  • Materials
  • Object data > Autosmooth
  • Object data > Remesh
  • Particles > Physics
  • Particles > Render
  • Particles > Emission > Seed
  • Particles > Emission >Lifetime
  • Particles > Emission >Lifetime Randomness
  • Particles > Viewport Display > Display as
  • Particles > Viewport Display > Color
  • Particles > Viewport Display > Amount
  • Particles > Viewport Display > Size
  • Particles > Children
  • Particles > Field Weights
  • World > (All nodes don't display pins)
  • World > Viewport display
  • Scene > (All scene settings can't be pinned)
  • View Layer properties > (all settings can't be pinned)
  • Output properties > (all settings can't be pinned)
  • Render properties > (all settings can't be pinned)

Here's list of data blocks that do trigger channel pinning icon:

  • Object data transforms (location rotation scale)
  • Modifiers
  • Constraints
  • Rigid body constraints
  • Particles >Render > Show Emitter
  • Particles > Viewport Display > Show emitter
  • Physics properties (all modifiers)

The issue:Currently there's a limitation where channel pinning mechanic is only available onObjectlevel datablocks (feature introduced in 98c7e75897), but apparently its possible to circumvent this limitation to deeper types of datablocks (materials, particles, etc.) by adding a keyframe to any type of object level value (Eg. Location data). Even after removing that keyframe, the object keeps pin functionality (that previously was inaccessible)Also same issue persists in Drivers window too
image.png
Solution
Just keep pinning option always available

Here's the video demonstrating in detail this issue
2020-12-06 17-20-58_1.mp4

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30 **Blender Version** Broken: version: 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: `0f45cab862` Worked: (newest version of Blender that worked as expected) **Short description of error** Apparently pinning function is a bit broken, here's the issue: Here's list of data blocks that **don't** trigger channel pinning icon: - Shape keys - Materials - Object data > Autosmooth - Object data > Remesh - Particles > Physics - Particles > Render - Particles > Emission > Seed - Particles > Emission >Lifetime - Particles > Emission >Lifetime Randomness - Particles > Viewport Display > Display as - Particles > Viewport Display > Color - Particles > Viewport Display > Amount - Particles > Viewport Display > Size - Particles > Children - Particles > Field Weights - World > (All nodes don't display pins) - World > Viewport display - Scene > (All scene settings can't be pinned) - View Layer properties > (all settings can't be pinned) - Output properties > (all settings can't be pinned) - Render properties > (all settings can't be pinned) Here's list of data blocks that **do** trigger channel pinning icon: - Object data transforms (location rotation scale) - Modifiers - Constraints - Rigid body constraints - Particles >Render > Show Emitter - Particles > Viewport Display > Show emitter - Physics properties (all modifiers) **`The issue:`**Currently there's a limitation where channel pinning mechanic is only available on**Object**level datablocks (feature introduced in 98c7e75897), but apparently its possible to circumvent this limitation to deeper types of datablocks (materials, particles, etc.) by adding a keyframe to any type of object level value (Eg. Location data). Even after removing that keyframe, the object keeps pin functionality (that previously was inaccessible)**Also same issue persists in Drivers window too** ![image.png](https://archive.blender.org/developer/F9490227/image.png) **`Solution`** Just keep pinning option always available Here's the video demonstrating in detail this issue [2020-12-06 17-20-58_1.mp4](https://archive.blender.org/developer/F9480852/2020-12-06_17-20-58_1.mp4) **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)]
Author

Added subscriber: @Alumx

Added subscriber: @Alumx

Added subscriber: @rjg

Added subscriber: @rjg

@Alumx am I understanding your video correctly that the pin option and visibility option is sometimes not displayed in the Graph Editor, e.g. when adding a shape key, but it is displayed when adding an action? Removing the action however, does not remove the pin and visibility option?

@Alumx am I understanding your video correctly that the pin option and visibility option is sometimes not displayed in the *Graph Editor*, e.g. when adding a shape key, but it is displayed when adding an action? Removing the action however, does not remove the pin and visibility option?

Added subscriber: @LucianoMunoz

Added subscriber: @LucianoMunoz

I would argue pinning should be always present on a per channel basis not on a per channel group.

I would argue pinning should be always present on a per channel basis not on a per channel group.

Added subscribers: @vas-1, @dr.sybren

Added subscribers: @vas-1, @dr.sybren

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'

@vas-1 Please fill out the bug report form completely, and don't rely on a video to convey the information. Videos are nice extras, but are not replacement for a textual description of the problem.

@vas-1 Please fill out the bug report form completely, and don't rely on a video to convey the information. Videos are nice extras, but are not replacement for a textual description of the problem.
Author

Removed subscriber: @vas-1

Removed subscriber: @vas-1
Author

@dr.sybren added more info! (also you mentioned someone else back there :p)

In #83479#1069859, @LucianoMunoz wrote:
I would argue pinning should be always present on a per channel basis not on a per channel group.

^I agree to this, would be nice universal solution

In #83479#1069851, @rjg wrote:
@Alumx am I understanding your video correctly that the pin option and visibility option is sometimes not displayed in the Graph Editor, e.g. when adding a shape key, but it is displayed when adding an action? Removing the action however, does not remove the pin and visibility option?

yes, this issue is even more severe if you add keyframe for example in Particles > Viewport display
2020-12-07-18-34-16.gif

@dr.sybren added more info! (also you mentioned someone else back there :p) > In #83479#1069859, @LucianoMunoz wrote: > I would argue pinning should be always present on a per channel basis not on a per channel group. ^I agree to this, would be nice universal solution > In #83479#1069851, @rjg wrote: > @Alumx am I understanding your video correctly that the pin option and visibility option is sometimes not displayed in the *Graph Editor*, e.g. when adding a shape key, but it is displayed when adding an action? Removing the action however, does not remove the pin and visibility option? yes, this issue is even more severe if you add keyframe for example in Particles > Viewport display ![2020-12-07-18-34-16.gif](https://archive.blender.org/developer/F9490245/2020-12-07-18-34-16.gif)

Thanks for the update.

Channel pinning was introduced in 98c7e75897 and was limited to certain channel types.
This means that it's a known limitation of Blender, and not considered a bug.

Thanks for the update. Channel pinning was introduced in 98c7e75897 and was limited to certain channel types. This means that it's a known limitation of Blender, and not considered a bug.
Author

In #83479#1070807, @dr.sybren wrote:
Thanks for the update.

Channel pinning was introduced in 98c7e75897 and was limited to certain channel types.
This means that it's a known limitation of Blender, and not considered a bug.

I mean, I found a way to break the functionality and keep the pin persistent even if it shouldn't be available for those kinds of data blocks
You can force pin availability by adding and removing object type animation
Isn't that literally a bug?

> In #83479#1070807, @dr.sybren wrote: > Thanks for the update. > > Channel pinning was introduced in 98c7e75897 and was limited to certain channel types. > This means that it's a known limitation of Blender, and not considered a bug. I mean, I found a way to break the functionality and keep the pin persistent even if it shouldn't be available for those kinds of data blocks You can force pin availability by adding and removing object type animation Isn't that literally a bug?

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'

@dr.sybren as you've marked this as a known issue, I'm setting the status to confirmed.

@dr.sybren as you've marked this as a known issue, I'm setting the status to confirmed.
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:35:57 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#83479
No description provided.