Search for add-ons does not include category #83747

New Issue

Jeric Chard · 2020-12-14T04:09:24+01:00

Jeric Chard commented

2020-12-14 04:09:24 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.38

Blender Version
Broken: version: 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: 0f45cab862
Worked: (newest version of Blender that worked as expected)

Short description of error
Searches that should be finding addons are not

Exact steps for others to reproduce the error
If I use the string "IMP" I get several Import plugins, but not the OBJ importer.

OTOH, if I input "OBJ", the OBJ import is displayed/found, and has the string "import" in its name.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.38 **Blender Version** Broken: version: 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: `0f45cab862` Worked: (newest version of Blender that worked as expected) **Short description of error** Searches that should be finding addons are not **Exact steps for others to reproduce the error** If I use the string "IMP" I get several Import plugins, but not the OBJ importer. OTOH, if I input "OBJ", the OBJ import is displayed/found, and has the string "import" in its name.

Jeric Chard commented

2020-12-14 04:09:24 +01:00

Added subscriber: @jeric_synergy

Vincent Blankfield commented

2020-12-14 08:39:09 +01:00

Added subscriber: @VincentBlankfield

Vincent Blankfield commented

2020-12-14 08:39:09 +01:00

That's because current search looks into the addon name or author only. In case of the OBJ importer the name is "Wavefront OBJ format" and the "import" word is present in it's category: "Import-Export".

IMHO the search should look for the category too. Having excessive search result is less confusing then not having enough. And the user may always specify more strict search term. Like in this example, the user may quickly searh for "import" and have an impression that it's all that have anything to do with import.

The change to add categories to the search is simple:

lines=5
diff --git a/release/scripts/startup/bl_ui/space_userpref.py b/release/scripts/startup/bl_ui/space_userpref.py
index 88b3ad5e056..2f865e24cab 100644
--- a/release/scripts/startup/bl_ui/space_userpref.py
+++ b/release/scripts/startup/bl_ui/space_userpref.py
@@ -1848,7 +1848,11 @@ class USERPREF_PT_addons(AddOnPanel, Panel):
                 is_visible = is_visible and is_enabled
 
             if is_visible:
-                if search and search not in info["name"].lower():
+                if (
+                    search and
+                    search not in info["name"].lower() and
+                    search not in info["category"].lower()
+                ):
                     if info["author"]:
                         if search not in info["author"].lower():
                             continue

Also the description may be added too.

That's because current search looks into the addon name or author only. In case of the OBJ importer the name is "Wavefront OBJ format" and the "import" word is present in it's category: "Import-Export". IMHO the search should look for the category too. Having excessive search result is less confusing then not having enough. And the user may always specify more strict search term. Like in this example, the user may quickly searh for "import" and have an impression that it's all that have anything to do with import. The change to add categories to the search is simple: ``` lines=5 diff --git a/release/scripts/startup/bl_ui/space_userpref.py b/release/scripts/startup/bl_ui/space_userpref.py index 88b3ad5e056..2f865e24cab 100644 --- a/release/scripts/startup/bl_ui/space_userpref.py +++ b/release/scripts/startup/bl_ui/space_userpref.py @@ -1848,7 +1848,11 @@ class USERPREF_PT_addons(AddOnPanel, Panel): is_visible = is_visible and is_enabled if is_visible: - if search and search not in info["name"].lower(): + if ( + search and + search not in info["name"].lower() and + search not in info["category"].lower() + ): if info["author"]: if search not in info["author"].lower(): continue ``` Also the description may be added too.

Robert Guetzkow changed title from ~~search results in Preferences/Addons not consistent~~ to Search for add-ons does not include category

2020-12-14 11:50:00 +01:00

Julian Eisel commented

2020-12-14 11:53:43 +01:00

Added subscriber: @JulianEisel