Adjust the decision making for result attribute types #83793

New Issue

Jacques Lucke · 2020-12-15T11:53:49+01:00

Jacques Lucke commented

2020-12-15 11:53:49 +01:00

Nodes like the Attribute Color Ramp node would usually output a color. However, if the result attribute exists already and is e.g. of type Float, we want that the attribute remains of type float.
Currently the attribute is first removed and then recreated with a new type.

This makes the type of an attribute more consistent, because nodes usually do not change the type of attributes, unless they are explicitly asked to do so. Furthermore, this allows us to use the same attribute as input and output in a node more often. (e.g. in the Attribute Color Ramp node, the input and output attribute could be the same)

Nodes like the `Attribute Color Ramp` node would usually output a color. However, if the result attribute exists already and is e.g. of type Float, we want that the attribute remains of type float. Currently the attribute is first removed and then recreated with a new type. This makes the type of an attribute more consistent, because nodes usually do not change the type of attributes, unless they are explicitly asked to do so. Furthermore, this allows us to use the same attribute as input and output in a node more often. (e.g. in the Attribute Color Ramp node, the input and output attribute could be the same)

Jacques Lucke commented

2020-12-15 11:53:49 +01:00

Added subscriber: @JacquesLucke

Dalai Felinto commented

2020-12-17 15:37:40 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2020-12-17 15:37:40 +01:00

Perhaps integer, float and bool should all be floats internally?

Jacques Lucke commented

2020-12-17 15:43:02 +01:00

I don't think this is a good idea... Also, what would it solve?

Jacques Lucke commented

2021-01-12 15:26:41 +01:00

Added subscriber: @HooglyBoogly

Jacques Lucke commented

2021-01-12 15:26:41 +01:00

Proposal from me and @HooglyBoogly.

If an input and an output attribute have the same name but different type, first compute the new attribute, before deleting the old one.

Attribute Math: Always output float.
Attribute Compare: Always output boolean.
Attribute Mix: Have a output type dropdown (including Auto option).
Attribute Color Ramp: Same as Attribute Mix.
Attribute Vector Math: Output type depends on the operation.

Proposal from me and @HooglyBoogly. If an input and an output attribute have the same name but different type, first compute the new attribute, before deleting the old one. * Attribute Math: Always output float. * Attribute Compare: Always output boolean. * Attribute Mix: Have a output type dropdown (including `Auto` option). * Attribute Color Ramp: Same as Attribute Mix. * Attribute Vector Math: Output type depends on the operation.

Jacques Lucke commented

2021-01-12 16:50:01 +01:00

We decided to use the Auto option implicitly for Attribute Mix, Attribute Color Ramp and only add an enum later if there is a need for it.
The other points mentioned in the proposal are good.

We decided to use the `Auto` option implicitly for `Attribute Mix`, `Attribute Color Ramp` and only add an enum later if there is a need for it. The other points mentioned in the proposal are good.

Hans Goudey changed title from ~~Do not change data type of result attribute if it exists already~~ to Adjust the decision making for result attribute types

2021-01-12 20:55:37 +01:00

blender-admin commented

2021-01-12 21:03:35 +01:00

This issue was referenced by 719bea0d6d

This issue was referenced by 719bea0d6d06be579edee2fc3d12a7828bb8e101

blender-admin commented

2021-01-14 15:52:08 +01:00

This issue was referenced by e5ee7e9a2d

This issue was referenced by e5ee7e9a2df93d7f28f9e1f8bc0eb2d33dfadfb4

Dalai Felinto commented

2021-02-01 14:16:16 +01:00

Needs wiki update.