Crash to desktop with too high number in the ocean modifier resolution viewport value #83952

New Issue

Reiner Prokein · 2020-12-19T12:53:39+01:00

Reiner Prokein commented

2020-12-19 12:53:39 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.43

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-19 06:25, hash: a5a302bd18

Short description of error
A high value like 1200 in the resolution viewport in the ocean modifier will crash Blender to desktop.

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Open Blender.
Add a ocean modifier.
Type in 1200 in the resolution viewport field.
Hit enter.
Crash.

2020-12-19 12-52-49.mp4

The needed files with informations: blender_system_info.zip

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.43 **Blender Version** Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-19 06:25, hash: `a5a302bd18` **Short description of error** A high value like 1200 in the resolution viewport in the ocean modifier will crash Blender to desktop. **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] Open Blender. Add a ocean modifier. Type in 1200 in the resolution viewport field. Hit enter. Crash. ![resolutionviewportcrash.jpg](https://archive.blender.org/developer/F9517765/resolutionviewportcrash.jpg) [2020-12-19 12-52-49.mp4](https://archive.blender.org/developer/F9517767/2020-12-19_12-52-49.mp4) The needed files with informations: [blender_system_info.zip](https://archive.blender.org/developer/F9535693/blender_system_info.zip)

Reiner Prokein commented

2020-12-19 12:53:39 +01:00

Added subscriber: @tiles

Robert Guetzkow commented

2020-12-19 18:50:15 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-12-19 18:50:15 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Robert Guetzkow commented

2020-12-19 18:50:15 +01:00

@tiles have you checked if you're running out of memory?

Reiner Prokein commented

2020-12-19 19:32:11 +01:00

Checked now. There is no significant memory increasement. It immediately crashes.

Robert Guetzkow commented

2020-12-29 13:30:49 +01:00

Please open Blender's installation directory and double click on the blender_debug_gpu.cmd. This will start Blender in debug mode and create log files. Try to make Blender crash again. Once it crashes the Windows Explorer should open and show you up to two files, a debug log and the system information. Add them to your bug report by clicking on the upload button as shown in the screenshot below or via drag and drop. Please also upload the crash log located in C:\Users\[your username]\AppData\Local\Temp\[project name].crash.txt (or simply type %TEMP% into the path bar of the Windows Explorer).

Please open Blender's installation directory and double click on the `blender_debug_gpu.cmd`. This will start Blender in debug mode and create log files. Try to make Blender crash again. Once it crashes the Windows Explorer should open and show you up to two files, a debug log and the system information. Add them to your bug report by clicking on the upload button as shown in the screenshot below or via drag and drop. Please also upload the crash log located in `C:\Users\[your username]\AppData\Local\Temp\[project name].crash.txt` (or simply type `%TEMP%` into the path bar of the Windows Explorer). ![2019_12_04_upload_icon_developer_blender_org.png](https://archive.blender.org/developer/F8190038/2019_12_04_upload_icon_developer_blender_org.png)

Reiner Prokein commented

2020-12-29 13:50:23 +01:00

Sure. I have updated the task and attached the files in the initial post. See blender_system_info.zip :)

Robert Guetzkow commented

2020-12-29 13:58:50 +01:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Germano Cavalcante commented

2020-12-30 16:29:33 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-12-30 16:29:33 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-12-30 16:29:33 +01:00

The problem starts with an arithmetic overflow where the result of the operations is being cast to a size smaller than the real one.
The arithmetic overflow can be resolved with:

diff --git a/source/blender/blenkernel/intern/ocean.c b/source/blender/blenkernel/intern/ocean.c
index 1d62a1cce2a..034e8040a87 100644
--- a/source/blender/blenkernel/intern/ocean.c
+++ b/source/blender/blenkernel/intern/ocean.c
@@ -864,9 +864,10 @@ void BKE_ocean_init(struct Ocean *o,
   o->_do_chop = do_chop;
   o->_do_jacobian = do_jacobian;
 
-  o->_k = (float *)MEM_mallocN(M * (1 + N / 2) * sizeof(float), "ocean_k");
-  o->_h0 = (fftw_complex *)MEM_mallocN(M * N * sizeof(fftw_complex), "ocean_h0");
-  o->_h0_minus = (fftw_complex *)MEM_mallocN(M * N * sizeof(fftw_complex), "ocean_h0_minus");
+  o->_k = (float *)MEM_mallocN((size_t)M * (1 + (size_t)N / 2) * sizeof(float), "ocean_k");
+  o->_h0 = (fftw_complex *)MEM_mallocN((size_t)M * (size_t)N * sizeof(fftw_complex), "ocean_h0");
+  o->_h0_minus = (fftw_complex *)MEM_mallocN((size_t)M * (size_t)N * sizeof(fftw_complex),
+                                             "ocean_h0_minus");
   o->_kx = (float *)MEM_mallocN(o->_M * sizeof(float), "ocean_kx");
   o->_kz = (float *)MEM_mallocN(o->_N * sizeof(float), "ocean_kz");

But that does not solve the problem, since the amount of memory required is extremely high. Thus the malloc returns NULL.

Although we do not handle memory problems, this crash can be quite inconvenient, and this case does not appear to be something complicated to solve (perhaps it can be solved by limiting the maximum value).

So I'm confirming it as a bug.

The problem starts with an arithmetic overflow where the result of the operations is being cast to a size smaller than the real one. The arithmetic overflow can be resolved with: ``` diff --git a/source/blender/blenkernel/intern/ocean.c b/source/blender/blenkernel/intern/ocean.c index 1d62a1cce2a..034e8040a87 100644 --- a/source/blender/blenkernel/intern/ocean.c +++ b/source/blender/blenkernel/intern/ocean.c @@ -864,9 +864,10 @@ void BKE_ocean_init(struct Ocean *o, o->_do_chop = do_chop; o->_do_jacobian = do_jacobian; - o->_k = (float *)MEM_mallocN(M * (1 + N / 2) * sizeof(float), "ocean_k"); - o->_h0 = (fftw_complex *)MEM_mallocN(M * N * sizeof(fftw_complex), "ocean_h0"); - o->_h0_minus = (fftw_complex *)MEM_mallocN(M * N * sizeof(fftw_complex), "ocean_h0_minus"); + o->_k = (float *)MEM_mallocN((size_t)M * (1 + (size_t)N / 2) * sizeof(float), "ocean_k"); + o->_h0 = (fftw_complex *)MEM_mallocN((size_t)M * (size_t)N * sizeof(fftw_complex), "ocean_h0"); + o->_h0_minus = (fftw_complex *)MEM_mallocN((size_t)M * (size_t)N * sizeof(fftw_complex), + "ocean_h0_minus"); o->_kx = (float *)MEM_mallocN(o->_M * sizeof(float), "ocean_kx"); o->_kz = (float *)MEM_mallocN(o->_N * sizeof(float), "ocean_kz"); ``` But that does not solve the problem, since the amount of memory required is extremely high. Thus the malloc returns `NULL`. Although we do not handle memory problems, this crash can be quite inconvenient, and this case does not appear to be something complicated to solve (perhaps it can be solved by limiting the maximum value). So I'm confirming it as a bug.

Reiner Prokein commented

2020-12-30 18:02:45 +01:00

It is indeed inconvenient. I had 20 in the box as a value, tried to type in 21 in a hurry, and ended in 2021. The next thing i saw was my desktop.

Maybe this maximum value can be coupled to a setting, maximum available ram for example. So that people with more ram can use higher values here.

It is indeed inconvenient. I had 20 in the box as a value, tried to type in 21 in a hurry, and ended in 2021. The next thing i saw was my desktop. Maybe this maximum value can be coupled to a setting, maximum available ram for example. So that people with more ram can use higher values here.

Robert Guetzkow commented

2020-12-31 13:39:36 +01:00

Just as a reminder, we have a similar problems with other modifiers as well. This should likely be addressed in a consistent way for all modifiers.

blender-admin commented

2021-08-04 09:18:21 +02:00

This issue was referenced by 218df99410

This issue was referenced by 218df9941097bf973485ac343c070bdc6641a539

Campbell Barton commented

2021-08-04 10:31:22 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2021-08-04 10:31:22 +02:00

Campbell Barton self-assigned this 2021-08-04 10:31:22 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash to desktop with too high number in the ocean modifier resolution viewport value #83952