Point light missing draw update after linking object data #84302
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#84302
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71
Blender Version
Broken: version:
0f45cab862Worked: Never (in previous versions the radius didn't disappear from the viewport drawing, it just displayed the old one)
Short description of error
When I link object data from one point light to another it transfers wrong data (all to zero visually or no change) and updates only when I move point light.
Exact steps for others to reproduce the error
2021-01-01_09-12-40.mp4
PL late.blend
Added subscriber: @Vyach
Point light late/wrong uptate after linking object datato Point light missing draw update after linking object dataAdded subscriber: @rjg
Changed status from 'Needs Triage' to: 'Confirmed'
The
make_links_data_exectags the geometry for an update throughDEG_id_tag_update(&ob_dst->id, ID_RECALC_GEOMETRY);when selecting Object Data (MAKE_LINKS_OBDATA), which is not enough to update for the cases demonstrated in the video.Adding
ID_RECALC_TRANSFORMappears to fix the issue.Added subscriber: @JulianEisel
Doesn't seem like a UI issue to me. Either depsgraph or #data_assets_i_o I think. Apparently the depsgraph is part of the #nodes_physics module, so assigning that.
Added subscriber: @dfelinto
Depsgraph is part of Core nowadays. @rjg if you got anywhere with your proposed fix, please submit as a patch. Letting the core module handle the classification here.
Added subscribers: @Sergey, @dr.sybren, @mont29
Guess this is something for @dr.sybren or @Sergey, to me it looks a bit weird to have to add
ID_RECALC_TRANSFORMwhen obdata changes? On the other hand, lights are not exactly geometry...It is one of those cases where we do not have a good existing recalc flag, and
ID_RECALC_COPY_ON_WRITEis ok to be used. If theID_RECALC_COPY_ON_WRITEcan indeed be used here to fix the issue, use it instead ofID_RECALC_TRANSFORM.@dfelinto I will test this again with the
ID_RECALC_COPY_ON_WRITEflag and add a patch if this solves the issue.I've tried to reproduce the issue again, but this appear to be working fine now in the following versions:
a74a267767706f57583ab1b3431f640570801784)It does not work in:
So the actual cause for the missing draw update appears to be fixed since 3.0.0 without changing the flag in
make_links_data_exec. I do not know what change this was though, in case we want to backport this to 2.93 LTS.Is anyone still able to reproduce this in current versions of Blender (excluding 2.93 LTS)?
Changed status from 'Confirmed' to: 'Resolved'
If it is working in master, let's close. It seems a too small of a bug to be ported to LTS as well.