Operating system: Linux-5.10.0-1-amd64-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.27.04
Broken: version: 2.92.0 Beta, branch: master, commit date: 2021-01-13 23:55, hash: rB5804bf25bdfe
Worked: 2.79, all local builds (all the way up to the latest master)
Short description of error
Movie clip editor is using wrong icon in the space menu.
Exact steps for others to reproduce the error
- Download Blender from buildbot
- Open space menu
- Observe icon of the clip editor (it is supposed to be shot clicky thing, not a crosshair)
It is caused by multiple .dat files in the icons folder defining image for the clip editor's icon. The files are traversed in an undefined order (since readdir does not perform any sorting), this is why buildbot behaves different from local builds.
The check against icons conflicts was implemented in D9715, but the check can not go in since it will break builds, because icons are already in an inconsistent state.
Rebuilding icons also turns out to be not so trivial, as there seems to be inconsistency between icons defined in the UI_icons.h header and editors/datafiles/CMakeLists.txt files.