Blenderkit: JSON file opened twice for writing #84778

New Issue

Robert Guetzkow · 2021-01-16T14:01:19+01:00

Robert Guetzkow commented

2021-01-16 14:01:19 +01:00

Blender Version
Broken: version: 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: blender/blender@0f45cab862

Addon Information
Name: BlenderKit Online Asset Library (1, 0, 32)
Author: Vilem Duha, Petr Dlouhy

Short description of error
The function save_prefs contains the following code:

            f = open(fpath, 'w')
            with open(fpath, 'w') as s:
                json.dump(prefs, s)

The first open is redundant and leaves a file handle open that isn't closed.

Exact steps for others to reproduce the error

Take a look at the source code

**Blender Version** Broken: version: 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: `blender/blender@0f45cab862` **Addon Information** Name: BlenderKit Online Asset Library (1, 0, 32) Author: Vilem Duha, Petr Dlouhy **Short description of error** The function `save_prefs` contains the following code: ``` f = open(fpath, 'w') with open(fpath, 'w') as s: json.dump(prefs, s) ``` The first open is redundant and leaves a file handle open that isn't closed. **Exact steps for others to reproduce the error** # Take a look at the source code

Robert Guetzkow commented

2021-01-16 14:01:19 +01:00

Added subscriber: @rjg