ID (e.g. Material) search spammed with (long) file name info, ID name itself then missing #84795

Closed
opened 2021-01-17 10:20:11 +01:00 by Vanessa Dannenberg · 7 comments

System Information
Operating system: Linux-5.9.16-200.fc33.x86_64-x86_64-with-fedora-33-Thirty_Three 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.45.01

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-01-17 11:35, hash: 4ef0654449
Broken: version: 2.90
Worked: 2.83.x

Caused by d62bbf4079

In 2.83.x and prior, when I switched to an object's Materials tab, and clicked the dropdown to add a material to the selected object, it would of course show the list of materials, and typing something in to search for a specific thing, such as "blue", would reduce the list to just the few things bearing that term. This is just like it should act.

Each item in the displayed list consisted of the material name followed by the name of the file it was linked in from, truncated in the middle to make both visible in part... but now, in 2.91.0, it only shows me the name of the file the material is linked from, but not the name of the material itself

For example, here's the materials list from one of my projects, linked in from a separate file since i use them in a lot of other projects, as displayed by 2.83.5:

Screenshot_2021-01-17_04-03-06.png

Type something in:

Screenshot_2021-01-17_04-03-46.png

Same project file, substantially the same materials, but now as displayed in 2.91.0:

Screenshot_2021-01-17_03-59-20.png

Type something in:

Screenshot_2021-01-17_03-59-45.png

As you can see, the material names are completely absent from the display, though the search clearly includes them. Since the material names aren't shown anymore, the displayed list is now basically useless. :-(

In Debug builds, an assert is triggered

BLI_assert failed: source/blender/editors/interface/interface_widgets.c:1689, UI_text_clip_middle_ex(), at 'strwidth <= okwidth'
**System Information** Operating system: Linux-5.9.16-200.fc33.x86_64-x86_64-with-fedora-33-Thirty_Three 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.45.01 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-01-17 11:35, hash: `4ef0654449` Broken: version: 2.90 Worked: 2.83.x Caused by d62bbf4079 In 2.83.x and prior, when I switched to an object's Materials tab, and clicked the dropdown to add a material to the selected object, it would of course show the list of materials, and typing something in to search for a specific thing, such as "blue", would reduce the list to just the few things bearing that term. This is just like it should act. Each item in the displayed list consisted of the material name followed by the name of the file it was linked in from, truncated in the middle to make both visible in part... but now, in 2.91.0, it only shows me the name of the file the material is linked from, but not the name of the material itself For example, here's the materials list from one of my projects, linked in from a separate file since i use them in a lot of other projects, as displayed by 2.83.5: ![Screenshot_2021-01-17_04-03-06.png](https://archive.blender.org/developer/F9582875/Screenshot_2021-01-17_04-03-06.png) Type something in: ![Screenshot_2021-01-17_04-03-46.png](https://archive.blender.org/developer/F9582877/Screenshot_2021-01-17_04-03-46.png) Same project file, substantially the same materials, but now as displayed in 2.91.0: ![Screenshot_2021-01-17_03-59-20.png](https://archive.blender.org/developer/F9582866/Screenshot_2021-01-17_03-59-20.png) Type something in: ![Screenshot_2021-01-17_03-59-45.png](https://archive.blender.org/developer/F9582867/Screenshot_2021-01-17_03-59-45.png) As you can see, the material names are completely absent from the display, though the search clearly includes them. Since the material names aren't shown anymore, the displayed list is now basically useless. :-( In Debug builds, an assert is triggered ``` BLI_assert failed: source/blender/editors/interface/interface_widgets.c:1689, UI_text_clip_middle_ex(), at 'strwidth <= okwidth' ```

Added subscriber: @VanessaE

Added subscriber: @VanessaE
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

It even asserts:

BLI_assert failed: source/blender/editors/interface/interface_widgets.c:1689, UI_text_clip_middle_ex(), at 'strwidth <= okwidth'

Will check on this.

It even asserts: ``` BLI_assert failed: source/blender/editors/interface/interface_widgets.c:1689, UI_text_clip_middle_ex(), at 'strwidth <= okwidth' ``` Will check on this.
Philipp Oeser changed title from Material search spammed with file name info, now unusable to ID (e.g. Material) search spammed with (long) file name info, ID name itself then missing 2021-01-18 11:12:43 +01:00
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Member

This is a known ToDo, #84188 (Avoid clipping data-block name in data-block menu because of library name). For the release we can do a fix to just clip the middle of the hint, rather than the main text.
The implementation prior to d62bbf4079 didn't deal with this well either, although it was a bit better then. Issue is that the current implementation always clips the text over the grayed out hint, which may make sense for menu shortcuts, but not here.

Don't think this should be high-priority, the library names have to be quite long for this.
The assert is a new issue though, I guess that just signals that the hint is wider than the available width. I'd treat that as a separate issue.

This is a known ToDo, #84188 (Avoid clipping data-block name in data-block menu because of library name). For the release we can do a fix to just clip the middle of the hint, rather than the main text. The implementation prior to d62bbf4079 didn't deal with this well either, although it was a bit better then. Issue is that the current implementation always clips the text over the grayed out hint, which may make sense for menu shortcuts, but not here. Don't think this should be high-priority, the library names have to be quite long for this. The assert is a new issue though, I guess that just signals that the hint is wider than the available width. I'd treat that as a separate issue.
Member

Closed as duplicate of #84188

Closed as duplicate of #84188
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#84795
No description provided.