Page MenuHome

Particle Edit Comb Box Select tool wrongly show Comb tool settings
Closed, ResolvedPublicBUG

Description

System Information
Operating system: Darwin-20.2.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 5500M OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.2.13

Blender Version
Broken: version: 2.93.0 Alpha, branch: master (modified), commit date: 2021-01-16 09:28, hash: rB79dd9fedb242
Worked: N/A

Short description of error
Particle Edit Comb Box Select tool wrongly show Comb tool settings (actually the settings from the last selected brush-based tool)

See here:


Box Select tool is selected, but the Comb tool settings are shown.

Exact steps for others to reproduce the error

  1. With the default cube selected, add some hair particles in the Particles Properties
  2. Switch to Particle Edit Mode
  3. Make sure the Box Select tool is enabled
  4. In the Properties, switch to the Tool Settings tab

You'll see settings from the Comb tool even though it's not the active tool.

Event Timeline

I tested the following builds on Windows and couldn't reproduce this issue:

  • 2.93.0 Alpha, branch: master, commit date: 2021-01-17 07:30, hash: rB14bb9f09ab98
  • 2.93.0 Alpha, branch: master, commit date: 2021-01-16 09:28, hash: rB79dd9fedb242
  • 2.93.0 Alpha, branch: master, commit date: 2021-01-15 00:04, hash: rB10ce2a1016ae
  • 2.92.0 Beta, branch: master, commit date: 2021-01-14 20:13, hash: rB30dd31a7b3d8

You probably have already checked this, but since your build appears to be a modified version of the master branch (according to the version string), have you ruled out that the modification causes the problem?

Robert Guetzkow (rjg) changed the task status from Needs Triage to Needs Information from User.Jan 17 2021, 11:47 AM

@Robert Guetzkow (rjg)

Yes, I also get this bug in all versions going back to 2.80.
Updated the description.

In 2.91 official I also see this:

Robert Guetzkow (rjg) changed the task status from Needs Information from User to Confirmed.Jan 17 2021, 1:52 PM

Seems like I need some glasses. It does indeed show the Radius and Strength, but shows Select Box at the top.

Campbell Barton (campbellbarton) changed the subtype of this task from "Report" to "Bug".Jan 19 2021, 5:13 AM

I will try to solve the problem.

I think the problem is not really a user interface issue, the particle modes are not escaped when changing to regular tools (cursor/selector)
It is visible when entering weight tool, and then entering select/cursor tool.
I think the specific tools of the particle stay even after changing tool.
It may cause the issue with the Active tool panel (right)

Actually testing with 2.93 master.

What I did is just copying some lines from release/scripts/startup/bl_ui/properties_paint_common.py :

from bl_ui.space_toolsystem_common import ToolSelectPanelHelper
tool = ToolSelectPanelHelper.tool_active_from_context(context)

if not tool:
    # If there is no active tool, then there can't be an active brush.
    return None

if not tool.has_datablock:
    # tool.has_datablock is always true for tools that use brushes.
    return None

I found that the brush system is a bit strange. When tool is selected ( not brush), the latest brush stay in the background. This is causing the issue with the weight mode. I really do not know why the brush is not just empty name when no brush selected :
Actually :
Particle mode :


Sculpt mode :

And the results should be :
'' for the particle tool name
Empty or "None" for the sculpt brush

Is this a bug or a functionality ?