"Lock to Selection" in Clip Editor messes up Mask Editing #84850

Closed
opened 2021-01-19 07:27:18 +01:00 by Sebastian Koenig · 7 comments

System Information
Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GeForce RTX 2070 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.38

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-01-19 02:36, hash: 94e9d3ca3e
Worked: never

Short description of error
This is actually a very old issue and I feel embarassed not to have reported it earlier.
In theory it should be very easy to fix as well.

During tracking it is very common to lock the view (ar actually the clip) to the active marker (with "L", or by enabling "Lock to selection" in the header). The problem is that when you switch to Mask mode Blender tries to lock the clip not to the active marker but to the active element (I guess), which will now be the mask point. So when you Ctrl-click anywhere to add a marker, the clip will jump around, because it will try to lock to the very element you are moving at the same time.

One solution would be to simply allow "Lock to Selection" only when the clip editor is in Track mode, but I think for masking and roto it would be quite nice to have the view locked to a particular marker, especially when you parent the mask to that marker.
So lock the view not to the active element, but to the active marker.

Exact steps for others to reproduce the error
To test the issue just open the attached file and try to add a mask point by Ctrl-clicking. The clip (even when footage is not found) should start jumping around like crazy. clip_mask_locked.blend

**System Information** Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: GeForce RTX 2070 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.38 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-01-19 02:36, hash: `94e9d3ca3e` Worked: never **Short description of error** This is actually a very old issue and I feel embarassed not to have reported it earlier. In theory it should be very easy to fix as well. During tracking it is very common to lock the view (ar actually the clip) to the active marker (with "L", or by enabling "Lock to selection" in the header). The problem is that when you switch to Mask mode Blender tries to lock the clip not to the active marker but to the active element (I guess), which will now be the mask point. So when you Ctrl-click anywhere to add a marker, the clip will jump around, because it will try to lock to the very element you are moving at the same time. One solution would be to simply allow "Lock to Selection" only when the clip editor is in Track mode, but I think for masking and roto it would be quite nice to have the view locked to a particular marker, especially when you parent the mask to that marker. So lock the view not to the active element, but to the active marker. **Exact steps for others to reproduce the error** To test the issue just open the attached file and try to add a mask point by Ctrl-clicking. The clip (even when footage is not found) should start jumping around like crazy. [clip_mask_locked.blend](https://archive.blender.org/developer/F9586839/clip_mask_locked.blend)
Author
Member

Added subscriber: @sebastian_k

Added subscriber: @sebastian_k
Sergey Sharybin was assigned by Sebastian Koenig 2021-01-19 07:28:53 +01:00

Think the lock-to-selection for mask points was explicitly implemented, so that you can more easily see what's going on when zoomed in and scrubbing. The behavior is actually (annoyingly) consistent with the tracking mode: Ctrl-Click to create new marker will make view to jump.

My guess is the proper behavior is to keep lock-to-selection, but keep offset so that the view is not jumping (as if when you enable lock, and pan the view around). You fine with this solution?

Think the lock-to-selection for mask points was explicitly implemented, so that you can more easily see what's going on when zoomed in and scrubbing. The behavior is actually (annoyingly) consistent with the tracking mode: Ctrl-Click to create new marker will make view to jump. My guess is the proper behavior is to keep lock-to-selection, but keep offset so that the view is not jumping (as if when you enable lock, and pan the view around). You fine with this solution?

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

In #84850#1096264, @Sergey wrote:

My guess is the proper behavior is to keep lock-to-selection, but keep offset so that the view is not jumping (as if when you enable lock, and pan the view around). You fine with this solution?

Yeah, this might work. If I select a new marker, would the view jump there or would it keep the offset? (I'd prefer the latter ;)

> In #84850#1096264, @Sergey wrote: > My guess is the proper behavior is to keep lock-to-selection, but keep offset so that the view is not jumping (as if when you enable lock, and pan the view around). You fine with this solution? Yeah, this might work. If I select a new marker, would the view jump there or would it keep the offset? (I'd prefer the latter ;)

Currently selection will make view to jump. But indeed selection should also preserve the view.

Currently selection will make view to jump. But indeed selection should also preserve the view.

This issue was referenced by 66f8835f9c

This issue was referenced by 66f8835f9c03e7736297b5995a68e1455ed14e2a

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#84850
No description provided.