Expanded enums now always draw center aligned (was left aligned) #84869

Closed
opened 2021-01-19 19:20:56 +01:00 by Eugene Du · 12 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1650 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.51

Blender Version
Broken: version: 2.92.0 Beta, branch: master, commit date: 2021-01-18 17:08, hash: b5c3f26cba
Worked: 2.91

7ee518cf70: Fix #80313: Fix clipped text in splash screen on hiDPI monitors

Short description of error
Before 2.92 all buttons which drawing with

cbox.prop_enum()

looked like this pie 2.91 small.png
In 2.92 they look like this
pie 2.92 small.png
seems now texts in prop_enum aligning at the middle of the buttons.

With

cbox.operator()

all fine, text aligned to the left of the buttons
pie 2.92 example.png

To check, one can for example spawn the Extra Shading Pie menu {key Z}

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1650 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.51 **Blender Version** Broken: version: 2.92.0 Beta, branch: master, commit date: 2021-01-18 17:08, hash: `b5c3f26cba` Worked: 2.91 7ee518cf70: Fix #80313: Fix clipped text in splash screen on hiDPI monitors **Short description of error** Before 2.92 all buttons which drawing with ``` cbox.prop_enum() ``` looked like this ![pie 2.91 small.png](https://archive.blender.org/developer/F9587993/pie_2.91_small.png) In 2.92 they look like this ![pie 2.92 small.png](https://archive.blender.org/developer/F9587997/pie_2.92_small.png) seems now texts in prop_enum aligning at the middle of the buttons. With ``` cbox.operator() ``` all fine, text aligned to the left of the buttons ![pie 2.92 example.png](https://archive.blender.org/developer/F9588006/pie_2.92_example.png) To check, one can for example spawn the Extra Shading Pie menu {key Z}
Author

Added subscriber: @APEC

Added subscriber: @APEC
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Can confirm the behavior changed, will bisect when this happened (this might very well be an intentional change.

Can confirm the behavior changed, will bisect when this happened (this might very well be an intentional change.
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Member

Caused by 7ee518cf70

@JulianEisel: what to do now?

Caused by 7ee518cf70 @JulianEisel: what to do now?
Philipp Oeser changed title from cbox.prop_enum() drawing changed in 2.92 to Expanded enums now always draw center aligned (was left aligned) 2021-01-20 14:08:14 +01:00
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

Thanks for the report. It looks like D9854 might be related?

Thanks for the report. It looks like [D9854](https://archive.blender.org/developer/D9854) might be related?
Member

Regression and should be fixed for the release.

Regression and should be fixed for the release.
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Julian Eisel self-assigned this 2021-02-19 19:07:38 +01:00
Member

Reverted the breaking commit, b1142858d4.

Reverted the breaking commit, b1142858d4ca.

This issue was referenced by cab26abbdb

This issue was referenced by cab26abbdb07fd43cd85d1decf4859f11055e484
Thomas Dinges added this to the 2.92 milestone 2023-02-08 16:14:51 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#84869
No description provided.