Crash editing properties #85291

New Issue

Daniel Salazar · 2021-02-01T21:00:06+01:00

Daniel Salazar commented

2021-02-01 21:00:06 +01:00

System Information
Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.32.03

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-01 16:28, hash: 59054d906f
Worked: (newest version of Blender that worked as expected)

Short description of error
Changing the render and viewport samples in cycles crashes

Exact steps for others to reproduce the error

Download the attached file (from #85304, thanks to @SimonThommes)
Use for a bit, the file should crash shortly

fire_test_1.blend

Original description:
I'm getting a crash while on workbench viewport just by changing the cycles samples number.

Note: Currently working on producing a test file since this happens on complex linked production files

Reproducible both in win and lin

hash: 59054d906f

Thread 1 "blender" received signal SIGSEGV, Segmentation fault.
0x000000000e3f4e33 in ghash_keyhash (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:148
148	  return gh->hashfp(key);
(gdb) bt
- 0  0x000000000e3f4e33 in ghash_keyhash (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:148
- 1  ghash_lookup_entry (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:427
- 2  BLI_ghash_lookup (gh=0x0, key=0x7fffffffcf50) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:805
- 3  0x000000000357fe5d in BKE_scene_get_depsgraph (scene=0x7fff4f3f3808, view_layer=0x7fff6f079b08)
    at /home/zanqdo/Software/blender-git/blender/source/blender/blenkernel/intern/scene.c:3462
- 4  0x0000000003d1b1e6 in DRW_cache_free_old_batches (bmain=0x7fffc7a7e708) at /home/zanqdo/Software/blender-git/blender/source/blender/draw/intern/draw_manager.c:994
- 5  0x0000000004c79c5d in view3d_main_region_draw (C=0x7ffff4710f88, region=0x7fffab5e1988)
    at /home/zanqdo/Software/blender-git/blender/source/blender/editors/space_view3d/view3d_draw.c:1626
- 6  0x0000000004522c9e in ED_region_do_draw (C=0x7ffff4710f88, region=0x7fffab5e1988) at /home/zanqdo/Software/blender-git/blender/source/blender/editors/screen/area.c:558
- 7  0x0000000003a231f8 in wm_draw_window_offscreen (C=0x7ffff4710f88, win=0x7fffaee67208, stereo=false)
    at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:731
- 8  0x0000000003a237b9 in wm_draw_window (C=0x7ffff4710f88, win=0x7fffaee67208) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:872
- 9  0x0000000003a23e05 in wm_draw_update (C=0x7ffff4710f88) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:1073
- 10 0x0000000003a203b2 in WM_main (C=0x7ffff4710f88) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm.c:643
- 11 0x0000000003404bd5 in main (argc=1, argv=0x7fffffffdf38) at /home/zanqdo/Software/blender-git/blender/source/creator/creator.c:522

Log file from merged ticket #85272
AM60_BRBI33.crash.txt
blender_debug_output.txt
blender_system_info.txt

**System Information** Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.32.03 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-01 16:28, hash: `59054d906f` Worked: (newest version of Blender that worked as expected) **Short description of error** Changing the render and viewport samples in cycles crashes **Exact steps for others to reproduce the error** - Download the attached file (from #85304, thanks to @SimonThommes) - Use for a bit, the file should crash shortly [fire_test_1.blend](https://archive.blender.org/developer/F9608825/fire_test_1.blend) ----- Original description: I'm getting a crash while on workbench viewport just by changing the cycles samples number. Note: Currently working on producing a test file since this happens on complex linked production files Reproducible both in win and lin hash: `59054d906f` ``` Thread 1 "blender" received signal SIGSEGV, Segmentation fault. 0x000000000e3f4e33 in ghash_keyhash (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:148 148 return gh->hashfp(key); (gdb) bt - 0 0x000000000e3f4e33 in ghash_keyhash (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:148 - 1 ghash_lookup_entry (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:427 - 2 BLI_ghash_lookup (gh=0x0, key=0x7fffffffcf50) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:805 - 3 0x000000000357fe5d in BKE_scene_get_depsgraph (scene=0x7fff4f3f3808, view_layer=0x7fff6f079b08) at /home/zanqdo/Software/blender-git/blender/source/blender/blenkernel/intern/scene.c:3462 - 4 0x0000000003d1b1e6 in DRW_cache_free_old_batches (bmain=0x7fffc7a7e708) at /home/zanqdo/Software/blender-git/blender/source/blender/draw/intern/draw_manager.c:994 - 5 0x0000000004c79c5d in view3d_main_region_draw (C=0x7ffff4710f88, region=0x7fffab5e1988) at /home/zanqdo/Software/blender-git/blender/source/blender/editors/space_view3d/view3d_draw.c:1626 - 6 0x0000000004522c9e in ED_region_do_draw (C=0x7ffff4710f88, region=0x7fffab5e1988) at /home/zanqdo/Software/blender-git/blender/source/blender/editors/screen/area.c:558 - 7 0x0000000003a231f8 in wm_draw_window_offscreen (C=0x7ffff4710f88, win=0x7fffaee67208, stereo=false) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:731 - 8 0x0000000003a237b9 in wm_draw_window (C=0x7ffff4710f88, win=0x7fffaee67208) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:872 - 9 0x0000000003a23e05 in wm_draw_update (C=0x7ffff4710f88) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:1073 - 10 0x0000000003a203b2 in WM_main (C=0x7ffff4710f88) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm.c:643 - 11 0x0000000003404bd5 in main (argc=1, argv=0x7fffffffdf38) at /home/zanqdo/Software/blender-git/blender/source/creator/creator.c:522 ``` --- Log file from merged ticket #85272 [AM60_BRBI33.crash.txt](https://archive.blender.org/developer/F9607500/AM60_BRBI33.crash.txt) [blender_debug_output.txt](https://archive.blender.org/developer/F9607517/blender_debug_output.txt) [blender_system_info.txt](https://archive.blender.org/developer/F9607518/blender_system_info.txt)

Daniel Salazar commented

2021-02-01 21:00:06 +01:00

Added subscriber: @zanqdo

blender-admin commented

2021-02-01 21:00:06 +01:00

#85304 was marked as duplicate of this issue

blender-admin commented

2021-02-01 21:00:06 +01:00

#85272 was marked as duplicate of this issue

Daniel Salazar changed title from ~~Crash editing render properties~~ to Crash editing properties

2021-02-01 22:04:32 +01:00

Robert Guetzkow commented

2021-02-01 22:23:21 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2021-02-01 22:23:21 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Robert Guetzkow commented

2021-02-01 22:23:21 +01:00

I was unable to reproduce this on both Windows and Linux. As already mentioned in the discussion on blender.chat , since this only appears to happen in particular project files we would need a minimal example project that allows us to reproduce the problem.

If you want to investigate this yourself, I would suggest you create a developer build on Linux with ASAN. This should allow you to catch potential issues early on.

Should you really be unable to create a shareable project that demonstrates the issue, please try to bisect the commit that introduced the problem.

I was unable to reproduce this on both Windows and Linux. As already mentioned in the discussion on [blender.chat ](https://blender.chat/channel/blender-coders), since this only appears to happen in particular project files we would need a minimal example project that allows us to reproduce the problem. If you want to investigate this yourself, I would suggest you create a developer build on Linux with ASAN. This should allow you to catch potential issues early on. Should you really be unable to create a shareable project that demonstrates the issue, please try to bisect the commit that introduced the problem.

Robert Guetzkow commented

2021-02-01 22:29:07 +01:00

Added subscriber: @RainerTrummer

Robert Guetzkow commented

2021-02-01 22:42:56 +01:00

@RainerTrummer Based on the stack trace you are experiencing the same issue. Please try to find a minimal example project as well. You are likely able to remove most objects since they won't all be relevant to the issue and perhaps this would allow you to share the file.

Robert Guetzkow commented

2021-02-01 22:45:31 +01:00

Added subscriber: @brecht

Robert Guetzkow commented

2021-02-01 22:45:31 +01:00

@brecht it seems the recent changes made to BKE_scene_get_depsgraph in 087777f2b9 could have caused this (or revealed another issue that existed before).

@brecht it seems the recent changes made to `BKE_scene_get_depsgraph` in 087777f2b9 could have caused this (or revealed another issue that existed before).

Robert Guetzkow commented

2021-02-02 10:42:35 +01:00

Added subscriber: @SimonThommes

Sergey Sharybin commented

2021-02-02 10:52:58 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2021-02-02 10:52:58 +01:00

The null pointer check should have been fixed in 30ac21bf33.

The null pointer check should have been fixed in 30ac21bf33.

Falk David commented

2021-02-02 10:57:46 +01:00

Added subscriber: @filedescriptor

Falk David commented

2021-02-02 10:57:46 +01:00

@Sergey looks like that commit has been committed to the release branch but not to master.

Robert Guetzkow commented

2021-02-02 11:05:15 +01:00

@filedescriptor ~~It's in master with the referenced hash, but it doesn't solve the issue from this ticket.~~ 2.93.0 Alpha, branch: master, commit date: 2021-02-02 08:36, hash: 356c62fe32

@filedescriptor ~~It's in master with the referenced hash, but it doesn't solve the issue from this ticket.~~ 2.93.0 Alpha, branch: master, commit date: 2021-02-02 08:36, hash: `356c62fe32`

Sergey Sharybin commented

2021-02-02 11:12:58 +01:00

The commit itself is in master branch indeed, but the code is not. Not sure how that is possible, so I've re-committed the fix from Clement in master again (d19aaad0bc).

The commit itself is in master branch indeed, but the code is not. Not sure how that is possible, so I've re-committed the fix from Clement in master again (d19aaad0bc).

Rainer Trummer commented

2021-02-02 11:44:25 +01:00

Can confirm this fixed the crashes for me. Not sure about @zanqdo

Robert Guetzkow commented

2021-02-02 12:03:18 +01:00

That fixes the issue indeed, which seems obvious given the stack trace. Strange, looks like something went wrong with the original merge 9c244820d1.

That fixes the issue indeed, which seems obvious given the stack trace. Strange, looks like something went wrong with the original merge 9c244820d1.

Robert Guetzkow commented

2021-02-02 12:03:52 +01:00

Changed status from 'Needs User Info' to: 'Resolved'

Robert Guetzkow closed this issue

2021-02-02 12:03:52 +01:00

Robert Guetzkow self-assigned this 2021-02-02 12:03:52 +01:00

Daniel Salazar commented

2021-02-02 20:23:18 +01:00

Thanks guys, I was trying to produce a crash file but it was very difficult since it kept crashing on save xD

cheers!

Thanks guys, I was trying to produce a crash file but it was very difficult since it kept crashing on save xD cheers!

Sergey Sharybin commented

2021-02-03 09:55:33 +01:00

@zanqdo, is the crash on save reported as a bug?

Daniel Salazar commented

2021-02-04 08:08:12 +01:00

In #85291#1106237, @Sergey wrote:
@zanqdo, is the crash on save reported as a bug?

I think it was the same bug! Does not crash now

> In #85291#1106237, @Sergey wrote: > @zanqdo, is the crash on save reported as a bug? I think it was the same bug! Does not crash now

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash editing properties #85291