Page MenuHome
Create Task
Maniphest T85368

Fix Map Range node Clamp functionality
Closed, ResolvedPublicTO DO
Actions

Description

The clamp functionality of the map range node is currently not behaving as both what the shader node version does and what the tooltip says.
It should clamp the output to the set To range. Currently it is clamping to [0,1].

Revisions and Commits

rB Blender
D10324rBbb0b250cbded Fix T85368: map range node clamps incorrectly in geometry nodes

Related Objects

Event Timeline

Simon Thommes (simonthommes) changed the task status from Needs Triage to Confirmed.Thu, Feb 4, 12:48 PM
Simon Thommes (simonthommes) created this task.
Dalai Felinto (dfelinto) added a project: Good First Issue.Thu, Feb 4, 2:08 PM
Sam Miller (samuelmiller) added a subscriber: Sam Miller (samuelmiller).Thu, Feb 4, 8:02 PM

I'd like to help with this, but I'm a little confused. Is this for the composite Map Range node? I can't find a Map Range node in the Geometry nodes source code, although it's in the manual.

Leon Leno (lone_noel) added a subscriber: Leon Leno (lone_noel).Fri, Feb 5, 8:54 AM

@Sam Miller (samuelmiller) Some of the nodes are shared between geometry nodes and the shader nodes. Maybe take a look at node_shader_map_range.cc.

Utkarsh Agarwal (woolllff) added a subscriber: Utkarsh Agarwal (woolllff).Fri, Feb 5, 9:09 AM

can you tell where are we supposed to look at.
and where is it not functioning?

Simon Thommes (simonthommes) updated the task description. (Show Details)Fri, Feb 5, 10:24 AM
Simon Thommes (simonthommes) added subscribers: Hans Goudey (HooglyBoogly), Jacques Lucke (JacquesLucke).

I added a video showcasing that it's not working correctly to the description.

I'm not a developer myself, so I'm not sure where to look in the code.
@Jacques Lucke (JacquesLucke) @Hans Goudey (HooglyBoogly) could one of you guys help out?

Jacques Lucke (JacquesLucke) added a comment.Fri, Feb 5, 10:41 AM

The bug is in the MapRangeFunction class in node_shader_map_range.cc.

Sam Miller (samuelmiller) added a revision: D10324: Fix T85368:Map Range Node Clamp Functionality.Fri, Feb 5, 2:25 PM

I think I found the offending line of code and have submitted a patch. I did a limited test of the functionality and it worked for me.

Sam Miller (samuelmiller) mentioned this in D10324: Fix T85368:Map Range Node Clamp Functionality.Fri, Feb 5, 8:05 PM
Jacques Lucke (JacquesLucke) closed this task as Resolved by committing rBbb0b250cbded: Fix T85368: map range node clamps incorrectly in geometry nodes.Mon, Feb 8, 1:34 PM
Jacques Lucke (JacquesLucke) claimed this task.
Jacques Lucke (JacquesLucke) added a commit: rBbb0b250cbded: Fix T85368: map range node clamps incorrectly in geometry nodes.