Crash on toggle bone layer #85423

New Issue

Roman · 2021-02-06T12:14:19+01:00

Roman commented

2021-02-06 12:14:19 +01:00

System Information
Operating system: OpenSUSE Linux, kernel 5.10.7
Graphics card: intel

Blender Version
Broken: blender-2.92.0-a5637756491c-linux64

Blender crashes when I'm trying to enable bone layer visibility.

Exact steps for others to reproduce the error

Open example file:
rig-bug3.blend
Click on the second rig bone layer:

Result: blender crashes with backtrace:

# Blender 2.92.0, Commit date: 2021-02-05 15:23, Hash a5637756491c
bpy.ops.outliner.item_activate(extend=False, deselect_all=True)  # Operator
bpy.ops.outliner.item_rename()  # Operator
bpy.ops.outliner.orphans_purge(num_deleted=40)  # Operator
Deleted 40 data-block(s)  # Info
bpy.ops.outliner.orphans_purge(num_deleted=10)  # Operator
Deleted 10 data-block(s)  # Info
bpy.ops.outliner.orphans_purge(num_deleted=1)  # Operator
Deleted 1 data-block(s)  # Info
No orphaned data-blocks to purge  # Info
Saved "rig-bug3.blend"  # Info
bpy.context.space_data.context = 'DATA'  # Property
Saved "rig-bug3.blend"  # Info

# backtrace
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(BLI_system_backtrace+0x20) [0x865fd90]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender() [0xeb3a2a]
/lib64/libc.so.6(+0x3d6c0) [0x7ff5377926c0]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(DRW_displist_vertbuf_create_pos_and_nor+0x5e) [0x13d443e]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(DRW_curve_batch_cache_create_requested+0x4ea) [0x13d24ea]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender() [0x85bf76b]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(BLI_ghash_free+0x4e) [0x85c00ee]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender() [0x13840e7]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(DRW_draw_render_loop_ex+0x1ac) [0x138649c]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(view3d_main_region_draw+0x8f) [0x1c0442f]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(ED_region_do_draw+0x7e1) [0x17ab221]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(wm_draw_update+0x52e) [0x123c70e]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(WM_main+0x30) [0x123a5a0]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(main+0x31e) [0xdeb30e]
/lib64/libc.so.6(__libc_start_main+0xea) [0x7ff53777ce0a]
/home/z/soft/blender-2.92.0-a5637756491c-linux64/blender() [0xeb03c3]

**System Information** Operating system: OpenSUSE Linux, kernel 5.10.7 Graphics card: intel **Blender Version** Broken: blender-2.92.0-a5637756491c-linux64 Blender crashes when I'm trying to enable bone layer visibility. **Exact steps for others to reproduce the error** 1) Open example file: [rig-bug3.blend](https://archive.blender.org/developer/F9668444/rig-bug3.blend) 2) Click on the *second* rig bone layer: ![Screenshot-rig-bug.jpeg](https://archive.blender.org/developer/F9668464/Screenshot-rig-bug.jpeg) Result: blender crashes with backtrace: ``` # Blender 2.92.0, Commit date: 2021-02-05 15:23, Hash a5637756491c bpy.ops.outliner.item_activate(extend=False, deselect_all=True) # Operator bpy.ops.outliner.item_rename() # Operator bpy.ops.outliner.orphans_purge(num_deleted=40) # Operator Deleted 40 data-block(s) # Info bpy.ops.outliner.orphans_purge(num_deleted=10) # Operator Deleted 10 data-block(s) # Info bpy.ops.outliner.orphans_purge(num_deleted=1) # Operator Deleted 1 data-block(s) # Info No orphaned data-blocks to purge # Info Saved "rig-bug3.blend" # Info bpy.context.space_data.context = 'DATA' # Property Saved "rig-bug3.blend" # Info # backtrace /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(BLI_system_backtrace+0x20) [0x865fd90] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender() [0xeb3a2a] /lib64/libc.so.6(+0x3d6c0) [0x7ff5377926c0] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(DRW_displist_vertbuf_create_pos_and_nor+0x5e) [0x13d443e] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(DRW_curve_batch_cache_create_requested+0x4ea) [0x13d24ea] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender() [0x85bf76b] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(BLI_ghash_free+0x4e) [0x85c00ee] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender() [0x13840e7] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(DRW_draw_render_loop_ex+0x1ac) [0x138649c] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(view3d_main_region_draw+0x8f) [0x1c0442f] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(ED_region_do_draw+0x7e1) [0x17ab221] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(wm_draw_update+0x52e) [0x123c70e] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(WM_main+0x30) [0x123a5a0] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender(main+0x31e) [0xdeb30e] /lib64/libc.so.6(__libc_start_main+0xea) [0x7ff53777ce0a] /home/z/soft/blender-2.92.0-a5637756491c-linux64/blender() [0xeb03c3] ```

Roman commented

2021-02-06 12:14:19 +01:00

Added subscriber: @rwman

Roman commented

2021-02-06 18:26:56 +01:00

seems to be related to https://developer.blender.org/rBd11a87b88c4d76aff77912313752d23fffc8e65d

Roman commented

2021-02-06 18:31:52 +01:00

The cause seems to be that I set the lower eyelid bone viewport display to the custom curve shape: collection "widgets" -> bottom lash

Falk David commented

2021-02-08 12:17:24 +01:00

Added subscriber: @filedescriptor

Falk David commented

2021-02-08 12:17:24 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Falk David commented

2021-02-08 12:17:24 +01:00

I can reproduce the crash on the latest 2.93.0 Alpha, branch: master, commit date: 2021-02-08 10:36, hash: ecfd5360a1.

I can reproduce the crash on the latest 2.93.0 Alpha, branch: master, commit date: 2021-02-08 10:36, hash: `ecfd5360a1`.

Falk David commented

2021-02-08 12:34:53 +01:00

Debugging this I found that in blender/source/blender/draw/intern/draw_cache_impl_curve.c:1066:

  CurveRenderData *rdata = curve_render_data_create(cu, ob->runtime.curve_cache, mr_flag);

ob->runtime.curve_cache is NULL in this case leading to the crash later on.

Debugging this I found that in `blender/source/blender/draw/intern/draw_cache_impl_curve.c:1066`: ``` CurveRenderData *rdata = curve_render_data_create(cu, ob->runtime.curve_cache, mr_flag); ``` `ob->runtime.curve_cache` is `NULL` in this case leading to the crash later on.

Sybren A. Stüvel commented

2021-07-08 16:23:15 +02:00

Added subscribers: @HooglyBoogly, @dr.sybren

Sybren A. Stüvel commented

2021-07-08 16:23:15 +02:00

This is already fixed in master, by ac833108db. From the look of it, it seems to do more than just fixing this crash, so I'm not sure how easily it would be to extract the fix in a way that's suitable for back-porting to 2.93 LTS. @HooglyBoogly could you give us some insight?

This is already fixed in `master`, by ac833108db. From the look of it, it seems to do more than just fixing this crash, so I'm not sure how easily it would be to extract the fix in a way that's suitable for back-porting to 2.93 LTS. @HooglyBoogly could you give us some insight?

Hans Goudey commented

2021-07-12 14:55:37 +02:00

Since none of the "curve data" mentioned in that commit exists in 2.93, agreed, not sure we can just backport the fix.

My best guess is that in introducing a code path that doesn't rely on ob->runtime.curve_cache, the code just follows a different path and doesn't crash.

Since none of the "curve data" mentioned in that commit exists in 2.93, agreed, not sure we can just backport the fix. My best guess is that in introducing a code path that doesn't rely on `ob->runtime.curve_cache`, the code just follows a different path and doesn't crash.

Sybren A. Stüvel commented

2021-07-12 18:13:03 +02:00

@ rwman do you know of a way to reproduce this issue from scratch? Or do you know a version of Blender in which your file still worked?

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash on toggle bone layer #85423