Proposal to change behavior when the active object is hidden #85532

New Issue

Campbell Barton · 2021-02-11T01:10:40+01:00

Campbell Barton commented

2021-02-11 01:10:40 +01:00

There are currently multiple bugs/inconsistencies when the active object can be hidden while being edited.

The 3D views "active_object" checks visibility, returning NULL when when it's hidden. This has the result of showing the 3D view as being in object-mode when the active object is hidden.

There is an exception to this rule - edit-mode always returns the active object, ignoring the hidden state.

As far as I know, this is mostly a result of incremental tweaks & fixes, not a design decision.

Current Issues

The logic to always be in object-mode with a hidden active object isn't working properly.

When the collection is hidden, the object can be sculpted onto, but when the object is hidden it can't be.
The tool system currently follows the active object, ignoring it's hidden state.
#83013 (Crash when using annotation tool on object hidden in sculpt mode). Note, fixing this isn't so complicated, it's just an example of the current behavior being error prone.

Possible Solutions

Fix the current behavior:

Fully support object mode behavior when the active object in a mode is hidden.

Take into account the hidden state of the collection.
Make the tool system respect the active-objects hidden state, refreshing the tool system on visibility changes.
Make transform logic use contexts active object.

Ignore visibility flag when editing:

While I'm not so keen on this, adding for completeness.
We could ignore the visibility option when the active object isn't in object mode.

Extend the edit-mode exception:

Extend the edit-mode exception to all object editing modes.

When in object-mode, use the visibility state, otherwise always treat the object as visible (P1956).

This means you won't be able to enter sculpt mode on a hidden object (same as edit-mode), but you will still be able to exit.

Any operators that cause problems when activated on an invisible object - can warn/error on activation.

Suggested Solution

In most cases fixing the current behavior is reasonable, however this further complicates code in a way that doesn't help users.

This is a corner case that shouldn't crash or fail entirely, but I don't think we should be spending development time to support these corner cases.

For example, if we treat collection visibility the same as object visibility, we would need to support scenes with an animated collection-visibility properly updating cursors/gizmos etc... since it would be effectively animating the object's mode.

If we choose not to support this corner-case, we have the current situation where visibility sometimes changes the object mode, other times not.

I'd suggest we extend the edit-mode exception, or at least opt for a change that keeps behavior straightforward / simple.

There are currently multiple bugs/inconsistencies when the active object can be hidden while being edited. The 3D views "active_object" checks visibility, returning NULL when when it's hidden. This has the result of showing the 3D view as being in object-mode when the active object is hidden. There is an exception to this rule - edit-mode always returns the active object, ignoring the hidden state. As far as I know, this is mostly a result of incremental tweaks & fixes, not a design decision. ----- ## Current Issues The logic to always be in object-mode with a hidden active object isn't working properly. - When the collection is hidden, the object can be sculpted onto, but when the object is hidden it can't be. - The tool system currently follows the active object, ignoring it's hidden state. - #83013 (Crash when using annotation tool on object hidden in sculpt mode). Note, fixing this isn't so complicated, it's just an example of the current behavior being error prone. ## Possible Solutions **Fix the current behavior:** Fully support object mode behavior when the active object in a mode is hidden. - Take into account the hidden state of the collection. - Make the tool system respect the active-objects hidden state, refreshing the tool system on visibility changes. - Make transform logic use contexts active object. **Ignore visibility flag when editing:** While I'm not so keen on this, adding for completeness. We could ignore the visibility option when the active object isn't in object mode. **Extend the edit-mode exception:** Extend the edit-mode exception to all object editing modes. - When in object-mode, use the visibility state, otherwise always treat the object as visible ([P1956](https://archive.blender.org/developer/P1956.txt)). ``` This means you won't be able to enter sculpt mode on a hidden object (same as edit-mode), but you will still be able to exit. ``` - Any operators that cause problems when activated on an invisible object - can warn/error on activation. ## Suggested Solution In most cases fixing the current behavior is reasonable, however this further complicates code in a way that doesn't help users. This is a corner case that shouldn't crash or fail entirely, but I don't think we should be spending development time to support these corner cases. For example, if we treat collection visibility the same as object visibility, we would need to support scenes with an animated collection-visibility properly updating cursors/gizmos etc... since it would be effectively animating the object's mode. If we choose not to support this corner-case, we have the current situation where visibility sometimes changes the object mode, other times not. I'd suggest we extend the edit-mode exception, or at least opt for a change that keeps behavior straightforward / simple.

Campbell Barton self-assigned this 2021-02-11 01:10:40 +01:00

Campbell Barton commented

2021-02-11 01:10:40 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Campbell Barton commented

2021-02-11 01:10:40 +01:00

Added subscribers: @ideasman42, @brecht, @mont29

Campbell Barton commented

2021-02-11 01:14:30 +01:00

Added subscriber: @DanielBystedt

Brecht Van Lommel commented

2021-02-11 15:02:39 +01:00

I'd suggest we extend the edit-mode exception

Fine with me.

> I'd suggest we extend the edit-mode exception Fine with me.

Bastien Montagne commented

2021-02-11 18:21:51 +01:00

In #85532#1110535, @brecht wrote:

I'd suggest we extend the edit-mode exception

Fine with me.

Same for me, looks like the most reasonable solution.

> In #85532#1110535, @brecht wrote: >> I'd suggest we extend the edit-mode exception > > Fine with me. Same for me, looks like the most reasonable solution.

Daniel Bystedt commented

2021-02-11 23:43:33 +01:00

I'd suggest we extend the edit-mode exception, or at least opt for a change that keeps behavior straightforward / simple.

I agree with what Campbell is suggesting

> I'd suggest we extend the edit-mode exception, or at least opt for a change that keeps behavior straightforward / simple. I agree with what Campbell is suggesting

Campbell Barton commented

2021-02-12 07:35:35 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2021-02-12 07:35:35 +01:00

Campbell Barton commented

2021-02-12 07:35:35 +01:00

Thanks for checking on this, committed c10ad8e9ea.

Thanks for checking on this, committed c10ad8e9ea.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Proposal to change behavior when the active object is hidden #85532

Current Issues

Possible Solutions

Suggested Solution