Page MenuHome
Create Task
Maniphest T85549

GPencil's draw tool has its strokes offset after using fill tool
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.40

Blender Version
Broken: 2.93.0 Alpha, branch: master, commit date: 2021-02-10 21:40, hash: rB175325ebdb5b
Worked: 2.93.0 Alpha, branch: master, commit date: 2021-02-08 23:42, hash: rBeab9165c2512

Short description of error
After using the fill tool the grease pencil draw tool doesn't work correctly and draws strokes offset from the cursor.
I suspect the recent new fill features commit is the culprit (rB1352d81b1747)

Note: fill tool also stops working correctly after doing this as well and just fills the entirety of the viewable canvas no matter where strokes are.

Exact steps for others to reproduce the error

  • Use default 2d animation layout (issue persists in other layouts just listing exact steps)
  • draw circle
  • fill circle with fill material using fill tool
  • switch back to draw tool and try to draw line

Also see video

Revisions and Commits

rB Blender
rB1ec626f4bd06 Fix T85549: GPencil draw tool offset when UI scale is not 1

Related Objects

Event Timeline

Jonathan Mielke (jsm) created this task.Thu, Feb 11, 1:19 PM
Jonathan Mielke (jsm) edited projects, added Grease Pencil, BF Blender (2.93); removed BF Blender.
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Thu, Feb 11, 4:10 PM

I cannot reproduce it in my Windows system with the last master code.

Antonio Vazquez (antoniov) closed this task as Resolved.Thu, Feb 11, 4:11 PM
Antonio Vazquez (antoniov) claimed this task.
Antonio Vazquez (antoniov) added a subscriber: Falk David (filedescriptor).

@Falk David (filedescriptor) can you reproduce it?

Jonathan Mielke (jsm) added a comment.Fri, Feb 12, 10:24 AM

So tried to repo on another computer and couldn't.
Can still reproduce on latest buildbot with original system.
But discovered more weirdness. I only have this issue on one monitor. using either of my 2 other connected monitors and I don't have the issue.
The troublesome monitor is an: ASUS MG278Q running at 1440p 144hz (changing resolution/hz size did not fix bug either)
Will try to narrow down and get it reproducible on other monitors.

Jonathan Mielke (jsm) added a comment.EditedFri, Feb 12, 10:37 AM

Annnnd Figured out what the difference between the monitors. The Windows scale and layout settings was set over 100% at 150% on my one monitor.

So to reproduce set monitor scaling at or above 150 % in windows display settings.

Then do original steps described in initial report.

Falk David (filedescriptor) closed this task as a duplicate of T85476: Multi-monitor window scale problem.Fri, Feb 12, 11:32 AM
Jonathan Mielke (jsm) added a comment.EditedSun, Feb 21, 8:34 AM

I'm now not sure it's the same bug as the T85476: Multi-monitor window scale problem.
When running at at default 100% windows scale and with a single monitor I'm having offset issues like before on the latest buildbot (version: 2.93.0 Alpha, branch: master, commit date: 2021-02-20 05:19, hash: rB37e6a1995ac7).
The only thing that's different is that I set the blender preferences > interface > Display> Resolution Scale to 1.2 or above in blender user preferences. And using the windows compatibility option, override High DPI Scaling behavior, is no longer fixing it.

Tested on a second system as well.
Operating system: Windows-10 64 Bits
Graphics card: Radeon RX 580 Series ATI Technologies Inc. 4.5.13596 Core Profile Context 20.10.35.02 27.20.1034.6

Antonio Vazquez (antoniov) reopened this task as Confirmed.Sun, Feb 21, 4:17 PM
Antonio Vazquez (antoniov) changed the subtype of this task from "Report" to "Known Issue".

Yes, actually is not supported to use a resolution different of 1.0. The problem is not only in Fill.

Antonio Vazquez (antoniov) added subscribers: Hans Goudey (HooglyBoogly), Julian Eisel (Severin).EditedMon, Feb 22, 9:40 AM

@Hans Goudey (HooglyBoogly) @Julian Eisel (Severin) I have tested and this bug is not in 2.83. I have not changed anything in the code related to this area, so do you know what can be the problem? Maybe some UI change?

EDIT: I tested and the problem drawing stroke was gone, and now is only fill, so I need investigate because this can be a problem in gpencil code.

Antonio Vazquez (antoniov) changed the subtype of this task from "Known Issue" to "Bug".Mon, Feb 22, 5:11 PM
Antonio Vazquez (antoniov) closed this task as Resolved by committing rB1ec626f4bd06: Fix T85549: GPencil draw tool offset when UI scale is not 1.Mon, Feb 22, 5:19 PM
Antonio Vazquez (antoniov) added a commit: rB1ec626f4bd06: Fix T85549: GPencil draw tool offset when UI scale is not 1.