Page MenuHome
Create Task
Maniphest T85768

Toggle Window Fullscreen broken for New Window (Titlebar visible)
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows 7 / 10

Blender Version
Broken: 2.93 f5c781af5643 (2021-02-08)
Working: 2.92 7fb540b4cf17 (2021-02-04)

Short description of error
Titlebar still visible for New Windows when Toggled Fullscreen

Exact steps for others to reproduce the error

  • invoke: Window - New Window, OR run bpy.ops.wm.window_new()
  • press F3, search for "fullscreen"
  • choose Toggle Window Fullscreen
  • window is maximized, but it's Titlebar not hidden

Apparently this changed after 492e64c7bcbd
Initial user report - https://blender.community/c/rightclickselect/pbhbbc/

Revisions and Commits

rB Blender
D10470rBbeb1f1b8053a Win32: Do not (yet) set window styles for Dialog
D10470rB46bdf6d59fc6 Fix T85768: Win32 Full-Screen Owned Windows

Related Objects

Event Timeline

Ermins Ermanis (erminos) created this task.Thu, Feb 18, 2:17 PM
Philipp Oeser (lichtwerk) added a project: Platform: Windows.Thu, Feb 18, 3:10 PM
Philipp Oeser (lichtwerk) added subscribers: Harley Acheson (harley), Philipp Oeser (lichtwerk).

@Harley Acheson (harley): cant check this [Linux only], but does this ring a bell?

daniel (sculptkid) added a subscriber: daniel (sculptkid).Thu, Feb 18, 3:17 PM
Germano Cavalcante (mano-wii) changed the task status from Needs Triage to Confirmed.Thu, Feb 18, 3:33 PM
Germano Cavalcante (mano-wii) changed the subtype of this task from "Report" to "Bug".
Germano Cavalcante (mano-wii) added a project: User Interface.
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

I can confirm.
The title bar (white and at the top) does not disappear as in the main window.

Harley Acheson (harley) claimed this task.Thu, Feb 18, 3:40 PM

Yes, I was going to write this same bug report this morning, based on someone’s mention of this issue on RCS.

My plan was to look at the Window/New Window and New Main Window after D10419, but there might not be overlap so will dive into this right away. Full screen should work for any window that is maximizable, and I’m hoping New Window can get a simpler layout, while simplifying the code somewhat too.

Harley Acheson (harley) added a revision: D10470: Fix T85768: Win32 Full-Screen Owned Windows.Sun, Feb 21, 7:02 PM
Harley Acheson (harley) closed this task as Resolved by committing rB46bdf6d59fc6: Fix T85768: Win32 Full-Screen Owned Windows.Mon, Feb 22, 6:32 PM
Harley Acheson (harley) added a commit: rB46bdf6d59fc6: Fix T85768: Win32 Full-Screen Owned Windows.
Harley Acheson (harley) added a commit: rBbeb1f1b8053a: Win32: Do not (yet) set window styles for Dialog.Mon, Feb 22, 9:48 PM
Ermins Ermanis (erminos) awarded a token.Wed, Feb 24, 7:51 AM