color style of banner in Python Console arouse ambiguity #85841

New Issue

cadtofu · 2021-02-21T12:32:36+01:00

cadtofu commented

2021-02-21 12:32:36 +01:00

System Information
version: version: 2.92.0 Beta, branch: master, commit date: 2021-02-14 19:51, hash: 2d3b29de4f, type: Release
build date: 2021-02-14, 23:41:19
and history versions, at least since Blender 2.80
platform: Windows

Short description of error
Python Console use so-called "OUTPUT" color style for its banner info, which arouse ambiguity with real OUTPUT scrollback messages.
This issue has nothing to do with User Preferences >Themes.

Exact steps for others to reproduce the error
step 1. Open a Python Console, then banner info is displayed.
step 2. Send some output message to Python Console.

Suggestion:
Change banner style from "OUTPUT" to "INFO".
File: "..\scripts\modules\console_python.py"
Line: 356

    for line in message:
        #rv-  add_scrollback(line, 'OUTPUT')
        add_scrollback(line, 'INFO')  #rv+

**System Information** version: version: 2.92.0 Beta, branch: master, commit date: 2021-02-14 19:51, hash: 2d3b29de4fc7, type: Release build date: 2021-02-14, 23:41:19 and history versions, at least since Blender 2.80 platform: Windows **Short description of error** Python Console use so-called "OUTPUT" color style for its banner info, which arouse ambiguity with real OUTPUT scrollback messages. This issue has nothing to do with User Preferences >Themes. **Exact steps for others to reproduce the error** step 1. Open a Python Console, then banner info is displayed. step 2. Send some output message to Python Console. ![fsc_2021-02-21_184656_g.jpg](https://archive.blender.org/developer/F9825044/fsc_2021-02-21_184656_g.jpg) Suggestion: Change banner style from "OUTPUT" to "INFO". File: "..\scripts\modules\console_python.py" Line: 356 ``` for line in message: #rv- add_scrollback(line, 'OUTPUT') add_scrollback(line, 'INFO') #rv+ ``` ![fsc_2021-02-21_184757_g.jpg](https://archive.blender.org/developer/F9825056/fsc_2021-02-21_184757_g.jpg)

cadtofu commented

2021-02-21 12:32:36 +01:00

Added subscriber: @cadtofu

Bastien Montagne commented

2021-03-01 16:05:22 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2021-03-01 16:05:22 +01:00

@cadtofu please do not set release goals yourself, only active developers should be in charge of that.

cadtofu commented

2021-03-03 08:12:48 +01:00

In #85841#1121668, @mont29 wrote:
@cadtofu please do not set release goals yourself, only active developers should be in charge of that.

Sorry, I misunderstood that tag indicates affected version.
Now, I see.
Thant you, Bastien.

> In #85841#1121668, @mont29 wrote: > @cadtofu please do not set release goals yourself, only active developers should be in charge of that. Sorry, I misunderstood that tag indicates affected version. Now, I see. Thant you, Bastien.

Campbell Barton commented

2021-04-28 16:15:18 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2021-04-28 16:15:18 +02:00

This seems like a reasonable change, although I don't have a strong opinion.

Philipp Oeser commented

2021-09-20 15:03:40 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-09-20 15:03:40 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-09-20 15:03:40 +02:00

In #85841#1153293, @ideasman42 wrote:
This seems like a reasonable change, although I don't have a strong opinion.

Will confirm then.

@cadtofu : might seem bureaucratic for such a small change, but could you submit your patch through https://developer.blender.org/differential/diff/create/ ?

> In #85841#1153293, @ideasman42 wrote: > This seems like a reasonable change, although I don't have a strong opinion. Will confirm then. @cadtofu : might seem bureaucratic for such a small change, but could you submit your patch through https://developer.blender.org/differential/diff/create/ ?

Harley Acheson commented

2021-09-20 16:10:57 +02:00

Added subscriber: @Harley

Harley Acheson commented

2021-09-20 16:10:57 +02:00

@cadtofu - if you are unsure of next steps, feel free to contact me .

@cadtofu - if you are unsure of next steps, feel free to [contact me ](https://developer.blender.org/p/harley/).

cadtofu commented

2021-10-23 14:34:27 +02:00

@philipp-14 Oeser (lichtwerk)
@Harley Acheson (harley)
Thank you guys. I never used git before. I struggled several times, but failed to submit the diff result.
Error promt:
https://developer.blender.org/differential/diff/create/ ?

Unhandled Exception ("AphrontQueryException")
#1048: Column 'filename' cannot be null

Diff result based on: blender 3.0 alpha (2021-10-22 daily build)
blender-3.0.0-alpha+master.ab1909fe06b0-windows.amd64-release.zip
Platform: Windows x64
File:［blender]\3.0\scripts\modules\console_python.py

diff --git a/from/console_python.py b/to/console_python.py
index 3cc38bd..cdc3e09 100644
--- a/from/console_python.py
+++ b/to/console_python.py
@@ -351,7 +351,7 @@ def banner(context):
     )
 
     for line in message:
-        add_scrollback(line, 'OUTPUT')
+        add_scrollback(line, 'INFO')
 
     sc.prompt = PROMPT

@philipp-14 Oeser (lichtwerk) @Harley Acheson (harley) Thank you guys. I never used git before. I struggled several times, but failed to submit the diff result. Error promt: https://developer.blender.org/differential/diff/create/ ? > Unhandled Exception ("AphrontQueryException") > #1048: Column 'filename' cannot be null > Diff result based on: blender 3.0 alpha (2021-10-22 daily build) blender-3.0.0-alpha+master.ab1909fe06b0-windows.amd64-release.zip Platform: Windows x64 File:［blender]\3.0\scripts\modules\console_python.py **** ``` diff --git a/from/console_python.py b/to/console_python.py index 3cc38bd..cdc3e09 100644 --- a/from/console_python.py +++ b/to/console_python.py @@ -351,7 +351,7 @@ def banner(context): ) for line in message: - add_scrollback(line, 'OUTPUT') + add_scrollback(line, 'INFO') sc.prompt = PROMPT ```

cadtofu commented

2021-10-23 14:43:15 +02:00

Added subscriber: @philipp-14

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

color style of banner in Python Console arouse ambiguity #85841