bpy.types.SpaceView3D.draw_handler_remove(...) causes Blender to crash #86106

New Issue

Sebastian · 2021-02-28T22:51:10+01:00

Sebastian commented

2021-02-28 22:51:10 +01:00

System Information
Operating system: Linux-5.4.0-66-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.102.04

Blender Version
Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: 02948a2cab
Worked: never

Short description of error
Using bpy.types.SpaceView3D.draw_handler_remove(...) causes Blender to crash.

Exact steps for others to reproduce the error

Open the attached script in the script editor
Uncomment line 80-82
Run the script
Delete the empty named "anchor"

ED_region_draw_cb_draw(const bContext * C, ARegion * region, int type) Line 266	C
DRW_draw_callbacks_post_scene() Line 1439	C
DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1646	C
DRW_draw_view(const bContext * C) Line 1514	C
view3d_draw_view(const bContext * C, ARegion * region) Line 1607	C
view3d_main_region_draw(const bContext * C, ARegion * region) Line 1630	C
ED_region_do_draw(bContext * C, ARegion * region) Line 563	C
wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 732	C
wm_draw_window(bContext * C, wmWindow * win) Line 875	C
wm_draw_update(bContext * C) Line 1074	C
WM_main(bContext * C) Line 644	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 526	C

Original description:
Please execute the python script below.
{F9853647}

The script uses bpy.types.SpaceView3D.draw_handler_add()to add a call back function that draws a simple point cloud.
The drawing of the point cloud depends on an empty object named anchor.
If the user deletes this object, the point cloud is no longer drawn (and the call back should be removed with bpy.types.SpaceView3D.draw_handler_remove(...)).
Currently, bpy.types.SpaceView3D.draw_handler_remove(...) is commented out to show this behavior.
When uncommenting bpy.types.SpaceView3D.draw_handler_remove(...) (see line 80) to remove the callback, Blender crashes.

The corresponding error message of /tmp/blender.crash.txt can be found in the following file:
{F9853675}

**System Information** Operating system: Linux-5.4.0-66-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.102.04 **Blender Version** Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: never **Short description of error** Using bpy.types.SpaceView3D.draw_handler_remove(...) causes Blender to crash. **Exact steps for others to reproduce the error** - Open the attached script in the script editor - Uncomment line 80-82 - Run the script - Delete the empty named "anchor" ```lines ED_region_draw_cb_draw(const bContext * C, ARegion * region, int type) Line 266 C DRW_draw_callbacks_post_scene() Line 1439 C DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1646 C DRW_draw_view(const bContext * C) Line 1514 C view3d_draw_view(const bContext * C, ARegion * region) Line 1607 C view3d_main_region_draw(const bContext * C, ARegion * region) Line 1630 C ED_region_do_draw(bContext * C, ARegion * region) Line 563 C wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 732 C wm_draw_window(bContext * C, wmWindow * win) Line 875 C wm_draw_update(bContext * C) Line 1074 C WM_main(bContext * C) Line 644 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 526 C ``` ----------- Original description: Please execute the python script below. {F9853647} The script uses `bpy.types.SpaceView3D.draw_handler_add()`to add a call back function that draws a simple point cloud. The drawing of the point cloud depends on an empty object named `anchor`. If the user deletes this object, the point cloud is no longer drawn (and the call back should be removed with `bpy.types.SpaceView3D.draw_handler_remove(...)`). Currently, `bpy.types.SpaceView3D.draw_handler_remove(...)` is commented out to show this behavior. When uncommenting `bpy.types.SpaceView3D.draw_handler_remove(...)` (see line 80) to remove the callback, Blender crashes. The corresponding error message of `/tmp/blender.crash.txt` can be found in the following file: {F9853675}

Sebastian commented

2021-02-28 22:51:10 +01:00

Added subscriber: @sbcv

Robert Guetzkow commented

2021-02-28 23:25:32 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2021-02-28 23:32:23 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2021-02-28 23:32:23 +01:00

I'm marking this as confirmed, but given the reference passing of an object that is no longer valid at a later point in time this might be an unsupported use case / a limitation by the Python API (see the Gotchas of the Python API, especially about storing references to objects). However, I believe this is a bug since removing the handler should not be causing the problem, but someone more familiar with the design of the draw handler should take a look at this.

I'm marking this as confirmed, but given the reference passing of an object that is no longer valid at a later point in time this might be an unsupported use case / a limitation by the Python API (see the [Gotchas ](https://docs.blender.org/api/current/info_gotcha.html#help-my-script-crashes-blender) of the Python API, especially about storing references to objects). However, I believe this is a bug since removing the handler should not be causing the problem, but someone more familiar with the design of the draw handler should take a look at this.

Sebastian commented

2021-03-01 10:11:46 +01:00

Thank you for having a look at this.
I also thought about this. This is why I tried to keep a reference with

bpy.types.Object.current_draw_manager = draw_callback_handler

that allows to access the draw_callback_handler after the script terminated.
Even with the line above, the example script kept crashing. (However, I'm unsure if bpy.types.Object.current_draw_manager = draw_callback_handler achieves the intended effect.)

Thank you for having a look at this. I also thought about this. This is why I tried to keep a reference with ``` bpy.types.Object.current_draw_manager = draw_callback_handler ``` that allows to access the `draw_callback_handler` after the script terminated. Even with the line above, the example script kept crashing. (However, I'm unsure if `bpy.types.Object.current_draw_manager = draw_callback_handler` achieves the intended effect.)

Robert Guetzkow commented

2021-03-01 14:15:21 +01:00

Added subscriber: @mano-wii